From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA6B3A034C; Wed, 22 Jun 2022 18:03:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76C3E40A84; Wed, 22 Jun 2022 18:03:52 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 463244069F for ; Wed, 22 Jun 2022 18:03:51 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EAB3B32009C5; Wed, 22 Jun 2022 12:03:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 22 Jun 2022 12:03:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655913828; x= 1656000228; bh=TECHhlTRI8N+xgHFAk7plZLC1Qv/AR4ZX3Ek3u5oAHA=; b=h i6v3z8czGqIbQhtIZJgI00/pQg8IsiRSY0tztcvbDIjJe6oKjLbht+atfZt8kyar GEXWPlEM0SbzKFs1+E7rR9+ApMo5hTviJEkBrkLJAkKDhwEc482Fb7A7xkkGQz+C hCzAVVcYxZgNJGAc0KCGTPKIEwJcvmRHxKajBcMMaXwIz8SMlLDdZsrWwPoAuM93 qmweSdAaYvFnRQNCbrdPGJlJ/GcHQh2ISJW5eZlE8GDJsnJq56z2uQvPVGwdMK7E MnWgGbmv2olIYUhhNLQCe0lonrI4r2ppyjSsSEgMdOg3mT+1ih4+m1UBXbNwVnlr Y4QZXyCF5WRZZ/V0mx7YQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655913828; x= 1656000228; bh=TECHhlTRI8N+xgHFAk7plZLC1Qv/AR4ZX3Ek3u5oAHA=; b=S k0PD8FRzGVlWJXpzJUtTuGnE+6AtFpbpJ77uLgBnT1O9Ckx/mAGFQV+5zRw5nxg8 M++e5lPHkqlMkvoJIVjlSFQyPVrHQcTUWooS2IIGK2ml3BVumnKDl3AQp/xQ3kjq YjXHRZEmSMw4go4kz2kYcik5xFuOc23VEUF4GmLsTAvWHXERme0Tc28N3zi8CRUy 75Cz433za3kAt/hEjK44bXO0BlRVZVgoqzM0unudhot7Pg6f2d8JQLCDQBR/gPfD x9OzbSXbdFX/UhMYK/OsZIqKSPalFf5kfoIhyQLSmsU80HRL6SiHI9i+bIMj7VI/ HPWEJBs8n6HouJODe2Whg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefhedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Jun 2022 12:03:46 -0400 (EDT) From: Thomas Monjalon To: Jin Liu Cc: dev@dpdk.org, niklas.soderlund@corigine.com, Jin Liu , Diana Wang , Peng Zhang , Chaoyong He , ferruh.yigit@amd.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru Subject: Re: [PATCH v3 12/13] net/nfp: nfdk packet xmit function Date: Wed, 22 Jun 2022 18:03:43 +0200 Message-ID: <3767635.TLnPLrj5Ze@thomas> In-Reply-To: <20220617093444.2004000-13-jin.liu@corigine.com> References: <20220616023939.1798769-1-jin.liu@corigine.com> <20220617093444.2004000-1-jin.liu@corigine.com> <20220617093444.2004000-13-jin.liu@corigine.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/06/2022 11:34, Jin Liu: > + if (unlikely(pkt->nb_segs > 1 && > + !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) { > + PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set"); > + rte_panic("Multisegment packet unsupported\n"); > + } [...] > + if (round_down(txq->wr_p, NFDK_TX_DESC_BLOCK_CNT) != > + round_down(txq->wr_p + used_descs - 1, NFDK_TX_DESC_BLOCK_CNT)) { > + rte_panic("Used descs cross block boundary\n"); > + } You cannot use rte_panic in a driver or library. It will make the user experience terrible. If there is a failure, please log an error and return appropriately. There is a check in the CI to avoid such use: https://patches.dpdk.org/project/dpdk/patch/20220617093444.2004000-13-jin.liu@corigine.com/ https://mails.dpdk.org/archives/test-report/2022-June/290206.html It seems you've ignored this critical warning. I don't want to let new occurences of rte_panic enter in drivers, so I'll drop this patch from the main branch. Please re-submit without rte_panic.