From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 806387E6E
 for <dev@dpdk.org>; Thu, 16 Oct 2014 21:49:02 +0200 (CEST)
Received: by mail-wg0-f46.google.com with SMTP id l18so4539725wgh.29
 for <dev@dpdk.org>; Thu, 16 Oct 2014 12:56:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=oyLHN6vnN8hZY0qOAql9cTuU6SgnPNZd9ryLTaO8Jk0=;
 b=MvDxRVjJgMW92hJvZGiIn8qWM59SwR2b60Vf4H+95zLPkGvqr2Kvb/kY92S63xYkBi
 +EjjTmcE2itDHZMyaVPGir6A/SPjZvzyocbUPjjPBEPxAkYAla4lVphI/O6Oc87cNTcD
 ZW4Lnv3XoH855WvnW0XywDvT9vPxN5YdiARMQ2JflEmqh6cQvm2URb4SGh3nfeiJPJUJ
 eu0lvcxEwqkd2FudTBrkBr1MMjNIXWtJdzgV5jMd9fL0fBPYLkwOI6sjCZPUDIwQ+TM7
 aRHfLYd5CcMEob/r8sxv6t0WscY4zoEJmEc3NmxTfNO64R0Z1XrFpy1xiEC+L8KtPUz/
 c/mg==
X-Gm-Message-State: ALoCoQmuRsexVj7yN9f1C6YM+nBYMLs3KiRNJgIMrCaPZIudPke2G6VGhtKEa/ArhWp3/GBWgUJF
X-Received: by 10.180.36.38 with SMTP id n6mr8421342wij.27.1413489417251;
 Thu, 16 Oct 2014 12:56:57 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id u2sm28583614wjz.11.2014.10.16.12.56.55
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Oct 2014 12:56:56 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Date: Thu, 16 Oct 2014 21:56:39 +0200
Message-ID: <3781474.dkZOSRuQuF@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )
In-Reply-To: <1413006935-22535-3-git-send-email-jijiang.liu@intel.com>
References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com>
 <1413006935-22535-3-git-send-email-jijiang.liu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet
	identification in librte_pmd_i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2014 19:49:03 -0000

2014-10-11 13:55, Jijiang Liu:
>  #
> +# Compile tunneling UDP port support
> +#
> +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789
> +
> +#

1) this option is not to "Compile tunneling UDP port support"
2) why is it a compile time option? should it be an API parameter or
a runtime option?

> +	uint16_t packet_type;     /**< Packet type, which indicates packet format */

It's not very clear what packet type is.
There is maybe a more precise description, or is it hardware dependent?

>  static struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf,
> -						struct i40e_vsi *vsi);
> +					struct i40e_vsi *vsi);

It's not related to VXLAN.

-- 
Thomas