From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA83FA0353;
	Thu,  6 Aug 2020 18:09:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 407372BF1;
	Thu,  6 Aug 2020 18:09:44 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6085C2B87
 for <dev@dpdk.org>; Thu,  6 Aug 2020 18:09:43 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 05A015C0121;
 Thu,  6 Aug 2020 12:09:43 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Thu, 06 Aug 2020 12:09:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 U5szA9QYZdbvMrSPNHVYIOZ0jCO8uOVNdlpeQe2SlL4=; b=MhLrVucv9yR+sdk0
 f6cMd+PkME0bnupsLd8Hkfdhbx7D85H8wmhSzITTVwCKU/VcufeVDApSCVvDuXs3
 uaQsY0WccNA5kOhFlovP+h7VUFL+jBduiw0KbcmeCIHDeNRtA3ZpF2Fojzx/Oot7
 Gl7gAHPUmXjWVWCysmudkVjiEWjoKvx/xxk+Km8FeBJGbNLUAIIZVy63FxBtED6J
 a8D8evUqGV87mHkZjTd6jLnGokpZsnKTwyfrToBjoM10t+iSi8s1y0DL01CA6WAy
 7bV7TL+oBJTfz3jpLgfCEa9oaQs4xdz97GJP12BTn1r0i+nWjYEfLYyV3Fr08AsV
 XHkOwQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=U5szA9QYZdbvMrSPNHVYIOZ0jCO8uOVNdlpeQe2Sl
 L4=; b=c5kjjZwCREccmTxvGbrgNUJft2Oo3eRb845OOJVLU09IDdXT3FlSVpUdW
 xKnfsCR0Oq5APphMmo6QVbN1dbqa4uQ084PGKisjXqBFNjlzWGWqfjDZ1WkNOrW9
 RKdi5ZSUuNBFgglv+nk4lV097o+RmatHfnvm+8fpLSonpOdV1MIoAozHlPYZD38u
 WIbELEkXJAWAxqVNSwFI/Wdv40Kdm2ImtB5aVHDVDos4dv2m7LOjYHTdLHtM1HUv
 qHWd9sWhdpx2XPQuxAnGCAelJrwO2Byne9Iz25ynVX84fGqrfTbFZcEGNPfSoB+p
 r0z6f4pU91IeUlyWnR4nwF5AuHT1Q==
X-ME-Sender: <xms:RissX656zidk1e2Jhb7cv8D_gJWO5Y7oRMRLCcsFMMUllBnj997KJA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrkedtgddutddtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepvdekteeviefhgeeftdefjeeukeekkeeuvefgjeeuvdeivddvveeu
 gfetvedtfeevnecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd
 dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf
 rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:RissXz6sgLmBzUVxWgixx8RMDBPUgIMPIuNYYvl3J9u-yKHb-jfjew>
 <xmx:RissX5diERuSjxKtymwYaz8-7DVlg3HkNILYHkKzgM5iFdS6aUTuPg>
 <xmx:RissX3IQEj_7p0Y0-lx68xlyKMNuaNZs2onY6-7o6rL0K6wNVYVjmA>
 <xmx:RissX2_npzrxiHttVRpVYp-07MVZCCSMgSYHrhTOiEQbatZ3BxnVUQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8EC8D3280068;
 Thu,  6 Aug 2020 12:09:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
 David Marchand <david.marchand@redhat.com>, "Kusztal,
 ArkadiuszX" <arkadiuszx.kusztal@intel.com>, Anoob Joseph <anoobj@marvell.com>,
 Akhil Goyal <akhil.goyal@nxp.com>
Cc: dev@dpdk.org, "shallyv@marvell.com" <shallyv@marvell.com>, "Doherty,
 Declan" <declan.doherty@intel.com>, "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Date: Thu, 06 Aug 2020 18:09:40 +0200
Message-ID: <3785663.8APzvf4N2U@thomas>
In-Reply-To: <VI1PR04MB31687BF53B2106212A8BD640E64E0@VI1PR04MB3168.eurprd04.prod.outlook.com>
References: <20200729144651.17524-1-arkadiuszx.kusztal@intel.com>
 <SN6PR11MB28808412C9B2EE2F8C858FC5E4700@SN6PR11MB2880.namprd11.prod.outlook.com>
 <VI1PR04MB31687BF53B2106212A8BD640E64E0@VI1PR04MB3168.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list
	end enumerators
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/07/2020 11:38, Akhil Goyal:
> Hi David,
>=20
> > Hi David,
> >=20
> > >
> > > On Wed, Jul 29, 2020 at 4:47 PM Arek Kusztal
> > > <arkadiuszx.kusztal@intel.com> wrote:
> > > >
> > > > Enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > RTE_CRYPTO_AUTH_LIST_END,
> > > > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems
> > > > that may arise when adding new algorithms.
> > >
> > > How does it cohabitate with Ferruh notice?
> > > Is it a complement? or redundant?
> > >
> > >
> > https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?i=
d=3D58245da070289f4b248f15
> > >
> > Thanks for drawing attention to this.
> > It's complementary as far as I can see.
> > Ferruh's doesn't list all enums - but doesn=E2=80=99t appear to cover t=
hese crypto ones.
>=20
> I feel we can have this deprecation notice as well for crypto specific en=
ums.
> Though I don=E2=80=99t want to push it if somebody has objections on this.
> I am OK if Ferruh's notice looks enough to cover crypto enums as well.
>=20
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> If no objections, Thomas or you can pick this directly on master.

I think Ferruh notice would be enough, except it focus on "MAX" values,
not including the similar ones with "END" in their names.

Anyway, too much notices don't hurt.

Applied