From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 5BD818044
 for <dev@dpdk.org>; Mon,  1 Dec 2014 12:21:17 +0100 (CET)
Received: by mail-wi0-f178.google.com with SMTP id hi2so16876238wib.17
 for <dev@dpdk.org>; Mon, 01 Dec 2014 03:21:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=se87cDHsneV2xgETdq8AOUGpFEX/dJ4cdDdHPEUf6zI=;
 b=m3m39/7h9foTshm7TFYNbRRsHRp1MrTMw2yGTii4j0UeVq1P7u59w0TwWQDbjBetEZ
 9ZIZf9fDL+u8dPZOFWiOXJguA/oPItxJXGxAyBz79N7KE6Mi1v7f5Chlx6LD6yJlcKbP
 XiLXwTxaLgu3SiAuRzF15qK+YbiJoS9C44wy+QSHG6XnZG46v2DF8MTQfOfCtGeTlLvQ
 s/Kn0HzMO7zOiJhdpwR9dcHkZsBZETEQoBRs8Cjr34vIUlvR8c07Ic9wb0Bk2mKqAF3t
 z8p97w8A1Vr5lK/83/vH3xq6APONd3p8xAsPgd5Sp0aEzi49sx4KMQVBkg/dq3L3hYWB
 8piQ==
X-Gm-Message-State: ALoCoQnKxg5PpHBMZXEy4J7RBHlWkl/2B9ZcASf0Nz1csm8NCocss+QTAn7KJZT5txyht90BslFE
X-Received: by 10.180.81.7 with SMTP id v7mr82303428wix.74.1417432877221;
 Mon, 01 Dec 2014 03:21:17 -0800 (PST)
Received: from xps13.localnet (177.17.90.92.rev.sfr.net. [92.90.17.177])
 by mx.google.com with ESMTPSA id k5sm19820491wjn.1.2014.12.01.03.21.15
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 01 Dec 2014 03:21:16 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Date: Mon, 01 Dec 2014 12:20:44 +0100
Message-ID: <3788591.z9f9ZD7Av4@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <20141201105250.GA4856@bricha3-MOBL3>
References: <1417430173-24502-1-git-send-email-olivier.matz@6wind.com>
 <20141201105250.GA4856@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: change assignation of bitfields to
	fix clang compilation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 11:21:17 -0000

> > Commit 1224decaa44b3dba58e0a524fd0383969929c575 changed the way
> > the bitfields are assigned in ixgbe, example:
> > 
> >   tx_offload_mask.l2_len = ~0;
> > 
> > This result in a compilation error with clang:
> > 
> >    error: implicit truncation from 'int' to bitfield
> >     changes value from -1 to 127 [-Werror,-Wbitfield-constant-conversion]
> > 
> > Replacing the '=' with a '|=' fixes the issue.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied

Thanks
-- 
Thomas