From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3A1844BE1
 for <dev@dpdk.org>; Thu, 22 Jun 2017 18:05:43 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 98EC420AC7;
 Thu, 22 Jun 2017 12:05:43 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 22 Jun 2017 12:05:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Qu/jgjnGmn5bXi5
 vSUEvJ5PDG3jzQ1JLTzaD1mkXmkc=; b=e8tO6v361bOJ3JA2rGxE+QBFzIqq/iR
 yuFhBd6EzmnTqiCz6Z4wIf8TUK30ehfhPieFm5ubF7vegpBUFBlYm80Lmwko6wAV
 9M1hlrXBesFtHmGChAUuEIIjeCQZCqOkh7jN7+vJ/Tw4YEuRurUSm6ru+nrjR34+
 LY/5IeTfCdNc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=Qu/jgjnGmn5bXi5vSUEvJ5PDG3jzQ1JLTzaD1mkXmkc=; b=eDBk9ly6
 sspw2OPdjkZmbFAyEnltHyQWU7chO3FbX10bYrfzbZ3Uz/cOfpM0aAqaDkszY8fu
 ppZw1ypZnoMbIF7s+EWwAAUz4wwrChHCoP9U8GVygGwa6tpYZmLZUs8CBmeLSmI9
 yUsPj3mOC9vt1MX1P2HnSQ1klVOh/QwrEL6VcF32uX1Qfv0HZ7fUP25XYxqYIx/1
 f0AQ+pSWQtf6S7f2Lro1RJxpd25DiI387nuH442H6zzTyhUUPrA/qBAVN8lF9Hbq
 j9FNYn0axP+jhjtaZY4uwgixL0nFAkbg8n3EaDJqEnMJh6zxap/LUrjOw3guH8bC
 V7UCqE1qn/QK1g==
X-ME-Sender: <xms:1-pLWZO0f8pPBfYsRvIsJ9q_leN1ZwVdKlqYJessVdAgTkPf220Bow>
X-Sasl-enc: sjLqxl7Gs0aV9os2z/4/yTP24jDciKyWpZxb2KaZcVON 1498147543
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4612A7E77A;
 Thu, 22 Jun 2017 12:05:43 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Date: Thu, 22 Jun 2017 18:05:42 +0200
Message-ID: <3793478.bOXkPGkn7S@xps>
In-Reply-To: <20170622155641.25916-3-stephen@networkplumber.org>
References: <20170622155641.25916-1-stephen@networkplumber.org>
 <20170622155641.25916-3-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal: PCI domain should be 32 bits
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jun 2017 16:05:44 -0000

22/06/2017 17:56, Stephen Hemminger:
> In some environments, the PCI domain can be larger than 16 bits.
> For example, a PCI device passed through in Azure gets a synthetic domain
> id  which is internally generated based on GUID. The PCI standard does
> not restrict domain to be 16 bits.
> 
> This change breaks ABI for API's that expose PCI address structure.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
[...]
> --- a/lib/librte_eal/common/include/rte_pci.h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -63,7 +63,7 @@ const char *pci_get_sysfs_path(void);
>  
>  /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */
>  #define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8
> -#define PCI_PRI_STR_SIZE sizeof("XXXX:XX:XX.X")
> +#define PCI_PRI_STR_SIZE sizeof("XXXXXXXX:XX:XX.X")

I think you need to change PCI_PRI_FMT accordingly.