From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC047A0353; Thu, 6 Aug 2020 15:20:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FAED1BFF7; Thu, 6 Aug 2020 15:20:04 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F15DA2BB5; Thu, 6 Aug 2020 15:20:02 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 898925C00A9; Thu, 6 Aug 2020 09:20:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 06 Aug 2020 09:20:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 81BR1NYMAso4daKwx+CQnLwe2dWG6ZNKJhJBlph6yb8=; b=hgCTExBNxdAYI93x 8iXm0powMShcHC2q5pacxJIuAFE5c518Lt1R8u5nK+2VgnUSiLYeHN9Lyg5HZjXG 2dkNePKXfO+l9tr2kwEJfuQ9RgBJ3S2yDuqB3fgvj9wuhjLizu8gDGGQczTHixli QHIojjLskPXISBNKFa/nxBky1+lN2EI5v1F6FdNk2jNla69dl0l8J41FHo8X7Mry Ub3RzwBUnC3dAkXcw2jwd+SKbaHW+4aCey+3MPYq0jBeGFlCUnRKgOs6vx+vJoTh betLzsi//CpqsjaTIo3DT9/Nb+ePvFl9bwoUFFQ4gnRki5gYyezu8sNzNh+9OLci l6WCtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=81BR1NYMAso4daKwx+CQnLwe2dWG6ZNKJhJBlph6y b8=; b=C+VTh9PGkq13FvKCcqWtW19Pm9LBFka5cH1qNlJKmq9u+JlJz6lV7myge I2cTgXpQeBUihWSXkfdCvsXxPiw87j2XIEQ2CSdBEF20i5joKMjsN5FgJLDZT2eC Nm+Pwbd9piF/SbKeTTt6sE8EQghWLA7zbd3r9mwJc9e5HRYrHQVVbkEEs/RBLRVK U5nMEtFB5SnvU7fzVxZny+WXlftvsYe7iDlnyJUgwm+b6R8f4rHZmgWmx6nYLFO8 OP3z3g2Z8gD5H7udn5eamcoMgTH8tdC3qqRp1QbsKekm+xs9xOoZy6+DnqC5zo9Z gWNZN/kOyYlE35O/L4VgHO4GvBfEg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrkedtgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 82B4B306005F; Thu, 6 Aug 2020 09:20:00 -0400 (EDT) From: Thomas Monjalon To: wangyunjian Cc: "dev@dpdk.org" , "stable@dpdk.org" , "keith.wiles@intel.com" , "ophirmu@mellanox.com" , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Date: Thu, 06 Aug 2020 15:19:58 +0200 Message-ID: <3793874.FWKru8qnbX@thomas> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60D11127C@DGGEMM533-MBX.china.huawei.com> References: <40a0e68ed41b05fba8cbe5f34e369a59a1c0c09c.1596022448.git.wangyunjian@huawei.com> <4268011.XMymgrSB0u@thomas> <34EFBCA9F01B0748BEB6B629CE643AE60D11127C@DGGEMM533-MBX.china.huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: free mempool when closing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/08/2020 14:47, wangyunjian: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 29/07/2020 13:35, wangyunjian: > > > From: Yunjian Wang > > > > > > When setup tx queues, we will create a mempool for the 'gso_ctx'. > > > The mempool is not freed when closing tap device. If free the tap > > > device and create it with different name, it will create a new > > > mempool. This maybe cause an OOM. > > > > While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE > > behaviour in tap. Thanks > > > > I read the codes about tap device. Currently, the tap pmd doesn't > use RTE_ETH_DEV_CLOSE_REMOVE flag. I know. That's why I suggest to switch to RTE_ETH_DEV_CLOSE_REMOVE. Please see this deprecation notice: http://git.dpdk.org/dpdk/commit/?id=7efbaa7b4e423