From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 519DC5B16 for ; Mon, 17 Sep 2018 13:38:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 39B692E2; Mon, 17 Sep 2018 07:38:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 17 Sep 2018 07:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=BeEDwdXkf6p2dRNYw+n7Aa3/i1 C/ZEsytr08xt2NEkc=; b=ge3mmKb3m7W9202kvAq9AmlIpnGUas67VEv863JuLr N40iso8pO3LuCKRKboO0K4bdVPDpxGhJAVIJcl/Zx4IFh/LBLR7zfFMM3zmbLC4J 2uHOJJ8TVgHouCWAvOVQ2klLTeDJVSc40d2nnKUr+A1LePn/IoXJ5UGRphCUmIQE 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=BeEDwd Xkf6p2dRNYw+n7Aa3/i1C/ZEsytr08xt2NEkc=; b=e3UHA2BhQ3u941vfOAyLB4 S2hJtNT9NvrOBgjd5Ts1Ts5wFFFWhcvkNtbmsvWB1fIFsIlpPOz7VU0YyMd9QWz4 PJxFMvKxQXzFBFSWtWzL86cEuGZ8DZA6RdZiV+as8ytHsB7BVJ9UMY0JDT8Te+fc ndxWE1UfJ82/7+3ae21W4jmpSM48XVEFSkkB5Ns/SOvwe5oKM+dy9H6TxHL5bUxB X1bqFvK/Y5jjiWog/BVowqH7lcR0hHpbkk+Lp5LKzukZf/5EFH8Zte37H/00V8GN SpckizPCOUDHXr3MY9vyuQnihkX8F/X966brIXbfbyzug2YDET23k7N0dGn1iOYQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D69FE4626; Mon, 17 Sep 2018 07:38:22 -0400 (EDT) From: Thomas Monjalon To: Luca Boccassi Cc: dev@dpdk.org, Bruce Richardson , tredaelli@redhat.com Date: Mon, 17 Sep 2018 13:38:21 +0200 Message-ID: <3796332.J9Jhy0mxQi@xps> In-Reply-To: <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com> References: <20180912172134.21099-1-bluca@debian.org> <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 11:38:25 -0000 13/09/2018 11:11, Bruce Richardson: > On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote: > > Add -r option to ln, otherwise the link will be absolute and contain > > the build path and break packaging among other things: > > > > lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1 > > -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/ > > drivers/librte_mempool_dpaa.so.1.1 > > > > With -r: > > > > lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1 > > -> dpdk/drivers/librte_pmd_zlib.so.1.1 > > > > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory") > > Cc: stable@dpdk.org > > > > Signed-off-by: Luca Boccassi > > --- > > buildtools/symlink-drivers-solibs.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh > > index 803dfec491..9826c6ae37 100644 > > --- a/buildtools/symlink-drivers-solibs.sh > > +++ b/buildtools/symlink-drivers-solibs.sh > > @@ -9,4 +9,4 @@ > > # parameters to script are paths relative to install prefix: > > # 1. directory containing driver files e.g. lib64/dpdk/drivers > > # 2. directory for installed regular libs e.g. lib64 > > -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 > > +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 > > Acked-by: Bruce Richardson Applied, thanks