From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A904DA045E for <public@inbox.dpdk.org>; Thu, 30 May 2019 20:09:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B7981B955; Thu, 30 May 2019 20:09:30 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E9ED91B954 for <dev@dpdk.org>; Thu, 30 May 2019 20:09:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2019 11:09:27 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 30 May 2019 11:09:27 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 30 May 2019 11:09:27 -0700 Received: from fmsmsx105.amr.corp.intel.com ([169.254.4.170]) by FMSMSX152.amr.corp.intel.com ([169.254.6.59]) with mapi id 14.03.0415.000; Thu, 30 May 2019 11:09:27 -0700 From: "Walker, Benjamin" <benjamin.walker@intel.com> To: Stephen Hemminger <stephen@networkplumber.org> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH 02/12] eal/pci: Inline several functions into rte_pci_get_iommu_class Thread-Index: AQHVFw/o1u7DQ4w4CkGO0en51eaR/KaEaWMA//+NtvA= Date: Thu, 30 May 2019 18:09:26 +0000 Message-ID: <37B08312E007AE46A00101F43DA919DDF3E8D302@FMSMSX105.amr.corp.intel.com> References: <20190530174819.1160221-1-benjamin.walker@intel.com> <20190530174819.1160221-3-benjamin.walker@intel.com> <20190530105702.4fce8a6d@hermes.lan> In-Reply-To: <20190530105702.4fce8a6d@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWQxYWUwZDItMWFhYi00MzJiLTlhNTMtMjY2NWMwYTE1ZTg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibU9zSlBGTkV1NVlGQldvdWg1bkt4NmZhbzBoUnFoSVRHSUorb3ArcVRaelwvc0ZQN3I0aXhaMmZSWnFndHlSd0EifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 02/12] eal/pci: Inline several functions into rte_pci_get_iommu_class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, May 30, 2019 10:57 AM > To: Walker, Benjamin <benjamin.walker@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 02/12] eal/pci: Inline several functions i= nto > rte_pci_get_iommu_class >=20 > On Thu, 30 May 2019 10:48:09 -0700 > Ben Walker <benjamin.walker@intel.com> wrote: >=20 > > This is in preparation for future simplifications. The functions are > > simply inlined for now. > > > > Signed-off-by: Ben Walker <benjamin.walker@intel.com> > > Change-Id: I129992c9b44f4575a28cc05b78297e15b6be4249 >=20 > Please don't inline any functions that are not in the fast path. > The compiler will do it anyway. That's not what I mean by inline. I didn't mark the functions inline - I co= pied their contents into the single place they are called. This patch is a set u= p patch for a later one that refactors the way this function works, and doing this = makes the diff easier to read.