From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>,
"Chenbo Xia" <chenbo.xia@intel.com>
Cc: dev@dpdk.org, Pei Zhang <pezhang@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: Clean iotlb cache on vring stop
Date: Tue, 28 Sep 2021 17:29:35 +0200 [thread overview]
Message-ID: <37b37f7a-bdf2-d04a-f58f-90e901107531@redhat.com> (raw)
In-Reply-To: <20210827161231.579968-1-eperezma@redhat.com>
On 8/27/21 18:12, Eugenio Pérez wrote:
> Old IOVA cache entries are left when there is a change on virtio driver
> in VM. In case that all these old entries have iova addresses lesser
> than new iova entries, vhost code will need to iterate all the cache to
> find the new ones. In case of just a new iova entry needed for the new
> translations, this condition will last forever.
>
> This has been observed in virtio-net to testpmd's vfio-pci driver
> transition, reducing the performance from more than 10Mpps to less than
> 0.07Mpps if the hugepage address was higher than the networking
> buffers. Since all new buffers are contained in this new gigantic page,
> vhost needs to scan IOTLB_CACHE_SIZE - 1 for each translation at worst.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> Reported-by: Pei Zhang <pezhang@redhat.com>
> ---
> lib/vhost/vhost_user.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied to dpdk-next-virtio/main with changes suggested by Chenbo.
Thanks,
Maxime
prev parent reply other threads:[~2021-09-28 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 16:12 Eugenio Pérez
2021-08-30 11:57 ` Xia, Chenbo
2021-08-30 18:10 ` Eugenio Perez Martin
2021-08-31 2:02 ` Xia, Chenbo
2021-08-31 7:10 ` Eugenio Perez Martin
2021-09-23 8:34 ` Maxime Coquelin
2021-09-23 8:48 ` Xia, Chenbo
2021-09-23 8:50 ` Maxime Coquelin
2021-09-23 8:54 ` Xia, Chenbo
2021-09-28 15:29 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37b37f7a-bdf2-d04a-f58f-90e901107531@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=pezhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).