From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31DB0A04FF; Thu, 5 May 2022 18:36:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D03184014F; Thu, 5 May 2022 18:36:16 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by mails.dpdk.org (Postfix) with ESMTP id 7A18F40042 for ; Thu, 5 May 2022 18:36:15 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PtTssrdpXa8XriUGeJDOoioasSammNeylsQy/XuRQwDrBSrh+dJNKoZVZjlAhgB0O82UtaRp8YgX0fBYfRxYwnBeDY4s234fUzemog+6Z0miHhdY/YE8b0Gr8Lobfb9q/5Gd8jBDX3cU/xfh9z4jYOO8uGlPiticwJS9iuqt1S1gEIo/10N/sN6OrTsXtf/r/DnN8LIQVxB64WHIrMLgVxeS4vxJ8/GhYCom8caPHZX5Ttj/76O8Ano7JNaJ48P7q2zU6ZwR9amtu5oluEMmv5QtnoOSElQAIyUGzRLb5QloGrtQxzZyzXU4gz8mufK+F+qpgWbnkFg8O5u4kp0AEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+CpppLeU1M62eghFzUBKpfaAmP6Z5Jn+TA5CHbrfiY=; b=VIvJnQiWdh5KpdcyQhxly+WT5+uXsvQaGtthC62BK4w1eRow8wbLR9b4+8/NZJSnlFHAv4Uf1TbhtZWXLfDzLK3+/I65U0sOO0Fyqi0haDTHy1Dq5TmIs1h/zcMqi8orEOsRShGo4m0TCStdBeaXwJMZnry6wqFS+HyiX5VbJflCYSPtz9J3AM3/yQboCKrTYu2hQ2d77Cgez2KyMKuMHLiigAsCsII0n6Ah3/9dzvRFhQtKvWjwY85yHYNK4L2lYocTuHjk76iStsDJt9bCRNoWExHp9b6ANahD/5DG6f2BwO9jGlB50mMdRNP/Nvc5BtmOvTq5RcuiOwRfHpI8dw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 20.83.241.18) smtp.rcpttodomain=6wind.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=xilinx.com] dmarc=[1,1,header.from=xilinx.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+CpppLeU1M62eghFzUBKpfaAmP6Z5Jn+TA5CHbrfiY=; b=ju6NZm1XdOdMb+QQCBt4u3s7yRCr/sgB89JdWpz3Hrk1ULAMBVpVMpuvcKcsODYA3fOgDiuaW+vaIBYT4VF7ThDmnGpLR7LGKUjkfpfFlr5FxneXT291qX+A2pJCAQnJ1M/1UzdCqQkeSiKP9m5iEq6gdxdNe0qOgdSh6S5f6fE= Received: from BN9PR03CA0559.namprd03.prod.outlook.com (2603:10b6:408:138::24) by MWHPR0201MB3466.namprd02.prod.outlook.com (2603:10b6:301:7b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 16:36:12 +0000 Received: from BN1NAM02FT031.eop-nam02.prod.protection.outlook.com (2603:10b6:408:138:cafe::56) by BN9PR03CA0559.outlook.office365.com (2603:10b6:408:138::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 16:36:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 20.83.241.18) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 20.83.241.18 as permitted sender) receiver=protection.outlook.com; client-ip=20.83.241.18; helo=mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net; Received: from mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net (20.83.241.18) by BN1NAM02FT031.mail.protection.outlook.com (10.13.2.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 16:36:12 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net (Postfix) with ESMTPS id 8368141FCB; Thu, 5 May 2022 16:36:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFzgVkqmGIikNdXJ6l6bWGFt3R4XPjxzfCfk2rALLLp5zGlFbRj9kueugPz7sVNp0e/mM6pK7EoSEvtYRKHm87D/YOWfbdSVfOdBR3rMp1GpqfjAR7RerAo0mklOzeOZU1NNcbaMCIJeD3knbkoBCEqI195rlsCaU4/zgztAcu3qsb0v/Zwt77aabu6t/+QM54YHTy82w+xChX8l5LOklWDTk8Lk9kPiQuToO+UcGOLg98zIPlkNKSHHVJwDzYGWGbMDxi5JgjRqJzTwD/gLI3kn/ypuaukruq2zXvRJIvnlZuUNq6F2k39YQgnhsSq1Hl2u1U5oJN2ETLGwXJRIFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+CpppLeU1M62eghFzUBKpfaAmP6Z5Jn+TA5CHbrfiY=; b=fYLgSPzCqhxJtxecRzAwJ5JG1BQ2Bz8oLJmLww41I+Pz+Jf6sMYpKTHOhtdPTg+GGwR2P+ryhn+nk3zg3x0kUe8Era0jjR1FsVYncScEiXrab34o6p849WMPKPxrc8LQcsoWjiZ7fiq/Bsro8RT2odkzAaDX6/tx9PiYwmBuLwf4m8cKbkBPOv31xR2pzX/TF3vPvovxP3N16GxpXr6kzVvXvZOzMHOzmMPQfqPNXKOeCN55jnzrYNYb8S/26FyzCMppyU7b70WZ6KCK7yUert5lwRXRC6TFEEfQRxzGVDBmiPqrWoDKyeA4JahjAavn02wF1KgDEW/kzI00rtj+6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=chelsio.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none Received: from DM6PR11CA0044.namprd11.prod.outlook.com (2603:10b6:5:14c::21) by DM6PR02MB6745.namprd02.prod.outlook.com (2603:10b6:5:210::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 16:36:09 +0000 Received: from DM3NAM02FT037.eop-nam02.prod.protection.outlook.com (2603:10b6:5:14c:cafe::58) by DM6PR11CA0044.outlook.office365.com (2603:10b6:5:14c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 16:36:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT037.mail.protection.outlook.com (10.13.4.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 16:36:09 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 5 May 2022 17:36:07 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 5 May 2022 17:36:07 +0100 Envelope-to: rahul.lakkireddy@chelsio.com, thomas@monjalon.net, arybchenko@solarflare.com, david.marchand@redhat.com, jerinj@marvell.com, qi.z.zhang@intel.com, hemant.agrawal@nxp.com, humin29@huawei.com, viacheslavo@nvidia.com, olivier.matz@6wind.com, dev@dpdk.org Received: from [10.71.119.95] (port=28789) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nmeSV-0000RE-51; Thu, 05 May 2022 17:36:07 +0100 Message-ID: <37be1c92-f15f-eac7-40c6-5614fe160d23@xilinx.com> Date: Thu, 5 May 2022 17:36:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from filesystem Content-Language: en-US From: Ferruh Yigit To: Rahul Lakkireddy , Thomas Monjalon , Andrew Rybchenko , "David Marchand" , Jerin Jacob Kollanukkaran , Qi Z Zhang , Hemant Agrawal , "Min Hu (Connor)" References: <20092a6b-c1f5-4d12-3391-687d648fa0e7@xilinx.com> CC: Viacheslav Ovsiienko , , In-Reply-To: <20092a6b-c1f5-4d12-3391-687d648fa0e7@xilinx.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 6423a217-0400-4d85-5a70-08da2eb55ddd X-MS-TrafficTypeDiagnostic: DM6PR02MB6745:EE_|BN1NAM02FT031:EE_|MWHPR0201MB3466:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SqPAFCVVhm0suApeDB+voXVJbUsUV+miRaQI0S8Glqze10RgA6YYVJk35fsUcueB+D9dXgbZ7HT3gaYVBB34a0ifnD8GMYREFPwQLR5uxvvMJ/IAqO4eVv8E4XNXThiW0ffjzEtWrMblV1vnimAB02BxFEGH7JuI/hH5ZYOvswEjTBgT3UFLeCojB2TmFiLjUwS1qlKctKw6AwjjFryZtO8/EMOffFMqEQyVkmkK87B+nJYvvWDReKeiWvHRXty0vIbw635PiVtc1TP+DZMCDpB+eRMyAkSOotcTsv2GY9veOgj+w5XLgu06cwJEYBb6D0b4I32Iso+WRxcoMJCPQJNidMMOQsbQQudUvQQcMMhhBTQ+7cvKcl1ePgOLtgWulJaCVX9njMAW9e4ajgBSl2YW2DLiFhc5YIwocbwFq2+EeFqe9p1MxrfHB+zA5N6pnW628a+u/8FpXKVFE9TjIk8DC9CTduKbuDb5aYlSP4dJRJLKQ3nuk7aEPLmhEAGt0k5NsBY7ZKPijSPqGgMifBC7XS0sqPihXOLb1TkHQCJHlLMYAJWP2j2+l02vV/8bSoMpubyRlY/DVtgGpJ/cwmOLiQ6v3WBN2FM9rLKRUP5T2Jugu93m39qo/tk7lmw7tr0FxU4caYb7Wdx9B9b/fS7ftvqQyslUC5keis2BaxIJdVPpDEsoffi2K0EA0RN7+4fyHbyGfi9AwIX7h7iYFyMPXS9//5Bi6vzRyWcOT9I= X-Forefront-Antispam-Report-Untrusted: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(82310400005)(31696002)(356005)(2616005)(426003)(70586007)(8676002)(70206006)(4326008)(7636003)(40460700003)(36756003)(336012)(47076005)(8936002)(186003)(9786002)(316002)(2906002)(5660300002)(53546011)(508600001)(7416002)(44832011)(31686004)(26005)(54906003)(110136005)(36860700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6745 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1NAM02FT031.eop-nam02.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3bcb3c7-615c-467a-fab7-08da2eb55bff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AZybkuq6OwT4jEsACn/DMziSepU2I3Od7uPIzRBOX4Ny2U25F7nV2cCNOQz7MP1Ad95VGHvZ9zr83quD++lHHVT7fMqNY7mqF+vQNJIqLgreaOIHuJ6jkqNT6ul53oLeYvlUNRadleKFRpUzJ4p30aFQY/YDQkmZDUoofHgVROkzEgYS6EismAQb4YO4Lli4PO8qmgCLna9r3YjaTWk7rEHw60HKBBBl2vQ70L8BooTJtGVRNXUBLkN7sxFPMhHkA+ilZ2vu1D/cXzjUTBxQhxH4adVprkm5a2sIi4DA/iQPcNHR2NJnVQZSei3C2zCAYe2ps2R5+/OmhdLpA3a9bQxdjFedcNya2R4iZaGkIsDmDlQbu46EhvwxnJoT8pJ3/vttutPO6/joZQpw4/fyMha7uTl1SNrS2yE4srzn2zZ08xzWJX494ZJOce1kAzs4ks7XjgB3xBj2Ql3i9mo/CfarpRqiIvBDwK+fhtBNJf0XA4JcXrrKDJPt5/9hCdSgw2yij6ibcq/snoRsJvo/+ODwSSgejkpBTZu0Orn8LGcCWVMPjIn8k+gHCnvgVMo3ovw3gXNCVP1PQSLZIRnc+zH4BHqoWe0ofjoLyenwLyv1OnOyeqM5Wl0yaCEnxRRfCaOzkhIe2YNlIGe0kuDO0Vlx+GSKDqbwVScoSsj2V/SpaOK7U2BXW4H9F4XOo95HwzktRJNhtxV3z6733E0ztzmkblx/WrP76zPp2cf0/5f99Yk0VynYAEkVIhG1IRfN1oFLC72AbSWKmTttZ4nt4g== X-Forefront-Antispam-Report: CIP:20.83.241.18; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(508600001)(9786002)(110136005)(2616005)(36756003)(31686004)(26005)(186003)(36860700001)(426003)(47076005)(336012)(4326008)(40460700003)(81166007)(82310400005)(316002)(5660300002)(70206006)(2906002)(7416002)(8676002)(54906003)(53546011)(31696002)(44832011)(50156003)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 16:36:12.3217 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6423a217-0400-4d85-5a70-08da2eb55ddd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[20.83.241.18]; Helo=[mailrelay000001.14r1f435wfvunndds3vy4cdalc.xx.internal.cloudapp.net] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN1NAM02FT031.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0201MB3466 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/5/2022 5:29 PM, Ferruh Yigit wrote: > On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: >> Add support to read firmware configuration file from >> /lib/firmware/cxgb4/ path in the filesystem. >> > > Hi Rahul, > > Can you please document the FW config file in the driver documentation? > Please add: > - Path of the config file > - Content of the config file. As far as I can see from the code the > config file directly sent to the FW, does this mean config file is binary? > - What happens when config file is not found > > Also are these values overlap with the devargs that PMD has? If so what > happens in that case, which one is used, devargs one or config file one? > > Previously there was 'cxgbtool' tool to send the config file, is this > method replacing it? Why not keep using 'cxgbtool'? > cc'ed more folks. This patch introduces a userspace config file for runtime FW config. What do you think about this approach? Should we formalize this method more, like introducing an ethdev level config option to hold the config file, which can be used for driver and/or FW. And perhaps with a defined syntax (yaml?). Can this be an alternative to PMD devargs? Cheers, ferruh