From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0459443AB0; Thu, 8 Feb 2024 00:24:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4A7840278; Thu, 8 Feb 2024 00:24:45 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mails.dpdk.org (Postfix) with ESMTP id 6ED2A40144 for ; Thu, 8 Feb 2024 00:24:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SY90pCZDbS4kL9+WE4nhxpwC5zA7+R/GQdiRG4tqvgBUyTFt+7F1qSAgl90IX6eom/lyeVY2V065/KZOI96pgpLPPgd1G+7xMi3Mhm0o72HlRWNlE+i0O80kBZdAbUHrb4bebLyJCSd6Ot0MLjySlYWHNMYjQmPW/7VXYymf+vug8nkHDvpMLEHED1SkajiJbPCNfiix/u/Pl2Oveafg2h7ZaUezOIh0nmWYvoFyk9Mzo+7rBU6IEAHGbzr9nVrZ/+/eDNPfDphDMsbNyJJOCfW8WkXNiVwss9+kbJ3NnBaZcipQOXLts6fWlogHhrkAFoSBIKJErqmCPTFnp8O3pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gradGthOkrKtrnS1iYLkAFRzZd8fWiWQ3uuAVVz7alM=; b=bUIqkwlMAbBOma9ggaz+NarcY59bK5UOOZiRPwLecUYx5nDNDmiFplGGcQwUUrDx7bBtsTfnRnYwdHGVqdUZK1pkrxjPfKb7xKH5g4bpmLxCAL430Uq5hW1DCBVdmj+V8s9kCzWXh1p/jJ/lz4yd4fKjf2j2Q7yVwkKmloZ+K8+MGxZyrHURjiGelJb8FXcJlqThk8LQ9BOGLIrOIFuDmy2GdMaOzhkDTRkYx1NKCIU4V3VSkuHl0diJisQqPuj93uShAYGhxzD7iJ0ND4WGNMNdLEqFYw8hoASx0y2vPsnsqO7SWpR3g5GcTQ8b7QDtZF29+6QaJiMkPe1Ls5qp3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gradGthOkrKtrnS1iYLkAFRzZd8fWiWQ3uuAVVz7alM=; b=r17rT0YmKvPecli2OCnMrP317HQ85EwJnmSxHk1twuQRpAOFd/8vvMCVfU1002xACJ7Z04WCiOyNCWdn94bBpENH4t+ddVlCdquSiMwrhrdvw+VG61ri7wy+PJGWPkil2BwzW8e6WKC/eEttDR6ya7ZnEVKLny6lThCXA47vgNc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by DS7PR12MB5816.namprd12.prod.outlook.com (2603:10b6:8:78::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Wed, 7 Feb 2024 23:24:42 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::716d:e3ce:141a:f22d%6]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 23:24:42 +0000 Message-ID: <37ebae5b-cfb0-48f9-bafb-855e59b6bdc9@amd.com> Date: Wed, 7 Feb 2024 23:24:21 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s Content-Language: en-US From: Ferruh Yigit To: Maryam Tahhan , stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com Cc: dev@dpdk.org, Ciara Loftus , Shibin Koikkara Reeny , Kevin Traynor , Luca Boccassi References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> <8a667d69-8543-4dd0-bc90-9929b670a261@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <8a667d69-8543-4dd0-bc90-9929b670a261@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0505.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|DS7PR12MB5816:EE_ X-MS-Office365-Filtering-Correlation-Id: a590e8ae-f2dd-4d18-587e-08dc2833ee0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F+mOyio32TC2tCkg7dQQ8XVIGk6aSETJmshdWY0BbJefMAcGiVYyI7IWEyW5/PypXDzV7lPFNLIY71sLQk1RmE6SDDijpdUFD0ekQOOmE+rCfvWNPLzM83HQfKXW6u4AAYNIpeZhlzbFlU2h4srXc7EHNjlBJIrY03Aat5AnHyefF+srs+hY5bgpckNR92MjFQLdg9zIyaB9RlmM1AAqwt8F6GM6lUlFrc3yQgR1BV/miK2ebjhp0cLbda1Tvj15R6k0ZG6ZuHbCY/RoJt2EeteaY4/g9oW5f9j/NNq1C49m28OyVGcX4dfFnM4tOOyxY086VG5j1CsymW3TP45TXAc0gU0zJ1DgwPK4IwOJylvrDyn9wNHmXW3SWiCxNNRyLyksIzFZZtlgRDKatXXdUGj7QRFHneQTnTfEyZToG7XnzczA9l4VXSV0KlzfyJiM1D9Ywvbz5CS9J103wms4TUfVvgfi+4r11NCCH3dmDQl6R34zGVg+e/N2WkwIomMtjWEaXlbD4oaI5vgALQcFZf0qnqQNR8zQDl8Lmw6da+xt5Wj2ioYGb6MkUmApH8VC X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(136003)(376002)(396003)(39860400002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(31686004)(36756003)(478600001)(53546011)(86362001)(6512007)(6486002)(31696002)(83380400001)(2616005)(316002)(66556008)(41300700001)(54906003)(26005)(8676002)(8936002)(66476007)(5660300002)(44832011)(6506007)(66946007)(7416002)(2906002)(4326008)(6666004)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MG5yMUs5YXpoK0RmdUs4OWxaaCszN3d0dHpOTHJMTVZlUWxHZllreUpxckd4?= =?utf-8?B?dnY5ZVhwcEV2VmxvZlRBL0RxcWVvY0pJMnVwbkU2bDNCdkZid05PcHdiQUtv?= =?utf-8?B?bHNLLzRwaXl6RDY2YU1mOWNJdFd2SWhWSU5yZTdlQzViMzZOb2xmbHBvdkZG?= =?utf-8?B?bVdjMFJhdHRzeklldTR5UDBZRGRGWGJwSzFpckV2WitGdU9KZ3BQSEIzaFFx?= =?utf-8?B?cnRlalhoV1BZdE11L1RJNGxWaDdWb0YxNFUrUWdrc2F3aU5YelFaMGN2RXRG?= =?utf-8?B?VnRmaGRlb1ppQW1iS0xpek9mOHE2OGpkajRsbTZJakhmcnpNbnFZWDIvUlVn?= =?utf-8?B?enVXMGNheWM2V1pabjF2dU9ycEdPSVpDSjdKaHBHM0FZSEJheFcwQmFhRE9x?= =?utf-8?B?S2p4USsrazJHUERIaC8rSEt5czlpWHNRT0NXeHJzN0NGRUJ5MXJiZ2RDcm5J?= =?utf-8?B?bTkzYTJpY25pZDhSVnBUY1R6MnMxSmhvTHAzZnpIamxHc2lDUUJFUUpSaVQy?= =?utf-8?B?eWpxSVlwVjNSQ2t1MVFjbHlMclJEZ0lFRm9SckwxUE9UOVlYQmhHWUhEYkxE?= =?utf-8?B?aU4wQ3ZuSXpLQ29zNlJOS2phTlNUTkFiYm9qQ0NiWkZkWmtDTjFWbVFUazc1?= =?utf-8?B?UVc3T3o0ZXo0UnFhVkdjVWIxN251MHdJMzdMSmNXelBBNU1Pd1ZPQWtWZHYy?= =?utf-8?B?SitueDdqdVpKNDRRU1hrMVd2dElPek1rTUVza0toSS9NbmJ1SUxrZTJrVkJP?= =?utf-8?B?L0xpUW9VbXAvUVY0bTN0VytPQlM1Q3F6ejJmNHRQT2dKaklHTGh1WXZiWHhZ?= =?utf-8?B?N0Z6aGx4TURreEg3aURNOVVkcUtvRU9LVnhCQUxkOUxSZWxSYk54SXpXWGhE?= =?utf-8?B?YzZCS3lpWjdMbFkvZHd2MFVBUzUvOTdEekI3aXNaVTl4cm92d1FqRjJXalB1?= =?utf-8?B?WTlhVG1oWVZaQXZqMHliNVphcXNNNXNFZmFiZ0RBbEk2dHhJWXg0eXVNUlkv?= =?utf-8?B?Q2k2R09VOG9NdzVuWGtZU2Y1ODg3Wlg2RkExYU1rKzA4N0xPVThJalJvNDJy?= =?utf-8?B?ZnIvYXoxbG5HSExWYmxxM1RZM0ZVWVMzQ0NCUHNXcmlFc3B4NmNVRm5xMzdK?= =?utf-8?B?dWIzK1FHaGx6OUlJS0pKYXNkZWQ2TVFhWEVVZzFvNjNSZkc5c2ZicU94b0hM?= =?utf-8?B?cEdzYlVuQW5lL3JJNjlQQ2dmOXc2SGYzbDdaOXFENFF1WjNveUtGUXJvQm45?= =?utf-8?B?Ly9rVnR4SElTQ2pFWmtLc1pnMEU5NzV0czdDKzRVUlg3TUc5S2tUSGVvS2ZP?= =?utf-8?B?VHlGOGRlbVc0alBCMWl1YjllZnJUOWdIRWErR0h4T1JTQjltakc4d1c4MWQ3?= =?utf-8?B?SGp0dmM2Z1Vaa2VzYWxBdE9vUTFnUzhEUDV1ZWNLaml0RWhzdnFwTDlaQzdO?= =?utf-8?B?ZlE3bWhGTmRPZGxXSzl1ZzI5NXhUbER1OGgwRktEcnpmMlJnZ2JrQ3I3ZjhG?= =?utf-8?B?VG42bnUwZk4vQXBmc3ZxVms0OFNVTFVsTGR2eHVVRGNZR0hCUVdoY1RCNGVy?= =?utf-8?B?UVBGNTJGVDRGVjRHcVltZTNnVTRPMEcwYitKRkhDK1NSWDRwejQ3K3d0ekxw?= =?utf-8?B?b1RSWHBVZWZKVnFpdFN1bmsrV21DNndmeklqNDB3elRydzJ3ZmJwWDhQTWlX?= =?utf-8?B?Y1RMWk1qeHZ4Yk1TV003OUllZy9rTzQ1MWEwTFpDM3BzOTZVc09GYUt1YTZK?= =?utf-8?B?MTg2bWRrWDZzUGk0R3RCYTQ1NnJ1VWN6VFJMRU1MdUljdzlTUmFZTG84VmpB?= =?utf-8?B?UHVUTVlvZG1wWXhZZnZHNFFmbUJ3QkppU1B5ekdvQSs2aHZiSGVSQ1lPd3V5?= =?utf-8?B?ZC8zalRQZElHOC90eTNqSWgweUlHeVZpU01XQzRWUHVmSWxSQWY2RXhTbUFt?= =?utf-8?B?VUt6UWdENFBOdFJnSzd1Tnk0SzBmNmV5T2gyTjVDTExXVkUxN1JtRWRPQjJV?= =?utf-8?B?REExajl0czJaNmpZTitVcEt4c2RPclJuUlJjclZ6RW5aZFJDMHFpM2hDV2dT?= =?utf-8?B?Y0xCUUcvSnlyWnJHdjRQZGl1eWd0VTJDTDdmSEdBOHcwY0NFN3JCYTFyM0Zi?= =?utf-8?Q?b8xrRK8n52SSrK2HegLo3+qiV?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a590e8ae-f2dd-4d18-587e-08dc2833ee0a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 23:24:41.7833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6EwS8qhaqZw6/LnO+8gO8rOrUYaCoXQfeT7cn3xGkT8aojF6QTbE12AhU76PkXBY X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5816 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/11/2024 2:21 PM, Ferruh Yigit wrote: > On 1/11/2024 12:21 PM, Maryam Tahhan wrote: >> On 11/01/2024 11:35, Ferruh Yigit wrote: >>> Devarg is user interface, changing it impacts the user. >>> >>> Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken >>> when user upgrades DPDK to '22.11.4', which is not expected. >>> >>> dev_arg is not API/ABI but as it impacts the user, it is in the gray >>> area to backport to the LTS release. >> Fair enough >>> Current patch doesn't have Fixes tag or stable tag, so it doesn't >>> request to be backported to LTS release. I took this as an improvement, >>> more than a fix. >> >> This was overlooked by me apologies. It's been a while since I've >> contributed to DPDK and I must've missed this detail in the contribution >> guide. >>> As far as I understand existing code (that use 'use_cni' dev_arg) >>> supports only single netdev, this patch adds support for multiple netdevs. >> >> The use_cni implementation will no longer work with the AF_XDP DP as the >> use_cni was originally implemented as it has hard coded what's now an >> incorrect path for the UDS. >> >>> So what do you think keep LTS with 'use_cni' dev_arg, is there a >>> requirement to update LTS release? >>> If so, can it be an option to keep 'use_cni' for backward compatibility >>> but add only add 'uds_path' and remove 'use_cni' in next LTS? >> >> >> Yeah we can go back to the version of the patch that had the 'use_cni' >> flag that was used in combination with the path argument. We can add >> better documentation re the "use_cni" misnomer... What we can then do is >> if no path argument is set by the user assume their intent and and >> generate the path internally in the AF_XDP PMD (which was suggested by >> Shibin at some stage). That way there should be no surprises to the End >> User. >> > > Ack, this keeps backward compatibility, > > BUT if 'use_cni' is already broken in v23.11 (that is what I understand > from your above comment), means there is no user of it in LTS, and we > can be more pragmatic and replace the dev_args, by backporting this > patch, assuming LTS maintainer is also OK with it. > Hi Maryam, How do you want to continue with the patch, I think options we considered: 1. Fix 'use_cni' documentation (which we can backport to LTS) and overload the argument for new purpose. This will enable new feature by keeping backward compatibility. And requires new version of this patch. 2. If the 'use_cni' is completely broken in the 23.11 LTS, which means there is no user or backward compatibility to worry about, we can merge this patch and backport it to LTS. 3. Don't backport this fix to LTS, merge only to current release, which means your new feature won't be available to some users as long as a few years. (1.) is most user friendly, but if 'use_cni' already broken in LTS we can go with option (2.). What do you think? btw, @Ciara, @Maryam, if (2.) is true, how we end up having a feature ('use_cni' dev_args) completely broken in an LTS release? > >> Long term I would like to keep a (renamed) path argument (in case the >> path does ever change from the AF_XDP DP POV) and use it also in >> combination with another (maybe boolean) param for passing pinned bpf >> maps rather than another separate path. >> >> WDYT? Would this work for the LTS release? >> >> >