From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 06B085B12 for ; Tue, 9 Apr 2019 22:14:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DA27A2C5; Tue, 9 Apr 2019 16:14:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 16:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IekMCiBQAGOJgpvSJcO7qUt0pYxCV1pDhk8K/zTEen8=; b=LVYuF84Uu4JF NobdrPpdmv8xxJnNueTzGsehkgefvQFRSyTolyVR8//3/0Tzudwb3+27D90w/qza B4YelzUTgjb8zVFn1c3L2Eteh6ufLFPGRCVc8ug+oZrwqugPLqieQe0CxLRU8v3C Pu3fUV1e+6aqwveaY/L1lBqoWtyz7aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IekMCiBQAGOJgpvSJcO7qUt0pYxCV1pDhk8K/zTEe n8=; b=20UV9C0pUnEAujZIdrkmm5Sw+2trEogxJs8R0FidtJ4W0Es6byIXMPGfn 4f7+lfLEBgVWRdrhHKi4Wz/R4ujkgK0f6iHt3rl5km30y3Bgx+9+pJ27ULAPSOk7 K29hcdCW6VKFkMWETXrMR1ygHAjJSYvJswu+QoTNhjBtivVxQ2xCnvFWaBbbsu+R tJGkUlQOVt2j2A4fFbfMiVTSZrE0Mue0qGpfuWcVtdHr79kzYIRI5HcP+Q6u/667 jkLlSrvniWsm4fPza33Y+LX8iQK2GfHvi235iwPI4X+u7N9DyEC8ZnrkQ8Bz5St5 zRI4ZCTruc86CrXkXOEbfvMb5BSCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE5BCE40FF; Tue, 9 Apr 2019 16:14:09 -0400 (EDT) From: Thomas Monjalon To: vivkong@ca.ibm.com Cc: dev@dpdk.org Date: Tue, 09 Apr 2019 22:14:08 +0200 Message-ID: <3802339.Lkezi3CoX2@xps> In-Reply-To: <20190409190630.31975-11-vivkong@ca.ibm.com> References: <20190409190630.31975-1-vivkong@ca.ibm.com> <20190409190630.31975-11-vivkong@ca.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 20:14:12 -0000 09/04/2019 21:06, Vivian Kong: > Signed-off-by: Vivian Kong > --- > static inline int > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) { > - struct rte_pci_device *pci_dev = bus_device; > + struct rte_pci_device *pci_dev = (struct rte_pci_device *) bus_device; Why do we need such cast? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 24EA7A0096 for ; Tue, 9 Apr 2019 22:14:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF93A5F19; Tue, 9 Apr 2019 22:14:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 06B085B12 for ; Tue, 9 Apr 2019 22:14:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DA27A2C5; Tue, 9 Apr 2019 16:14:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 16:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IekMCiBQAGOJgpvSJcO7qUt0pYxCV1pDhk8K/zTEen8=; b=LVYuF84Uu4JF NobdrPpdmv8xxJnNueTzGsehkgefvQFRSyTolyVR8//3/0Tzudwb3+27D90w/qza B4YelzUTgjb8zVFn1c3L2Eteh6ufLFPGRCVc8ug+oZrwqugPLqieQe0CxLRU8v3C Pu3fUV1e+6aqwveaY/L1lBqoWtyz7aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IekMCiBQAGOJgpvSJcO7qUt0pYxCV1pDhk8K/zTEe n8=; b=20UV9C0pUnEAujZIdrkmm5Sw+2trEogxJs8R0FidtJ4W0Es6byIXMPGfn 4f7+lfLEBgVWRdrhHKi4Wz/R4ujkgK0f6iHt3rl5km30y3Bgx+9+pJ27ULAPSOk7 K29hcdCW6VKFkMWETXrMR1ygHAjJSYvJswu+QoTNhjBtivVxQ2xCnvFWaBbbsu+R tJGkUlQOVt2j2A4fFbfMiVTSZrE0Mue0qGpfuWcVtdHr79kzYIRI5HcP+Q6u/667 jkLlSrvniWsm4fPza33Y+LX8iQK2GfHvi235iwPI4X+u7N9DyEC8ZnrkQ8Bz5St5 zRI4ZCTruc86CrXkXOEbfvMb5BSCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE5BCE40FF; Tue, 9 Apr 2019 16:14:09 -0400 (EDT) From: Thomas Monjalon To: vivkong@ca.ibm.com Cc: dev@dpdk.org Date: Tue, 09 Apr 2019 22:14:08 +0200 Message-ID: <3802339.Lkezi3CoX2@xps> In-Reply-To: <20190409190630.31975-11-vivkong@ca.ibm.com> References: <20190409190630.31975-1-vivkong@ca.ibm.com> <20190409190630.31975-11-vivkong@ca.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409201408.bYiS8QQd4dLYSUfHmVU_OBfUVVmxnbyz420enmxWbSA@z> 09/04/2019 21:06, Vivian Kong: > Signed-off-by: Vivian Kong > --- > static inline int > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) { > - struct rte_pci_device *pci_dev = bus_device; > + struct rte_pci_device *pci_dev = (struct rte_pci_device *) bus_device; Why do we need such cast?