* [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
@ 2017-10-06 21:38 Omri Mor
2017-11-07 22:31 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Omri Mor @ 2017-10-06 21:38 UTC (permalink / raw)
To: dev; +Cc: Omri Mor
When using Python 3, dpdk-devbind.py fails to detect modules other than
igb_uio.
Signed-off-by: Omri Mor <omrimor2@illinois.edu>
---
usertools/dpdk-devbind.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index da6e40cbe..a539995cd 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -204,8 +204,7 @@ def check_modules():
# special case for vfio_pci (module is named vfio-pci,
# but its .ko is named vfio_pci)
- sysfs_mods = map(lambda a:
- a if a != 'vfio_pci' else 'vfio-pci', sysfs_mods)
+ sysfs_mods = [a if a != 'vfio_pci' else 'vfio-pci' for a in sysfs_mods]
for mod in mods:
if mod["Name"] in sysfs_mods:
--
2.14.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
@ 2017-10-03 0:25 Mor, Omri
2017-10-03 10:41 ` Bruce Richardson
0 siblings, 1 reply; 6+ messages in thread
From: Mor, Omri @ 2017-10-03 0:25 UTC (permalink / raw)
To: dev
When using Python 3, dpdk-devbind.py fails to detect modules other than
igb_uio.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
2017-10-03 0:25 Mor, Omri
@ 2017-10-03 10:41 ` Bruce Richardson
2017-10-03 14:32 ` Mor, Omri
2017-10-03 14:35 ` Mor, Omri
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-10-03 10:41 UTC (permalink / raw)
To: Mor, Omri; +Cc: dev
On Tue, Oct 03, 2017 at 12:25:27AM +0000, Mor, Omri wrote:
> When using Python 3, dpdk-devbind.py fails to detect modules other than
> igb_uio.
Was there a patch included as an attachment? If so, it's been stripped
out. Please include patch contents directly in the email, as described
at http://dpdk.org/dev/, and also in the contributors guide doc.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
2017-10-03 10:41 ` Bruce Richardson
@ 2017-10-03 14:32 ` Mor, Omri
2017-10-03 14:35 ` Mor, Omri
1 sibling, 0 replies; 6+ messages in thread
From: Mor, Omri @ 2017-10-03 14:32 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
>From aa9bbfd7816dbea4abe4fdc0bec8b8c5f088148c Mon Sep 17 00:00:00 2001
From: Omri Mor <omrimor2@illinois.edu>
Date: Mon, 2 Oct 2017 18:54:43 -0500
Subject: [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
When using Python 3, dpdk-devbind.py fails to detect modules other than
igb_uio.
Signed-off-by: Omri Mor <omrimor2@illinois.edu>
---
usertools/dpdk-devbind.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index da6e40cbe..a539995cd 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -204,8 +204,7 @@ def check_modules():
# special case for vfio_pci (module is named vfio-pci,
# but its .ko is named vfio_pci)
- sysfs_mods = map(lambda a:
- a if a != 'vfio_pci' else 'vfio-pci', sysfs_mods)
+ sysfs_mods = [a if a != 'vfio_pci' else 'vfio-pci' for a in sysfs_mods]
for mod in mods:
if mod["Name"] in sysfs_mods:
--
2.14.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support
2017-10-03 10:41 ` Bruce Richardson
2017-10-03 14:32 ` Mor, Omri
@ 2017-10-03 14:35 ` Mor, Omri
1 sibling, 0 replies; 6+ messages in thread
From: Mor, Omri @ 2017-10-03 14:35 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
Sorry about that!
I wasn’t able to send it using `git send-email’ using my university’s SMTP server for some reason.
I ended up resorting to sending the patch as an attachment, as you suspected.
I’ve sent it inline, which I hope works?
Omri
> On Oct 3, 2017, at 05:41, Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> On Tue, Oct 03, 2017 at 12:25:27AM +0000, Mor, Omri wrote:
>> When using Python 3, dpdk-devbind.py fails to detect modules other than
>> igb_uio.
> Was there a patch included as an attachment? If so, it's been stripped
> out. Please include patch contents directly in the email, as described
> at http://dpdk.org/dev/, and also in the contributors guide doc.
>
> Thanks,
> /Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-07 22:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-06 21:38 [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support Omri Mor
2017-11-07 22:31 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-10-03 0:25 Mor, Omri
2017-10-03 10:41 ` Bruce Richardson
2017-10-03 14:32 ` Mor, Omri
2017-10-03 14:35 ` Mor, Omri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).