From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, xuemingl@mellanox.com, harish.patil@cavium.com
Subject: Re: [dpdk-dev] [PATCH 2/2] mbuf: improve API doc for tunnel Tx offloads
Date: Mon, 23 Apr 2018 10:53:17 +0200 [thread overview]
Message-ID: <38112584.aOSrxqkTeH@xps> (raw)
In-Reply-To: <20180423081449.yxyc2cbuhfavfeor@platinum>
23/04/2018 10:14, Olivier Matz:
> On Fri, Apr 20, 2018 at 02:13:24AM +0200, Thomas Monjalon wrote:
> > + * These flags can be used with PKT_TX_TCP_SEG for TSO, or PKT_TX_xxx_CKSUM.
> > + * The mbuf fields for inner and outer header lengths may be required:
>
> may be -> are
>
> > + * outer_l2_len, outer_l3_len, l2_len, l3_len, l4_len.
>
> and tso_segsz for TSO.
>From a HW point of view, some header lengths may be omitted if they are
guessed by the HW.
But you are right, from an API point of view, we should require them,
no matter what is the underlying hardware.
So the sentence becomes:
* The mbuf fields for inner and outer header lengths are required:
* outer_l2_len, outer_l3_len, l2_len, l3_len, l4_len and tso_segsz for TSO.
next prev parent reply other threads:[~2018-04-23 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 0:13 [dpdk-dev] [PATCH 0/2] mbuf: improve Tx offload API doc Thomas Monjalon
2018-04-20 0:13 ` [dpdk-dev] [PATCH 1/2] mbuf: fix Tx checksum " Thomas Monjalon
2018-04-23 8:14 ` Olivier Matz
2018-04-20 0:13 ` [dpdk-dev] [PATCH 2/2] mbuf: improve API doc for tunnel Tx offloads Thomas Monjalon
2018-04-23 8:14 ` Olivier Matz
2018-04-23 8:53 ` Thomas Monjalon [this message]
2018-04-23 9:03 ` Olivier Matz
2018-04-23 10:48 ` [dpdk-dev] [PATCH v2 0/2] mbuf: improve Tx offload API doc Thomas Monjalon
2018-04-23 10:48 ` [dpdk-dev] [PATCH v2 1/2] mbuf: fix Tx checksum " Thomas Monjalon
2018-04-23 10:48 ` [dpdk-dev] [PATCH v2 2/2] mbuf: improve API doc for tunnel Tx offloads Thomas Monjalon
2018-04-23 11:06 ` Olivier Matz
2018-04-23 14:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38112584.aOSrxqkTeH@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=olivier.matz@6wind.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).