From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BB4F2F04
 for <dev@dpdk.org>; Mon, 23 Apr 2018 10:53:19 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2F88421A24;
 Mon, 23 Apr 2018 04:53:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 23 Apr 2018 04:53:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=6SjTXAOOy5EAebE6X2C4gR4UPe
 VM86pjvzhIwm6poos=; b=SsRTWQtu/NR8z6AEPPdeNI9BCsUJ6XqnukKkJEIbks
 F7nfGG0QlYJgs3w6EzbNRb/G61F3+110Zpm5gpYUzndsAEWT5eQz7en3RLWn6lJ8
 ShMl33HE1a5H9YmKNyBs2QJnVJKEdGymH76ZdKR2ubLEhsA3Iu66oYKcjrPSIYJc
 A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=6SjTXA
 OOy5EAebE6X2C4gR4UPeVM86pjvzhIwm6poos=; b=KktxCHos/QTqj4aX9WUa89
 1Ud8bPJM5XLPabwTuGNLEBbrF7kNOOl82zhQxgfBXi6op81TUpEnlUx4pdwOhLLU
 0UwpcnYNp3h7xCrxJ9rXaIz7uS3wJ8Rpr/WoBQ82PYW0gWmr1nO2j8k+yFVbSKj+
 TFMrOI4MhlfkcbT2IloZI7QMdvzjFyKNKw51IeciI2cQiHjwSoP9Sn50VnQwPxTc
 LgfCG212C4FW037NseigfnF89NIA0N4NXXtXJq/izB7kxYB40HH3DblD49w7KGsK
 oUytZp636/52EdSerszwRmck2rj7Fke9x24iw799wpGbxis5P78U0oG6ANsyE9Yg
 ==
X-ME-Sender: <xms:_57dWlUuVY5rjr37R7b4kT0ZwbcVr3rHu4IbQuWN-NyZGXVXmi-oPg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 74C68E4120;
 Mon, 23 Apr 2018 04:53:18 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, xuemingl@mellanox.com, harish.patil@cavium.com
Date: Mon, 23 Apr 2018 10:53:17 +0200
Message-ID: <38112584.aOSrxqkTeH@xps>
In-Reply-To: <20180423081449.yxyc2cbuhfavfeor@platinum>
References: <20180420001324.11813-1-thomas@monjalon.net>
 <20180420001324.11813-3-thomas@monjalon.net>
 <20180423081449.yxyc2cbuhfavfeor@platinum>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] mbuf: improve API doc for tunnel Tx
	offloads
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 08:53:19 -0000

23/04/2018 10:14, Olivier Matz:
> On Fri, Apr 20, 2018 at 02:13:24AM +0200, Thomas Monjalon wrote:
> > + * These flags can be used with PKT_TX_TCP_SEG for TSO, or PKT_TX_xxx_CKSUM.
> > + * The mbuf fields for inner and outer header lengths may be required:
> 
> may be -> are
> 
> > + * outer_l2_len, outer_l3_len, l2_len, l3_len, l4_len.
> 
> and tso_segsz for TSO.

>>From a HW point of view, some header lengths may be omitted if they are
guessed by the HW.
But you are right, from an API point of view, we should require them,
no matter what is the underlying hardware.

So the sentence becomes:
 * The mbuf fields for inner and outer header lengths are required:
 * outer_l2_len, outer_l3_len, l2_len, l3_len, l4_len and tso_segsz for TSO.