From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF0D6A0547; Mon, 21 Jun 2021 18:14:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A34741158; Mon, 21 Jun 2021 18:14:50 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id AC0B340040; Mon, 21 Jun 2021 18:14:48 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3EFFF5C01B1; Mon, 21 Jun 2021 12:14:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 21 Jun 2021 12:14:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aaAG6SiH/BPxfWazptug/mpe+D7QOpR51a9KzIYUMRE=; b=TfMQZGeWo5zZmV8X K6q8wE04FZYY8nZgFv5wlBsomYbhUHSPfG/m/aLedK/kqVGx0bohV00WzDp1QRO+ A6kkt94QjX+ShmvMizGe3x9p/s9THtZOn7i/cWeBssoIQrKtlGVKYN2xgJNIldWe KePRmi5CEHaSMLu6kUjlCB5WIyCF9g15hkDdP8EEysczR7BzK2BIngNBS/3IQpxU rx+vLJFQHn9xq6OsFftJukSX9TsBX/8equMQwGMOCjQD18h6FR6NNvBN/pgs8O+w hHwiV2frBQIdnaGsI3fhvX+95rCABPQEPx11Ip/pWgeg29lHDduNrcJCSYuWiQ0o HvkYAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=aaAG6SiH/BPxfWazptug/mpe+D7QOpR51a9KzIYUM RE=; b=Zz3WR7h/ZZP8VEzg4ni25uvbTe0XW1Y5nSTIjkBWobDsnl8W0HekcHPp8 SUdyEm6mCcHr48rKZ+sX4dT65+DgoT/0MWxp0UQULT0ey+YYi8yJFcRVRfvfDBVh 63R1BGDgxxnnjwHDJDvbhI/qe7hhkctigWp000jGgZ7B1LGhKy41HQYaJCEDozU5 CLt1RVcMlhre7EsEnK0OmbrgewFCe80NbopS3lex6PydPy5ZiqlxWN1+HLYCkzRb SMbgbXnHAbtPkVmnFIs/CRoDdI6TRGNqW7KoZUrsVdyoxUnC+RPHwcfjc0SzxhqD ZNWDFDvfK+QZooUli2YzpaYM65MxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeefledguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Jun 2021 12:14:46 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" , Thierry Herbelot Cc: "dev@dpdk.org" , "stable@dpdk.org" Date: Mon, 21 Jun 2021 18:14:42 +0200 Message-ID: <3815134.CEuO83SSsj@thomas> In-Reply-To: <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> References: <20210524085341.15184-1-thierry.herbelot@6wind.com> <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/06/2021 17:54, Thierry Herbelot: > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: > > From: Thierry Herbelot > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote: > >>>>> Check Bucket key for all possible indices. > >>>>> > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") > >>>>> Cc: stable@dpdk.org > >>>>> Cc: Cristian Dumitrescu > >>>>> > >>>>> Signed-off-by: Thierry Herbelot > >>> [...] > >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) > >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) > >>>> > >>>> Acked-by: Cristian Dumitrescu > >>>> > >>>> Thierry, thanks again, you could have actually added my ack from V1 :) > >>> > >>> The root cause looks to be a typo indeed, > >>> but the impact or the scope of the issue > >>> should stated in few words in the title please. > >>> No need to send a v3, please suggest a title and I will apply. > >> > >> table: check a bucket is empty for all bucket keys > >> > >> Thierry > >> > > > > Hi Thierry, > > > > I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you? No need to send a v3. > > Hello Cristian > > Sure ! > > What do you think of this title: > > "table: check a bucket is empty for all bucket keys" This title suggests it was not the intent before. It should say that it fixes this check, or better, name the area of the API which is fixed.