From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7A5592B88 for ; Fri, 24 Feb 2017 12:41:19 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC9D081235; Fri, 24 Feb 2017 11:41:19 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-111.ams2.redhat.com [10.36.117.111]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1OBfIDD004636; Fri, 24 Feb 2017 06:41:18 -0500 To: Zhiyong Yang , dev@dpdk.org References: <1487926101-4637-1-git-send-email-zhiyong.yang@intel.com> <1487926101-4637-6-git-send-email-zhiyong.yang@intel.com> Cc: yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com From: Kevin Traynor Organization: Red Hat Message-ID: <381b3df2-bf91-62d4-ab66-ea215007ef5a@redhat.com> Date: Fri, 24 Feb 2017 11:41:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1487926101-4637-6-git-send-email-zhiyong.yang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 24 Feb 2017 11:41:19 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 5/5] net/vhost: remove limit of vhost RX burst size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 11:41:19 -0000 On 02/24/2017 08:48 AM, Zhiyong Yang wrote: > vhost removes limit of RX burst size(32 pkts) and supports to make > an best effort to receive pkts. > > Cc: yuanhan.liu@linux.intel.com > Cc: maxime.coquelin@redhat.com > > Signed-off-by: Zhiyong Yang > --- > drivers/net/vhost/rte_eth_vhost.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index 1e1fa34..8a97c2a 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -402,9 +402,28 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > goto out; > > /* Dequeue packets from guest TX queue */ > - nb_rx = rte_vhost_dequeue_burst(r->vid, > - r->virtqueue_id, r->mb_pool, bufs, nb_bufs); > + if (likely(nb_bufs <= VHOST_MAX_PKT_BURST)) > + nb_rx = rte_vhost_dequeue_burst(r->vid, r->virtqueue_id, > + r->mb_pool, bufs, nb_bufs); > + else { > + uint16_t nb_receive = nb_bufs; > + > + while (nb_receive) { > + uint16_t nb_pkts; > + uint16_t num = (uint16_t)RTE_MIN(nb_receive, > + VHOST_MAX_PKT_BURST); > > + nb_pkts = rte_vhost_dequeue_burst(r->vid, > + r->virtqueue_id, > + r->mb_pool, > + &bufs[nb_rx], num); > + > + nb_rx += nb_pkts; > + nb_receive -= nb_pkts; > + if (nb_pkts < num) > + break; > + } Similar comment for this as for vhost tx > + } > r->stats.pkts += nb_rx; > > for (i = 0; likely(i < nb_rx); i++) { >