From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 53B071C4AC for ; Wed, 4 Apr 2018 14:49:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D0A9C212AD; Wed, 4 Apr 2018 08:49:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 04 Apr 2018 08:49:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/Dq9Z1ZBDOTxR7DTVoT0NHa/Jy p3NglRjH5QE5tu1DU=; b=JICfciAQ2gLQOBYZyMI49M+cszcUnMrdGbXk+Vf4e3 VPcslGcGAiUPHrLZaYJpsKK+LHXvAtlJQY2DUraJOmUCogHLYn0hLMAmHeGcI/f5 83kXnh83OrnXJclVw1C4Ig/joh6DHxygtljL0xwJ+bzXKv/ku4v+W3lddJCdni5j I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/Dq9Z1 ZBDOTxR7DTVoT0NHa/Jyp3NglRjH5QE5tu1DU=; b=U82pDs7hwZZoouv6VFOqIG eItXRwken8bN+NCTGhaB6VEQpussfNz3MbGvZ+eicHFR25t2EcE+DD5MjEWVJng6 26fzCslj685gQTXxIJ2xlRM27BsAIR6p/DJuhPzEZqtyRL5KNGb7t6ZKq9WZTavv u60c76nLOAgvXKesxRfO16PRDEhdUeqPSsBfL6rKiHycmcyr9nFLmgOGWEQKqwaU y+jSdI9RlsFBAgQoZJiqF/0thQqVhse5uetB4DpHRQvQYYanzmICT0OZ9Rk9wwEX h/uld3wP5atte8EChJbKXSr5e2lFRnFY1BzFZznHYO3ywg+5D3am7jpannbMoDMA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1B78FE4449; Wed, 4 Apr 2018 08:49:29 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, matan@mellanox.com, keith.wiles@intel.com Date: Wed, 04 Apr 2018 14:49:28 +0200 Message-ID: <3820145.m9E1F7985g@xps> In-Reply-To: <20180404101606.5156-2-pbhagavatula@caviumnetworks.com> References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <20180404101606.5156-1-pbhagavatula@caviumnetworks.com> <20180404101606.5156-2-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] test: update common auto test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 12:49:30 -0000 04/04/2018 12:16, Pavan Nikhilesh: > Update common auto test to include test for previous power of 2 for both > 32 and 64bit integers. This patch can be merged with previous one (related lib change). [...] > + for (i = 1, p = 1; i <= MAX_NUM; i++) { > + if (rte_align32prevpow2(i) != p) > + FAIL_ALIGN("rte_align32prevpow2", i, p); > + if (rte_is_power_of_2(i + 1)) > + p = i + 1; > + } > + > + for (j = 1, q = 1; j <= MAX_NUM ; j++) { > + if (rte_align64pow2(j) != q) You could create FAIL_ALIGN64 for consistency. > + printf("rte_align64pow2() test failed: %lu %lu\n", j, %lu does not work on 32-bit machines. Please use PRIu64. See http://dpdk.org/ml/archives/dev/2018-February/090882.html