From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96FED42C40; Tue, 6 Jun 2023 15:38:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BA4340697; Tue, 6 Jun 2023 15:38:46 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2073.outbound.protection.outlook.com [40.107.92.73]) by mails.dpdk.org (Postfix) with ESMTP id 506C440223 for ; Tue, 6 Jun 2023 15:38:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NN+F9QIcewukCCdzPsHcnLB/ZOrddRzn8Lib3fZGBV3BPvuYfd1a6q7mK2PwX22gsdVShMx2WbRN65vgpOYnibqiAXT9IOopttS53L/vm5usUbW+lSD1Ec/h8/znA2RQNrA0WZ3E6B5FGAfrutpHYJXDYAFD4H78cZpafhKq9R4Wy5/eQwRWeJ+3dbm+JwBFql7SEYfjSLgo8BoMaVo+PibMirwRP46LkOYTNcxsGIyWuGo5pBS/mXZ5OtxYAK/CcIw9+K23Uo75ShVz0jUQjA0nXPVXrNIp0Zykfaja6d59/UtVlGi//sQK2mBGJ7Cbi4iK5e1+pMPpCybE8PDzwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fjoVXNjTKadzSoMHj8MGShBJ3mLj7QmUXm4uNIN5lyE=; b=VemXokNXnY+GGEYIJ3bni8l6/H7kG8oJrPC1+G1GNL1oFOZSZaPxXoJGpszkhOlS+A2QzC5nep48kRkQdwAHJCYFSghR4G6zYPkf0HV8nbz9tx/zJleJIwE7Efkluus+fyMaK+Rd5CbTKYiAyZmYfeh+S/5uHVF+ExDqn633U2Uu7sQOsZxkdgEaZgDzu29NwmjZ82bvmyyCFI5OPb1FsVmeKdxcrJi9N2UNHxdJy90z/EGxCCOXzdWwZW5+3mstU8raKjsDatLMY5WYHBOr1OTWw/rLF8gzXIq33h+boBPb556am/GgPPYN+1UWzfb1vAgARUw4tqGiqGwuR2cjxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fjoVXNjTKadzSoMHj8MGShBJ3mLj7QmUXm4uNIN5lyE=; b=rKUT36zFnK657WRJZmFzlZeLR8FaI3tluIBqk2d5g8yxsXjmcm67NpeV/t1RxH1/TV7GF3vkHXI4h0gWNd8U6k1eB/mWyMVU/RuMJqgtXw5+flUXOV4GpRE4wYaIndhqJbAjSCUT5nVd09shwXavJfVTROF9tnYbjr7QDh1C78o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) by BL1PR12MB5112.namprd12.prod.outlook.com (2603:10b6:208:316::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 6 Jun 2023 13:38:41 +0000 Received: from CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79]) by CH3PR12MB8308.namprd12.prod.outlook.com ([fe80::e452:1914:1054:de79%7]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 13:38:41 +0000 Message-ID: <3826f910-7347-bd6a-c71c-278bab759417@amd.com> Date: Tue, 6 Jun 2023 19:08:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus Content-Language: en-US To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230606100258.26532-1-nipun.gupta@amd.com> <20230606100258.26532-2-nipun.gupta@amd.com> <3464713.L4jQFfv3LO@thomas> From: Nipun Gupta In-Reply-To: <3464713.L4jQFfv3LO@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:23::21) To CH3PR12MB8308.namprd12.prod.outlook.com (2603:10b6:610:131::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8308:EE_|BL1PR12MB5112:EE_ X-MS-Office365-Filtering-Correlation-Id: d4ca4975-3fef-4a4b-9e4b-08db66935704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4wAfs+KXZ7wxALxmojWR+5XDHwoapOc81Srqi2Si/cdFph9MgKhDFuGoofC25PLM3EgalaTQGko6R91swclvVqBQxHM26tG2KQyBtN6NBIAc5hkxlWu+FhCJcSx4UCr+bNj3Hs90Rhr7CliT0fPkwU4AOTdJ5bVUYnU/CEawDAe0cO5LgBO+NedGUecIHb8MErIxVqDHbfD0v5Exzzm3KY2dFcvOQWAwwcysLtpOmjPDrDouEuh/2q2+Ys85DpXpEM+ehVVGRJH9uc54ktFzoEjzIa1VJK/V5WeNoo8fKMacdlUs8g42uHh0B+lnlEfqaygIvFV0nyZ+f21rIxG5Tj8vscNWBxb3nB761wHmrmZcGmQCu3bfk8/43j+im5+o6G8A68QloOG2BO1OtKHGKNy7OauULxQoajXzjnVn7uqxC3H2J2E9aFPt3Sjw9tKYdKhMAZXAYsDXgf3cs6KYmpDb9sB9QrEVHWD4JTmQnK0q2k5Pn13dcyTO1fR74CXdp20O7A7ugxnPlSCacVb6CtoUHCHQEiNXH8Qt70zUS8KaJTsKBbIUgEwi0od7EIzY+Fff+yGtlIU4Bv7ViGhcAggXRh+KqLjOkJhfwFBrmjfcg8voazAmcxOB6Jrla3RJ4G3HzpcBgQImi6IVFjj2AA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB8308.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199021)(26005)(66556008)(66946007)(66476007)(4326008)(38100700002)(6916009)(83380400001)(6486002)(478600001)(2616005)(36756003)(2906002)(4744005)(53546011)(6506007)(6512007)(41300700001)(316002)(44832011)(8676002)(8936002)(186003)(5660300002)(86362001)(31696002)(31686004)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0lyeUU2bHBFTXhMRlcxWUVta3duOTA0UUNabDdnZ3dCQ2ErcE1oNXRURlRq?= =?utf-8?B?aDlFb1RtcFY3WlpUNndzQlpVQWgvV2RTZ0gzWDkwbFBSYlJvbWNKM09iTFRT?= =?utf-8?B?RFIzR0s0Yjk3bzZLQ3I0TC9JWTRpOFV2OWpJSElGYWhieDNDQVo3ZGNlbmFm?= =?utf-8?B?UUpkRDYxZTVDOTc5NkhZR1g3YlE0Sy9aM3NtMFJpOEo0U0tiNzUzSWlkTXVa?= =?utf-8?B?NTk5ZUtBOWRFL1dQZCtMazAyZXl3MC93ZnFGdUc0U2FPaDJRMWVSVnljZnkx?= =?utf-8?B?U0U0QjB6U2g0R0FwQmk3WjYrbGwyaDJMUmRYaHpLeUFqMittT0dZUXhjd3Fw?= =?utf-8?B?bC9reDBHbVIvcFdaMDdCTFVSVFE4YjJJNHN2TnM5UjlvTnY2M0k3VEhUN2Vu?= =?utf-8?B?ZEt0MU5OU2M1WWpRc3ZZaFBQVFpUTkpmT1BnRC9haEtkRElqSHdEekJUa1Bq?= =?utf-8?B?b0ZHdmR0a2dtL1pGM2xVbWNtclh2eU1BcjJ3U0pEa0xXNTErTGJiMGpzYkZ1?= =?utf-8?B?K2NFZkZMUmlBU3NiRlhmempWTW9RQjJQdjNiOWRjd0hia0R6SlJtVzgwd0Vz?= =?utf-8?B?RzBCZHMwZTJyKzZIZHVadWd2SS9JOHJHS3BSSUJRVmNWaXZUNXFEWDlkOG9T?= =?utf-8?B?TkxRWEVzRHVXVmVnNkpIdU9BZ0JRUkJYQzdaaGp6K290am84QlBiU2N5b1dy?= =?utf-8?B?ZWxIRUtQSHJrUk8ydHdzSHF1NDhmNHJYVnhBUmhhWFJNZEQxT2VBVVlsSlBu?= =?utf-8?B?T0FTYnRKa1I0MFBlb2tFMEdnWDVBOERuQ1hrUm5JU2g3dSt0Q3NlTlordHI1?= =?utf-8?B?cVpad0FUNXU1TmkvbitKb0tjVTd5a2JZUCtWRWZHaDQyYkZKalBBL005N1dB?= =?utf-8?B?VW41bkJram1za3BjQnBuMTZQZExqSkJJNStmeFhpSXY4MU4zbUlGem9DNkFh?= =?utf-8?B?NG05LzNVYmtDcFNwYlV2RzdoUVZyS2ovZFJQdTluMVoxWjhnS1F5d1hWWndY?= =?utf-8?B?TWNQaHlPVHhqclRYNnlmelRWMTNDZlR6aGpLL0JjTFRBVmZWRkJuL2N3cTV2?= =?utf-8?B?OGFkbUVmd25wMG9idG9rM3BTaFV4UmJveTA3NFpvWDBJRnRHeGVWTUp6OTRx?= =?utf-8?B?YjFpSlUzOU1teDNJMnlNRVlOc3Rva3JZMU02OGRKdi9kdU9ER0swdDlpUDVM?= =?utf-8?B?a2UrTTdXaFp5T0lQd1RZSDNGRDNBUEIvSkdMTkxaemF3SEd1TDRiRlgxNCsw?= =?utf-8?B?dXpUVVdaS3pxUFRHSzVPOWZCRHBublE0Z0dZWW0rM0xEbnArU3dRbVRaMEV0?= =?utf-8?B?d3JtNXQ4TlZQck1qNTNaVmw3ZHMrMTZKOUl5NVJwb2x1aUIyNzhRYVJJcWJM?= =?utf-8?B?Q0Z2NXE5UENSRkVIbnEzRmtJbXRFSXN0NnV3dWUybVVOdnZKVUwyeHFORjlt?= =?utf-8?B?UjNFdkV6aE5ObXMrU09LaGJmNS9QN3pDSTVsdDZmRXRWTFpKL3F5YW9Mbm9J?= =?utf-8?B?eDVzK3QyNUkrWCtPTVhUbHdwRzlSYk9KUDllMGIxSkxZUmhHL1VmdWtOd1ZG?= =?utf-8?B?MmoxU2l3Z05pdi9VOWEwYTVKNnJsYXRMUXNkaUxKVU1QMGcrOHhwZk5XaTQx?= =?utf-8?B?L2xMWnJydU0vaENZQlpENTdHVmg3dmxWSUhRWTg5ampaYjVxM0pZcGphV3d4?= =?utf-8?B?OHFXb3g0cnVGQTY2bWRKWjlDZWNvdmt1azBtTHJMM2U1c0FWNzFpa2VkM2x4?= =?utf-8?B?ZCsrK3lWb2lkMW1MUHdWUzFmWjFKcUQrUEd3eVFoaytydW9RRXRVMTRsKzJY?= =?utf-8?B?bkN6ODZtaEVZcjB1MS9PYmdMcHNKSWFyQW8zR0ZwUkZ2MTBUaFJNOVNMVTAv?= =?utf-8?B?ZE1UYkpQWXM2N3oxcU1DNUxEUWs5b1pCcXl1UmJMTDJzdVNBRDdzUXV5QWsw?= =?utf-8?B?ZEk3eXd4elFQT3JxUUNudVYybFY3WFlZWDVFcHFobExlNlNMYzYxa29mNVdL?= =?utf-8?B?YTc1SEFiNGJiL1NrNTAybkhRdnFoemswcVdQaUFxTmJvMEtuYUpSZ1BCZUw0?= =?utf-8?B?eHZKbnBVQVQ2R2FQRFNCMVBSL0FvaFFMRUhZeUhDZnVLQitQd01HUjM3eXpq?= =?utf-8?Q?Q2uCQzk7tDGfmMspEZh44VzMJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4ca4975-3fef-4a4b-9e4b-08db66935704 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 13:38:41.2302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pFT6kz8p8W/PwmCL+hdU7oxiKv//dCRsvXJem4YmcDq9AB1pTHz93NHtLTNHVnLb X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5112 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 6:30 PM, Thomas Monjalon wrote: > > 06/06/2023 12:02, Nipun Gupta: >> +/* Forward declarations */ >> +struct rte_cdx_device; >> +struct rte_cdx_driver; >> +struct rte_cdx_bus; > > You should be very careful about what you export. > >> + >> +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" > > This define is not needed in the .h file. This is required and used by some of the out of tree CDX drivers which are developed by the customers, so it is needed here. > >> + >> +#define CDX_MAX_RESOURCE 4 > > This size looks required for rte_cdx_device, > but as an exported constant, it should be prefixed with RTE_ Sure, will update. Thanks, Nipun > >> + >> +/** Any CDX device identifier (vendor, device). */ >> +#define RTE_CDX_ANY_ID (0xffff) > > >