From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1527CA0487 for ; Thu, 4 Jul 2019 18:50:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFA3737AF; Thu, 4 Jul 2019 18:50:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1EA862C2B; Thu, 4 Jul 2019 18:50:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A379C20BA1; Thu, 4 Jul 2019 12:49:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 12:49:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KzsjgAp7YfwCZ1BMRL5T7OxjL3DrNjHJdrXGG2LsVmU=; b=jqynX+aBmAyc inp/HdyP/QePlOpT+vR0kemqJJ+7nh5OVluZwwg0EXatIpbEEWLU/VSC72aF8HaJ QmTnPy21IOXdt9b0oKEKBAcdkGakKvvBIfOVQLLwOg/6hj4VKGp+1qfws8j9N2SZ fAn95vDpP4RnVu3OTznRqXmhbnD/x/g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=KzsjgAp7YfwCZ1BMRL5T7OxjL3DrNjHJdrXGG2LsV mU=; b=wxnZfhpHiJ82qaSYvv/34A2qwD/rTc7LJ3bERjB09ZjvUeVkceYUK41NA cy9HQRICDxzmcCBIXOSOreWE1MyitmRbilZPsnLulWHEs5JtYIto2PLy0/KyNF0a LV0ro5Eeo2bYeBUPRt70nrhu+T3NqzWnq1vBa6UlLuPN57nHuBcMwe3IrW4B8RSn aljjzv5AZYhaATUhLl0jglC3TdPBX2JNmULVeItQvJWZWlcTxP1fM0C1Xt0agtYN ST23zSD/LTqrXOW3wXkKcTA9rE2HjUJSdJ0lJ2hA275W0U2li9xsg3bJE3YZinGd lD2tSS7fGUNdQXVpa7rYv4JQPbBLg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 81694380083; Thu, 4 Jul 2019 12:49:58 -0400 (EDT) From: Thomas Monjalon To: "Laatz, Kevin" , Flavia Musatescu , Reshma Pattan Cc: dev@dpdk.org, stable@dpdk.org, ciara.power@intel.com, bruce.richardson@intel.com Date: Thu, 04 Jul 2019 18:49:57 +0200 Message-ID: <3830540.EWTksp7JVu@xps> In-Reply-To: References: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com> <1562145823-18398-1-git-send-email-flavia.musatescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] telemetry: fix build warnings seen when using gcc 9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/07/2019 18:39, Laatz, Kevin: > On 03/07/2019 10:23, Flavia Musatescu wrote: > > Suppress the unaligned packed member address warnings by extending > > the telemetry library build flags with -Wno-address-of-packed-member > > option, through the WERROR_FLAGS makefile variable. > > > > With this change additional warnings are turned on to be treated as err= ors, > > which causes the following build issues to be seen: > > - no previous prototype [-Werror=3Dmissing-prototypes] > > - initialization discards =E2=80=98const=E2=80=99 qualifier from pointe= r target type > > [-Werror=3Ddiscarded-qualifiers] > > - old-style function definition [-Werror=3Dold-style-definition] > > - variable may be used before its value is set (when using icc compiler= ). > > > > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stat= s") > > Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets") > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > > Fixes: fff6df7bf58e ("telemetry: fix using ports of different types") > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: stable@dpdk.org > > > > Signed-off-by: Reshma Pattan > > Signed-off-by: Flavia Musatescu >=20 > LGTM, thanks! >=20 > Acked-by: Kevin Laatz Applied, thanks