From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 84C80A0561;
	Mon, 20 Apr 2020 19:39:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0E6681D588;
	Mon, 20 Apr 2020 19:39:58 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 68AAE1D44E
 for <dev@dpdk.org>; Mon, 20 Apr 2020 19:39:56 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 0E3935C017C;
 Mon, 20 Apr 2020 13:39:56 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Mon, 20 Apr 2020 13:39:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 rpK3jkkoUhoCxk/AZLhQisXpYNpXm9tJMeBzBztHz0w=; b=m3e7TR3697NFbbJm
 X0LByVvP3VVTIC9DGjJadsPHW9ln/lN0BdEQy4PsEg0EbsD664fw8a8HwMvGgbSv
 ccqNIkAvK5k4Zg0ZcuSy2FFTHiDi7b1Mb5TETxPQEHlOjiTvOPivRpXlraeX4BPk
 Dnk3k8GtQUcvjc1uJczyrA6socAXNMqD3905uv/U90jQAsG3urnJz4Gjl40jRHAw
 gHokAN23JS0bJSOO8BpmcFDRyUmNo4wHcJc2qWfruGUuT8NnVC1rILW4XiMLf5rT
 0uRIEAytRV47rZ2wmigjLEyNx8M8b8/xaN5Owb3WoB1OiOXEgEAoOrsaIBQyldui
 eWruAg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=rpK3jkkoUhoCxk/AZLhQisXpYNpXm9tJMeBzBztHz
 0w=; b=L+tgVNc1L1SZTByfiIh7qnQMmeB0ka1kbTJTJ5ffvsvLKTshi1/HeHnud
 tOgHtcKAvlI7kgukIm4/EuoM7ckFH6oyLO5SpzGIGQJ09H4llbqBBaXWFnCP1OPH
 3kGBLK4Vne+L3HMYTJp9soGRO2GHvFiwhFOfsYTCfdUzxEjNJxUVIoJ4sOU/tHo5
 tWCoALfoHb3nl0cv9ogVsSYNohmBD9D4/j4Xl6crai78uANdbeC8EO4KPsE0tydU
 YjEUEFGc5E17DWyduRgroR/Ify1Nyjj5maM5At568ttw1qCvHUiME2/tITqPlPXb
 V5yeV0XIXvkl/DaWlOaowW2WqpNng==
X-ME-Sender: <xms:a96dXpxa9J5G0IQvjWLO7abb-A3B2SVYAMeRvFUVP_RfweNRYLaRTw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeefgdduuddtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
 hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr
 rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:a96dXqCLuG1UQGYk1NXMNOiZm3r8YXWoQ-258OzwoU1BfA5v5p7OLA>
 <xmx:a96dXvdRtYtrzJXEr7nmWpUvPg8dTY0zDbF_d-_2AIb4JI2LkqDnig>
 <xmx:a96dXslGlDPq165AZVuuOKoFnyVmcFqDQa55_24lldzTYr5cNHf21g>
 <xmx:bN6dXmXwNRsoukfxp2cNQ3vlkjJOPrQaCX5Wp7uwyMrJ4lgo6VvOdg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 41AB23065C23;
 Mon, 20 Apr 2020 13:39:55 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Tal Shnaiderman <talshn@mellanox.com>,
 bruce.richardson@intel.com, david.marchand@redhat.com
Date: Mon, 20 Apr 2020 19:39:54 +0200
Message-ID: <3834383.y1PWrYsiD0@thomas>
In-Reply-To: <6e66deb1-e952-9e9c-81c1-dc51fc1326c4@intel.com>
References: <AM0PR05MB5313B467CCD24AF9DB919226A9F30@AM0PR05MB5313.eurprd05.prod.outlook.com>
 <3278563.U75o6juQT5@thomas> <6e66deb1-e952-9e9c-81c1-dc51fc1326c4@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/04/2020 16:07, Burakov, Anatoly:
> On 19-Apr-20 2:10 PM, Thomas Monjalon wrote:
> > 19/04/2020 15:09, Thomas Monjalon:
> >> 17/04/2020 16:09, Burakov, Anatoly:
> >>> On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote:
> >>>> On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote:
> >>>>> Hi Anatoly,
> >>>>>
> >>>>> I=E2=80=99m working on the implementation of bus/pci driver for Win=
dows,
> >>>>> pci_common.c uses the titled functions however they are relevant on=
ly
> >>>>> for Linux OS.
> >>>>>
> >>>>> I=E2=80=99m wondering if the implementation of those functions shou=
ld be moved
> >>>>> to a Linux specific area since FreeBSD (and now Windows) are forced=
 to
> >>>>> implemented those in the current state.
> >>>
> >>> Unfortunately, we don't have a generic API for these, but since we
> >>> export a single API on all platforms, either all platforms have to
> >>> implement these functions, or none of them do. There's simply no way =
to
> >>> avoid implementing stubs for these functions, short of coming up with=
 a
> >>> generic API that would replace these. Given that this API is heavily
> >>> Linux specific, i don't see that happening.
> >>
> >> Because it is Linux specific, we should not force FreeBSD and Windows
> >> having stubs. Can we move VFIO calls in Linux-specific files?
> >>
> >> I think rte_vfio.h should be moved in lib/librte_eal/linux/include.
> >=20
> > +Cc Bruce and David
>=20
> ...and have a Linux-specific ABI?

Yes, the ABI is different depending on arch and OS.
That's a fact, and I don't see any problem with it.