From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 69B881B24D for ; Fri, 20 Oct 2017 21:01:44 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id q42so12141815wrb.7 for ; Fri, 20 Oct 2017 12:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google; h=from:to:reply-to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cc1f+j6lYNVweiBFb/oUUWiu7wxEpYMj7IlWMo/znaI=; b=A77dWOKEJX1zHDECHU4PcL820hk8iA1UKgX/e/3l5QD2wROnQstFenKVPTy+p7QWYt n+0g9eMOZX5PxLGKVvsuELUtOTd2L7BXhG5/OoIPotNmf8PrrrTfle8ZG3ZrT5EYCTWb jZpYQgIL4/NdckbGW/aMRpa88rPAZFRRWDABc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:reply-to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Cc1f+j6lYNVweiBFb/oUUWiu7wxEpYMj7IlWMo/znaI=; b=r67m3KAra6PHIQNbq2b4lO9OLOdRnrBFwyzSpnxvp2jZYe9f/qCm3c5pL9DyrP7bcs L4I2+iIKPwxwT5/eRe/yf04Mo1g9vQJSNcnnTdhjHsDquGPv7dr7qrs/K6bvQytyIEWf yjg/tfaid8clN7MWY6wUlJ4GNCkO92yEE583oVVlOEgmFFht1rsLwvjzLJFUMfL/U5QU JeIGgcyB9TEooVQ1hLN9TMDc/jHnmupW1ubdqPqPFAgwkGHZD/DNTfUDaN6TfDYgFGiT IxzShoMp4FpwcobIlZUOWNcRELKhj+IcEALQMbVPlxvw+KTSXVJRA7DoWbfBAYCYJdH/ FNpw== X-Gm-Message-State: AMCzsaXsYJPSnfuqlP/8qjY7Olqds0WQ6ERWZIEQ1WVZtFejuzeaQ8EF kiJrec9WqmbPBWUYoMjezYI1mA== X-Google-Smtp-Source: ABhQp+RQstf1s+hULKvatnI/Gsa7S1Xqo2DAPmhcsjo221B58US/zU6SLt3mkHwzB0HrZeHd5r/sPw== X-Received: by 10.223.135.197 with SMTP id c5mr4742678wrc.183.1508526103865; Fri, 20 Oct 2017 12:01:43 -0700 (PDT) Received: from polaris.localnet (bzq-84-109-69-99.red.bezeqint.net. [84.109.69.99]) by smtp.gmail.com with ESMTPSA id t191sm1283623wmt.36.2017.10.20.12.01.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Oct 2017 12:01:42 -0700 (PDT) From: Gregory Etelson To: Ferruh Yigit Cc: Jingjing Wu , Shijith Thotton , Harish Patil , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy Date: Fri, 20 Oct 2017 22:01:41 +0300 Message-ID: <3835922.kUIWXBeaEf@polaris> In-Reply-To: <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: gregory@weka.io List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 19:01:44 -0000 On Friday, 20 October 2017 19:57:38 IDT Ferruh Yigit wrote: > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > Remove device reset during application start, the reset for application > > exit still there. > > > > Reset in open removed because of following comments: > > 1- Device reset not completed when VF driver loaded, which cause VF PMD > > > > initialization error. > > Adding delay can solve the issue but will increase driver load time. > > > > 2- Reset will be issues all devices unconditionally, not very efficient > > > > way. > > > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device > > file") Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > Hi Jingjing, Shijith, Gregory, Harish, > > Can you please test this on top of current master (which has already > Jingjin's fix) ? > > Thanks, > ferruh > sure. > > --- > > Cc: Jianfeng Tan > > Cc: Jingjing Wu > > Cc: Shijith Thotton > > Cc: Gregory Etelson > > Cc: Harish Patil > > Cc: George Prekas > > Cc: Sergio Gonzalez Monroy > > --- > > > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index f7ef82554..fd320d87d > > 100644 > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > @@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode > > *inode)> > > struct pci_dev *dev = udev->pdev; > > int err; > > > > - pci_reset_function(dev); > > - > > > > /* set bus master, which was cleared by the reset function */ > > pci_set_master(dev);