From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 37128594E for ; Mon, 1 Aug 2016 23:37:06 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id o80so262735228wme.1 for ; Mon, 01 Aug 2016 14:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=6pSQ00wz5XYxHOwvJnucV5NlCnKk+/h3A8yMZs6rxrs=; b=qN4J7ap9PvEiL8JOBA++kr7YBndkFUMjwKYcjkuqnaA6nOHoV5/5niWrPY8/j8zlO2 vDWMkod1ZMA6ndZBF1TMS0tMSu+2YXizmygkdiu6SHN+XdkZlgzkKND2OmjnBflehpM5 omz1rIWdCutfCS6wYU/S0Vwutja84ZTkc7TQG6O5tKBS5xaKEq8/mvgFgONgA8y4s2w8 E3bxrJecmGBZgSpjKZ09WliPXp4mBndsYmVBYgJNDc6Z4xKY0VUt4/35Jq/0HGOPZ8pm Oh9fjlf3xSZqBVzVJr3+8dLXolRbV6CQBJKAsFD+omQNaX6nMnExP1Au6TExnj/INKrx gB2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=6pSQ00wz5XYxHOwvJnucV5NlCnKk+/h3A8yMZs6rxrs=; b=kgAUQFbKdW7eaM7cAzX1CVPWdgXwiRezO4nzXyIcVfjklqj94EcuPTW4JHIcX9/Jez DoXA5/9fygjK/QV23WI56on4Ln+9ssckiv0kZSoNnkDaOJpHuGUEzEo9sCDfqRPQDOro P/71OXpZrky6PDTVnzT/gxcYi2ntfgMwlKp5C3eZc5ZaPxYJBsyeXj+9j2R5vhi+Gdyu 9eRV0TglPPAM4xlGZs0oY6PKUavzuyjtrWG8aghMOBCpMRQ2aIY+rODx/pMfvDW2cdz7 h1td12tvb6jB81tKHG/5f6Qd4qOb02paGAYzT4Huc+z4qJt2oLZQwI+4m93rztRg+R65 I1SQ== X-Gm-Message-State: AEkoouvomjgj4Zjx5wD7OrI+sHVvWqXkuUEyNUNIgor6asISAvCnutkA1oDiWeAIL5CzNJ6g X-Received: by 10.28.51.210 with SMTP id z201mr15836946wmz.98.1470087425876; Mon, 01 Aug 2016 14:37:05 -0700 (PDT) Received: from xps13.localnet (86.114.118.80.rev.sfr.net. [80.118.114.86]) by smtp.gmail.com with ESMTPSA id jc4sm23760924wjb.6.2016.08.01.14.37.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 14:37:04 -0700 (PDT) From: Thomas Monjalon To: John McNamara Cc: dev@dpdk.org Date: Mon, 01 Aug 2016 23:37:03 +0200 Message-ID: <3844504.Omypy6q39V@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1469793554-1013-1-git-send-email-john.mcnamara@intel.com> References: <1467309817-11739-1-git-send-email-john.mcnamara@intel.com> <1469793554-1013-1-git-send-email-john.mcnamara@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: autogenerate nic overview table from ini files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 21:37:06 -0000 Hi John, 2016-07-29 12:59, John McNamara: > Convert the NIC feature table in the overview doc into a set of ini > files and add functions into the Sphinx conf.py file to auto-generate > them back into an RST table. I have not reviewed the Python code which generate the RST table. It works so it could be applied as is. > The reason for doing this is to make it easier for PMD maintainers to > update the feature matrix that makes up the table and to avoid > frequent and hard to resolve conflicts in doc/guides/nics/overview.rst. Yes thanks for the work. My main concern before applying this patch, is the name of the files: > doc/guides/nics/nic_features/fm10k.ini | 34 ++++++ > doc/guides/nics/nic_features/fm10k_vec.ini | 34 ++++++ > doc/guides/nics/nic_features/fm10k_vf.ini | 28 +++++ > doc/guides/nics/nic_features/fm10kvf_vec.ini | 28 +++++ > doc/guides/nics/nic_features/i40e.ini | 47 ++++++++ > doc/guides/nics/nic_features/i40e_vec.ini | 39 +++++++ > doc/guides/nics/nic_features/i40e_vf.ini | 36 +++++++ > doc/guides/nics/nic_features/i40evf_vec.ini | 28 +++++ > doc/guides/nics/nic_features/igb.ini | 44 ++++++++ > doc/guides/nics/nic_features/igb_vf.ini | 27 +++++ > doc/guides/nics/nic_features/ixgbe.ini | 54 ++++++++++ > doc/guides/nics/nic_features/ixgbe_vec.ini | 46 ++++++++ > doc/guides/nics/nic_features/ixgbe_vf.ini | 37 +++++++ > doc/guides/nics/nic_features/ixgbevf_vec.ini | 29 +++++ It would be more consistent to always put an underscore before vf. About the directory, I suggest doc/guides/nics/features/. Other small nit: there is a typo in every files: availble -> available. It would be nice to start the 16.11 cycle with this change and make sure we won't change the filenames later in the cycle. So we can start sending some patches without risking a conflict. Thanks