From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65F22A04A4; Wed, 2 Mar 2022 15:46:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0054C42715; Wed, 2 Mar 2022 15:46:45 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id C865340141 for ; Wed, 2 Mar 2022 15:46:43 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id AA09058260B; Wed, 2 Mar 2022 09:46:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 02 Mar 2022 09:46:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=ye5y3145W9pt/Q imgE6slq2I+tj56m+uxKBqtaiKOZo=; b=DRZIvK2FoZKKwprgGwH5GB0+G0vTi7 LHSwiKGx//Ld9e0QNWrXXMFdUA8wbxNWTUzDk7SwU4p+1sNqvBBl7b/N4Q226sfm 9iDlcFYGhPtsXSflhfxUNAsozx3oR3ygFTLnwkDDseDROh8Ypm9AkOMbadJrsDJX VpnCL/0OGdB9tFAFAdonU82l+3eStpwE54/Je5/F1n5HF1VVfCJX4hzih2w4XJoe wr4gHLi9glRGnLe/ptnrmtiplfk8lrH0TyVaEHQCqWqiTTZg2FpvehSjRGCGLAVF ihWwmiY0KGfE+C0tzQ458RpZxheWE3SW1Qg36dQODv3ebWOW+p5JlSKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ye5y3145W9pt/QimgE6slq2I+tj56m+uxKBqtaiKO Zo=; b=MoR/EqnA0PrSg4oL93KpSpyg1AkuqQ9cViDU+YF8kHf8lbwZqQILXNCX2 ZruhN3pH2mp0EK7VVu4miOQnDczXYyJ7gahzZF25Vk/EVICvXrINvay5qSzEMk27 VXIICX8LmHvelYlmL7IHOxP26NdvRegAPal2m9glOJOI9ZasqEUL/DMtHNpIAbq4 QE+fAZZmNw9A2sWRSiM1gbEEb0GuI6C+POcfdkAVT5J27lbaXbnJy67tMzGV3Uyj pm4qw1Fn7oV42RwpjnSsKP4yrQ3fwcexxIbol1jnHzbhi5l0WkG+2WB6N4IOmJng abDoh+0XCZZFrL/51IOz2Ce9foXJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtgedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Mar 2022 09:46:40 -0500 (EST) From: Thomas Monjalon To: "lihuisong (C)" , Ferruh Yigit , "Min Hu (Connor)" , "dev@dpdk.org" , Andrew Rybchenko , Qi Zhang , Ori Kam Cc: Olivier Matz , Ajit Khaparde , "jerinj@marvell.com" , Stephen Hemminger , Slava Ovsiienko , huangdaode Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior Date: Wed, 02 Mar 2022 15:46:37 +0100 Message-ID: <3844855.QkHrqEjB74@thomas> In-Reply-To: References: <20220228032146.37407-1-humin29@huawei.com> <5b829b45-220b-daa2-19e4-3b3fc746d152@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/03/2022 15:07, Ori Kam: > From: lihuisong (C) > > =E5=9C=A8 2022/3/1 0:42, Ferruh Yigit =E5=86=99=E9=81=93: > > > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > > >> From: Huisong Li > > >> > > >> RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in > > >> dev_configure phase. However, if this flag isn't set, RSS can be ena= bled > > >> through the ethdev ops and rte_flow API. This behavior is contrary to > > >> each > > >> other. > > >> > > >> Fixes: c37ca66f2b27 ("net/hns3: support RSS") > > >> Cc: stable@dpdk.org > > >> > > >> Signed-off-by: Huisong Li > > > > > > > > > Hi Huisong, Connor, > > > > > > Let's get a little more feedback for this patch, cc'ed more people. > > > > > > > > > To enable RSS, multi queue mode should be set to > > > 'RTE_ETH_MQ_RX_RSS_FLAG'. > > > > > > But I wonder if it is required to configure RSS via flow API, > >=20 > > I do not know the original purpose of adding the RSS configuration in > > flow API. > >=20 > The purpose is simple, this allow to create RSS per rule and not a global= one. > For example create RSS that sends TCP to some queues while othe RSS will = send > UDP traffic to different queues. >=20 > > However, as far as I know, the hash algorithm can be configured via this > > API, > >=20 > > but not via ethdev ops API. > >=20 > > > and if other PMDs check this configuration for flow API? > >=20 > > Some PMDs already have similar check in RSS releated ops or rte_flow AP= I. > >=20 > > For example, hinic, axbge, bnxt, cnxk, otx2, and ena. I suggest removing these checks. > From my view point those are two different settings. > The RTE_ETH_MQ_RX_RSS_FLAG is global per port while > rte_flow is per rule. >=20 > I think, that if a PMD needs this flag, in order to enable it also for rt= e_flow then > it should be documented in the release note of the PMD. > It is a valid use case that the default traffic will not have RSS and onl= y rules created by > rte_flow will have the RSS, for matching traffc. I think RTE_ETH_MQ_RX_RSS_FLAG should not be required by any PMD for rte_flow RSS rules.