From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6D8D923D for ; Sat, 15 Jul 2017 11:44:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B1EC7205D5; Sat, 15 Jul 2017 05:44:29 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sat, 15 Jul 2017 05:44:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=O/sFZ1NZygfLMfG 3DSgKVvqMpDU4usjeEvmrPgv6JOI=; b=s1J+ex44mXxvoB2lRSD5Be4nhsICM/V luc88JCtzLh2YHEB6HKZMGWNXgsgQlkPGWUpuIJp/xiDXkH05TL5Vpp9+jmciPD/ UxLJ2ykMLTXqKwaZxfXNGrf+aoQYQmKjzd//5AoHL8XYfJ55R55EcPifYxLF23Xp hgXz6l7Z7r24= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=O/sFZ1NZygfLMfG3DSgKVvqMpDU4usjeEvmrPgv6JOI=; b=bmjYJavF +Q8TaPIVhLPVEWaTGlTofV6qmRsW8dtMLdb+n2uff2FEJmSoNtSzwwCkIGua8J6e aEmuICjnZMDrP+OmYwXtJcRN9MU60ETRHvigwhi5/deSIfvd09nipfgbRc2xAw/e 0PsOXa+e/kaVBKq+6epoHVRVdsG+nuo759vkS6em5M6uppGNC7QODTRlGxZ0mfsL 3Y1jUAvKojn1z4RLD2L21q3hmpFEH6lbavMFVjCWIr++f6nrGnbXDwENIBZdNkIA A6OHghp8ONQoFMnMQQ/yI3tJH8+nTd1JpbJie25+qCzpn1i80FykznT3RGXptfmG PjfHO/7CFXYEiw== X-ME-Sender: X-Sasl-enc: ggLzS8EeLL4oVZpE3FBcBgbaykL06x7ya+ZDbjfp4pfN 1500111869 Received: from xps.localnet (apoitiers-656-1-613-51.w109-214.abo.wanadoo.fr [109.214.42.51]) by mail.messagingengine.com (Postfix) with ESMTPA id 251CA248B9; Sat, 15 Jul 2017 05:44:29 -0400 (EDT) From: Thomas Monjalon To: "Wiles, Keith" Cc: stephen@networkplumber.org, dev@dpdk.org Date: Sat, 15 Jul 2017 11:44:27 +0200 Message-ID: <38475944.HgsPK1xuzd@xps> In-Reply-To: References: <20170711185546.26138-2-stephen@networkplumber.org> <64D029E5-9E50-4A2F-90E4-964061FEA8B3@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: add script to find duplicated includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jul 2017 09:44:30 -0000 14/07/2017 20:43, Wiles, Keith: > > On Jul 14, 2017, at 1:39 PM, Wiles, Keith wrote: > >> On Jul 14, 2017, at 12:07 PM, Thomas Monjalon wr= ote: > >> +cd $(dirname $(readlink -m $0))/.. > >=20 > > I tried the script it works, but I am concerned about the =E2=80=98cd= =E2=80=99 above as it does all of the the repo. I would like to see it do j= ust the directory and sub-directories if a path is given. If I am testing a= specific PMD or library then I would not want to do all of the repo. > >=20 >=20 > I was thinking about something like the following: >=20 > if [ "$1x" =3D "x" ]; then > cd $(dirname $(readlink -m $0))/.. > fi Yes we can add a parameter to the script. The parameter would be the path to check, and the default value is the whole repo. So the script could be used also for another repo - like pktgen ;) I'll send a v2