From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 4DEB011D4 for ; Fri, 15 Jul 2016 16:37:56 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id i5so32804059wmg.0 for ; Fri, 15 Jul 2016 07:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=6lSwDi71BGTuP8HscHhCN54Q2LwDuBqC3aQ1nM6aUf4=; b=AN3am1jmv8KsftNzU6sS7WrM4VRXNnCF7IX530/70JCNdAglaENzEfV9iC3QD8ILwq jWAk1Umqztz5P90GSOO8837QGIWzhRwshsJIq1qQd9IFU63EfMEVXyN8HnApzJHaeG7D 6Othk4teTNc6/KuuBjLdcCa35K1vgB4u8KEObobY9qpC97P51FSwSS72g7UGKmm2III1 s/2uLue5HU7E/jMFLgxHd1GjEaFQSukUWdpGenAyOTPmAaTwk/PJKIGKZihg5Ulrr5zp MGETI2m/m+0vQGx2awvt97CJqwwua3KM5nBsJAznIY/bwOZ2eTmKQp5Z60dul4Hn1dM2 eMcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=6lSwDi71BGTuP8HscHhCN54Q2LwDuBqC3aQ1nM6aUf4=; b=bSuMwSCdpBwnpkGi3UZ0vZxJE3XKcbKOlygXSx/mUKlYksv2TuWdhGqrsEmSlNYLgH 5EVk7g49Q6GRS4bSyP4nHPM1kNAhdV5cP/s858+rCOvnV+o6/TcHSKmWsepKMe9sAoX6 80QvW2IdTWh4ptnBg8OozLisjuDTq3emiHIt2Ux60Krz8W4pNlbfULW4TJcfN8uap/LF InTj1zGRk2K3W7UCz7OY2fkqAks6OnTSIVSx38kEiheYFotlwnBE7kKi8Eq0vVDuReC8 olhwkZUYd9m2NjRodUaTjQt9RzAOM64YltKre2SDsiO6OcAxdFTC+ij8D1G1Ou7p9Hze sNsQ== X-Gm-Message-State: ALyK8tIVT8zDL1LclWBK6muOQQaUDcp80aJVI6nTcC7QhyW/Z+Cigp6R99L9Xt41CeIRrIBo X-Received: by 10.194.189.11 with SMTP id ge11mr1120249wjc.141.1468593476060; Fri, 15 Jul 2016 07:37:56 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o142sm26474wme.20.2016.07.15.07.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 07:37:55 -0700 (PDT) From: Thomas Monjalon To: Jan Viktorin , damarion@cisco.com Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , David Marchand Date: Fri, 15 Jul 2016 16:37:54 +0200 Message-ID: <3850930.xJZUcGIqBK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160714200336.119bcfce@jvn> References: <20160714132729.27024-1-damarion@cisco.com> <20160714200336.119bcfce@jvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 14:37:56 -0000 I will apply it with trivial changes suggested by Jan and the small needed changes that I describe below: 2016-07-14 20:03, Jan Viktorin: > On Thu, 14 Jul 2016 15:27:29 +0200 > damarion@cisco.com wrote: > > --- /dev/null > > +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c [...] > > +uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead > > + of the rte_cpu_get_flag_enabled function */ This variable must be exported in the .map file. > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c > > > > # from arch dir > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c > > +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c > > This is not good, you provide rte_spinlock.c only for x86. Building > for any other arch would fail to find this file. This change do the trick: -SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c +SRCS-$(CONFIG_RTE_ARCH_X86) += rte_spinlock.c (Note that CONFIG_RTE_EXEC_ENV_LINUXAPP check is not needed inside linuxapp EAL) > Moreover, the bsdapp/eal/Makefile should reflect this situation as > well. Yes