DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Howard Wang <howard_wang@realsil.com.cn>, dev@dpdk.org
Cc: pro_nic_dpdk@realtek.com
Subject: Re: [PATCH v7 00/17] modify code as suggested by the maintainer
Date: Wed, 13 Nov 2024 00:22:34 +0000	[thread overview]
Message-ID: <38556d99-9f3b-453a-9a01-88e143a8fb8f@amd.com> (raw)
In-Reply-To: <20241112095804.42091-1-howard_wang@realsil.com.cn>

On 11/12/2024 9:57 AM, Howard Wang wrote:
> ./devtools/check-xxxx and some small issues
> 
> Howard Wang (17):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for HW config
>   net/r8169: add PHY registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for PHY configuration
>   net/r8169: add support for HW initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting FW version
>   net/r8169: add driver start and driver stop
>

Hi Howard,

Series is mostly OK, I put some comments on checkpatch warnings or
documentation issues, can you please check them.

      parent reply	other threads:[~2024-11-13  0:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12  9:57 Howard Wang
2024-11-12  9:57 ` [PATCH v7 01/17] net/r8169: add PMD driver skeleton Howard Wang
2024-11-12 16:44   ` Stephen Hemminger
2024-11-12 23:55   ` Ferruh Yigit
2024-11-12  9:57 ` [PATCH v7 02/17] net/r8169: add logging structure Howard Wang
2024-11-12 23:07   ` Ferruh Yigit
2024-11-12  9:57 ` [PATCH v7 03/17] net/r8169: add hardware registers access routines Howard Wang
2024-11-12  9:57 ` [PATCH v7 04/17] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-11-12  9:57 ` [PATCH v7 05/17] net/r8169: add support for HW config Howard Wang
2024-11-12  9:57 ` [PATCH v7 06/17] net/r8169: add PHY registers access routines Howard Wang
2024-11-12  9:57 ` [PATCH v7 07/17] net/r8169: add support for hardware operations Howard Wang
2024-11-12 23:38   ` Ferruh Yigit
2024-11-12  9:57 ` [PATCH v7 08/17] net/r8169: add support for PHY configuration Howard Wang
2024-11-12 23:40   ` Ferruh Yigit
2024-11-12  9:57 ` [PATCH v7 09/17] net/r8169: add support for HW initialization Howard Wang
2024-11-12  9:57 ` [PATCH v7 10/17] net/r8169: add link status and interrupt management Howard Wang
2024-11-12  9:57 ` [PATCH v7 11/17] net/r8169: implement Rx path Howard Wang
2024-11-13  0:04   ` Ferruh Yigit
2024-11-12  9:57 ` [PATCH v7 12/17] net/r8169: implement Tx path Howard Wang
2024-11-12  9:58 ` [PATCH v7 13/17] net/r8169: implement device statistics Howard Wang
2024-11-12  9:58 ` [PATCH v7 14/17] net/r8169: implement promisc and allmulti modes Howard Wang
2024-11-13  0:08   ` Ferruh Yigit
2024-11-12  9:58 ` [PATCH v7 15/17] net/r8169: implement MTU configuration Howard Wang
2024-11-12  9:58 ` [PATCH v7 16/17] net/r8169: add support for getting FW version Howard Wang
2024-11-12  9:58 ` [PATCH v7 17/17] net/r8169: add driver start and driver stop Howard Wang
2024-11-13  0:22 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38556d99-9f3b-453a-9a01-88e143a8fb8f@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=dev@dpdk.org \
    --cc=howard_wang@realsil.com.cn \
    --cc=pro_nic_dpdk@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).