From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05C1B45C9B; Wed, 13 Nov 2024 01:22:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F684402BC; Wed, 13 Nov 2024 01:22:45 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by mails.dpdk.org (Postfix) with ESMTP id AD9F140265 for ; Wed, 13 Nov 2024 01:22:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IhlPHuI6fCHlRUnOZuPJJf0qf2JIH26Y+WtelE3kJCUXZr2CB9Q5tbU+WCqXCoshzBf9h8rHw7NPGQvOPP/gUdfXj1p7ASEOT2iadlWDLlofQoRMHLMVve5yi/1IfUmT3/pSIosKUuZVtBi9lIEPBwcgpLMUUMbAR+nm8IoBFv8g0vnQMSZVVowRi6QIuKNMGIjI6mQR60L1P/dtLHl4DKHSWMgeevG0lbcVAFw48LTDrdrFmmg8yNg/D6KZwsQHtZ6Zq/j0LxIByjMW7H5GFfitKzNib8q7GEF/yxQFXoogB5SDGe5udZSn2JtQTbQv4qE+rbI5ZMdmbKRp2UDtVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vkCeBfP7l6YYYfHsh5f5LX+hCrPv5u46EiYFAk92qE0=; b=fQoJNgdT4hITm3v6BapC7rqbuPZ+aNpMpl60mKDSRaUY3E0+8rzSJVic2/DP8XCT7KBF8FF3ev8Rcr7tUF5WE3F4M8TXxsEFmyQjPvlS26s8jWgpejNd0xpIFKVPyj4BoSO9GGf1CaAnKoK/y6II4nq2AQFWJjA8bJSJ8XzAVkAwdPnYx94hpHJZV+Q+t7bl0NEsKbp4zgGWadUZ05NuamTOnJVAR+MiiVgCo/d6QCB0rrrhAIOFoyYCdkAiBpEPzbwEZ94nuLGPH3vg9N3FljUnsElh2XxCrUY4OtWRsp1UhSYffJd2SoDq3vf9kWl4OWPQrJ4wVmPDX+HZ5zsWRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkCeBfP7l6YYYfHsh5f5LX+hCrPv5u46EiYFAk92qE0=; b=Mqs8YTAuS04iks535NY/dNUAchLg2o0kb8fF7HS7Raa/HjdheXvArxzYaaKIgMOuaAfRgN5iCuxaPeOvvylxmqEffyrV62HQhpXmMuEWHJIGJ+0FFKl36XDVB+CUCnilDDctvQ2Krnb+7/cZaNMSRh4Lbxq+uXrfopJry2M0ctA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CY5PR12MB6275.namprd12.prod.outlook.com (2603:10b6:930:20::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Wed, 13 Nov 2024 00:22:39 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8158.013; Wed, 13 Nov 2024 00:22:39 +0000 Message-ID: <38556d99-9f3b-453a-9a01-88e143a8fb8f@amd.com> Date: Wed, 13 Nov 2024 00:22:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 00/17] modify code as suggested by the maintainer To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241112095804.42091-1-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241112095804.42091-1-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0089.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::22) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CY5PR12MB6275:EE_ X-MS-Office365-Filtering-Correlation-Id: d3a77ffe-9055-4a4f-5343-08dd0379482b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WnBXWHZwRC9nM3o4TjBNZ1FhVFREMUhsWDdsV2pOcWhFc2FQMG5hZldBWmRY?= =?utf-8?B?Q1ZvLzJ3TGtRK3dta2ZsTFF1Vy9kZDBMdnhHY1d1RG52azZHblBPN29sTlpi?= =?utf-8?B?SlA2WmU1eGtsS25iL0dzcER6SU9YUm5mT3RxUGxnaklkeXpPKzFPRElXWUFs?= =?utf-8?B?bGdqMFZSdE1PVU95czB2a1NuMEcyRkFpcVQyQ09OUXZPN1RyRklMQlJTakdE?= =?utf-8?B?TjcrNlZvbk50bEtXQWlhNERBdmRqNmNmWVpLSnI5S0N2QWErY0UraEp0OEJu?= =?utf-8?B?V0lYY2dKUnUxZXk5Q2FWb0pvNFp2eDYzcGJCeDNmWHd1MmEvUDZXVTQwL2VU?= =?utf-8?B?N2VBYk5oVmVyY1JJSnhOWjZIQ1VPcFB1QlNsNWowUFMzTWV6M1ljbVdCV1Bm?= =?utf-8?B?RjFQMVd6cUFTeHhzUXRScERkbGIxd2xuSTZKd29VeVpzWjFhdnBMeCtxNTZI?= =?utf-8?B?Sm5PdDBRdWpsL3NDOWIrNjNhcDd0Z1pwdVhtV1B5V0RENXBodVdBM3gzZk01?= =?utf-8?B?RlU4MnZZQ1l3YlNIRE05Yk91Z1ZZNEx3QWhDV3hNNm9vOHdZaFhsSThSeGhZ?= =?utf-8?B?R1MvRkpySjRZR2IycGd1b0lpdXFnRWhzbmxINnVzcVhIRHh3MW5lMnlQYTlr?= =?utf-8?B?QkFpY1VJbW1aV2lCYXJtekhZaGdPMzl1VzZzK0tCR0krZnorN09KWFRKeXNQ?= =?utf-8?B?M3BQaVlTcGNMbmtXK2ZqNHBLWks4WFBpUUdpWmcwY1dZQmxzTVlWZ0xHYS96?= =?utf-8?B?V2JsUVgwK1NITXlzQktVWUVIVms0ekxzN3hmdU5aRjc5Nm80Qm91RkVLdjVw?= =?utf-8?B?SXg1ZmpRR0t4cDA1TDkwOHpRSS9YVFNNNkZKZXRzbEt1MlV1ZVNDOFk2bjJu?= =?utf-8?B?aWQrMzJqOHFYNUVPQjkzakdsMldMRmh6cElQbjYxN092SkVIb3pJZ0liRW9j?= =?utf-8?B?emp3R2lHZnJVUW9WaUZxUEdMRU5iWTI1Rkp4UmFIaFU1czdWV1pNZHVEVTR0?= =?utf-8?B?aEJGNUs3V21Cd2oza2ZHcnlqcU1SLzhwRG9KY2JKTjltQnEzZTRXWEh3ZDJa?= =?utf-8?B?dldwU2NIbXBaNkh4aE92VFB5SEdiYVpnWUhaWkpQUXg3WXlrelM5Z2wxSnJq?= =?utf-8?B?cUE0VTZERHkvQXM5b0Y2L3JydUZQV01lSG0ydTBwTDl2OUVTTXhZOGIraWJO?= =?utf-8?B?MERYTDI2Q0d0enY2eE91RGxqd291dGtNZTJXMG8xYjNXZTduaDh5SDZ2bDA2?= =?utf-8?B?TXlWUytSSHBkV1lMbE8xdkJpdjZGb3pyK05xWC83Y2d3cVdLekFacEdzcTlj?= =?utf-8?B?ZGpGSk8vUThyTHoxOU9EaG1TdGFEUmJVZDQ0dlV3T0RUVGdZbk9qUTlGQXhu?= =?utf-8?B?WU1JZElIWnllUWQzMjAvSS9wMGlSZ21ETys4L1Q3bDlCRWdibGp2SitHZHRE?= =?utf-8?B?RHAyWk1XTExISklRRXRnU0E3dU00azZRSVZNZGtndGJkb2p5elVwYTF0Qmtp?= =?utf-8?B?OW9tNTdxb1RpR2FvR3ZIUEhneEVhVmpNekVIdGdYa1FhRi9wdGxCak1pbWZt?= =?utf-8?B?UjdsL3d3Si95TnUrRmlXNFkvR0ZOeGdzc0lINGRyK3dNSzZDaTg3dml6YTRU?= =?utf-8?B?MFB1QXdKR00xUW0zMnE2T3pUNVNpcnJsbmFoNDBCNmM0OS9pSTkyeGNKWVJQ?= =?utf-8?B?S1ZqbmxYbmdtU0QwZy9tMk5VbTQzOHJHUU5WQXJNeGRBekI2cFhxZzMyMFBo?= =?utf-8?Q?EsTVf41aFtXS2/55LI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG1ndzZHRWNkTmx3UVlmc2o2Z3A3RmNaQ3IyMnNSYnMzMDQwamgzUEJobFZV?= =?utf-8?B?T1ZGZjRzUmZ3Q3E4Q3psRDJ2NU5XR0xXbHJ2aTFKNjJOYitkQnB5VktNN1VR?= =?utf-8?B?akYzc3YyTjkvMWhrWG1OYjAxVHhZYUFGWmpVL0xDbWMyMHB6bUY4MEtMeFpS?= =?utf-8?B?Uld5WS94aE5jbVgwMkdqNEJJeFhqRDdhdGtVcUw2SjROWkxnUjZBbTRvZU1P?= =?utf-8?B?WEhwcVJGdG9xQXZ4SVV2bmFJN3F5NXlUb3g0RW16Z2RuRjNJcm5USVRvS2hm?= =?utf-8?B?MFc5aFNKejlvTzVtcis4S0ZLaWtuTVVGRGJKcEthakgzT3h1Slc4ZG9uT1Fn?= =?utf-8?B?MmtocER1c0NiRElYVm5ucFpKNERpcnNkQ2xyclY3VnRldXQzaGZqbVZ6RVJo?= =?utf-8?B?Ym9tVk1xTUhZRHhQdjhINmMxV21tTGF6Y2ZjU2c5NkpGM3FIM2pkcm85U01H?= =?utf-8?B?ejlPT0pXdGVCYkVnVW0wNXpoK1hsWkNVVDVuZVVuZ1JrTzNsQmJUN0NNL3FW?= =?utf-8?B?ME5uU0h2bWFQTjdtSFQ1THp4MFlJcUQxM3I1dlNrZUdOMnZFYU1aUnc4MDEy?= =?utf-8?B?MG5aTDlJQXFFSUhqTVNTMmJ2ZnNPR0dMVGR3eXVtamNwRDFKZzlocWtwYlE4?= =?utf-8?B?TVVwQ1pqc3Fab0x1Ym9XUnJVRXF6bDhxSHU2eXJVSytqd2JtYklQVVl0WUFW?= =?utf-8?B?eWJEMG9yZTFERTU5Qk1PK2tCMW9vdGZvVFlTM01qZXB5STJiTE1SNmhSZGIv?= =?utf-8?B?VGZPemNFc3R6VkRNS3dxcDlSclBFMkdLVEpzSDJXdHFJMmtORHdZRzZhQ1FG?= =?utf-8?B?WHk1eDV5dCtERUMzeEJ0TndHLzdXZFVtSHlwcy9JQ3JJQ1dacTBFZ1FCaDBL?= =?utf-8?B?VnBVd3I5aVdMK0U5Q1dMOUZKd3o2eU1MZG1sWEdsWSt4T21nKzRXWkxOSG5o?= =?utf-8?B?NkVwTTRsUVZxaDEvcllzSjcwVzBtc2prOXZiOVRCY1RZeU9iNmdWVk1LMTZL?= =?utf-8?B?VktTclZhc0VSRkhqbDVkd3RCT2p1djZBeGYwZzRXYWN1emxvQkJBRllldTVo?= =?utf-8?B?RVhiaW5WNTMwUDVhQ2ZhRkFBMStrWUhiNkRoejdxTXNRN1hXVFVtN1Q4ZGdo?= =?utf-8?B?U0xTYmFja3hKcU1Gc0tJTE42UFpVNUdqMStJNDdZL2t3TWNLVzRGVVF6aDhs?= =?utf-8?B?MUdaaGJiK1FkNjdhTjZHeXZLeVFleGJHZVdjbnVMSGhRb2ZDMXlUL0hPSldq?= =?utf-8?B?NDF2UHR3T2ZGNnZXeEVxbldCL2dQN1ZUblNCVmxqVllkNXl4K29VTHRHbnlE?= =?utf-8?B?c0FRcjBLUmRvYVZDYjVVWTVUN28vb0tueEhTMWJ4clRUTHEvOEE5Z2lFL3hi?= =?utf-8?B?Y0phNWlxWEVpOEc3eXh5NkdqaEh5QnZ6MGJiWU9Xb3NIcFpCcldNdUIrSTdN?= =?utf-8?B?dWc3Y3JGSjNBV1lpSS8xOVNRbXBCMUp1Y3lDQUw2NVE3YzhjUGE1WGpuaVdQ?= =?utf-8?B?VjR5L1BFbmM3YWdMbDNDc3VMYTJYWGU3RlZhUndHd1NiYmlSUVhhTG1pQ3Q3?= =?utf-8?B?bXFaSWczZFZ6OU4zNXVEMW5Da2g2R2pTOXdSNXA5WmdSZWpFSVVHcklUTjl1?= =?utf-8?B?cDk4eVBVeEFnM250WkNzM0dTT3BkMXFWQVBvS0dxcHoxUUFTbWFIb0V5NVF2?= =?utf-8?B?NHRuVmlFUTZrSkRxTGNuMys2QUFLazRPd0RPdTVmNU1WNFRkc3c4T1g4aytj?= =?utf-8?B?MTZTTG9ZNmpQRnJPVVlkVlk5TGpwL1F1dk96VU1GR2Q0NDIxQXZNTFFBdTJn?= =?utf-8?B?ZlE3UWFkWWlpZFNrS2xzRVB6RGh2UDZ3VkZTdUIyaUZkbjlOa0VDV3dUdnJL?= =?utf-8?B?d0VSUUZZcXlWK0xpMlBKSkVnNm9lb0RSNURYTTBRdnBQclZzZy9taTFHdnhQ?= =?utf-8?B?KytGaUlpZFpQdzVuQWlxMnArWXBzWHdmWEVDWE4yUEFtcmZxMEZQZWZhdjFB?= =?utf-8?B?STRtYU9ad1JaWlFlL1k1UmxkS2JCdlNZVFcrd01pMUZYdmZ4cG80azQ2MFBz?= =?utf-8?B?RmZ5NDRBeFFYblFIY0VoV2FCTmdzb1FKOXJ1d20wdGQ1YkdYQUJJcjVZMWMr?= =?utf-8?Q?0I7Q9YJBvTYUL01SKkM9jjPp5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3a77ffe-9055-4a4f-5343-08dd0379482b X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2024 00:22:39.5673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wj3P+6u4gxlyKnEI0nFzcVEP8b9R+e/9hAGrYnrc2n2i5Rv0sN9MTaqyudB+eRHa X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6275 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/12/2024 9:57 AM, Howard Wang wrote: > ./devtools/check-xxxx and some small issues > > Howard Wang (17): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for HW config > net/r8169: add PHY registers access routines > net/r8169: add support for hardware operations > net/r8169: add support for PHY configuration > net/r8169: add support for HW initialization > net/r8169: add link status and interrupt management > net/r8169: implement Rx path > net/r8169: implement Tx path > net/r8169: implement device statistics > net/r8169: implement promisc and allmulti modes > net/r8169: implement MTU configuration > net/r8169: add support for getting FW version > net/r8169: add driver start and driver stop > Hi Howard, Series is mostly OK, I put some comments on checkpatch warnings or documentation issues, can you please check them.