From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C11621F3 for ; Sat, 29 Mar 2014 11:33:14 +0100 (CET) Received: by mail-wg0-f44.google.com with SMTP id m15so4265731wgh.3 for ; Sat, 29 Mar 2014 03:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Rj6X+QbZGtSUEY1J78/o5hrfcY1Fnv6m7iTWmimANOQ=; b=cgmXViby7Hb/ztTVzhJ5SRmjjeUejm5t29FAbz9txvVEQKRZlWk8afUNSLbC+SwHdN 5yOMS3c8DKLuG7QXyhfhBOt0oOXJbVyWtk/2QD3QZtUR7xxlzSg7sRtMW4/hqXeWZJDY Z504B9M2/RA7k4y6wUuh02yyLZlQeS9e7/IgHrxv7pGaX00eFH7WtLnMusbYzTjodJOF 2nOr1eCOGydqTOQNgksh4175yHUuieEIKoJHn6erknyzL1EkuMqY5NrbHolGb8foJK74 RZ2BfwnkHmcKNbrWIpYbwqC+j/uXjOVi6NanZU7SB6IHDPJYTMGzAAP9Dn6rDM4v3urU 017w== X-Gm-Message-State: ALoCoQmtyz3nY8q5PS5gUMU1M1kA/mFEtLMljFKFk8HsUA+7Kstx7F1MYs2m5wCYNUioHjsFTs8h X-Received: by 10.180.101.40 with SMTP id fd8mr1406568wib.1.1396089288450; Sat, 29 Mar 2014 03:34:48 -0700 (PDT) Received: from x220.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213]) by mx.google.com with ESMTPSA id jd2sm13257219wic.9.2014.03.29.03.34.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Mar 2014 03:34:47 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Sat, 29 Mar 2014 11:34:46 +0100 Message-ID: <3857255.iofc7hnFnA@x220> Organization: 6WIND User-Agent: KMail/4.12.2 (Linux/3.12.9-2-ARCH; KDE/4.12.2; x86_64; ; ) In-Reply-To: <1396056749-11738-1-git-send-email-nhorman@tuxdriver.com> References: <1396056749-11738-1-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pcap: remove test for PCAP_CAN_SEND X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2014 10:33:15 -0000 Hi Neil, 28/03/2014 21:32, Neil Horman : > The libpcap library has had the ability to send packets since 2004, theres > really no need to test for it. Especially in the way dpdk is doing as, as > according to the libpcap git tree pcap_sendpacket has never been a #define, > and dpdk tests for its existance with an #ifdef. Its easier just to remove > the test entirely > > Signed-off-by: Neil Horman A similar patch is already applied on HEAD: http://dpdk.org/browse/dpdk/commit/?id=2a315d698510e7b33 -- Thomas