From: Thomas Monjalon <thomas@monjalon.net>
To: Jonas Pfefferle1 <JPF@zurich.ibm.com>, anatoly.burakov@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling
Date: Tue, 07 Nov 2017 10:40:15 +0100 [thread overview]
Message-ID: <3858523.3OloCCdIaW@xps> (raw)
In-Reply-To: <OF16C3B3D8.330B4ED7-ONC12581D1.00302F92-C12581D1.0031FB9C@notes.na.collabserv.com>
07/11/2017 10:05, Jonas Pfefferle1:
> Thomas Monjalon <thomas@monjalon.net> wrote on 11/06/2017 09:25:15 PM:
>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > To: Jonas Pfefferle <jpf@zurich.ibm.com>, anatoly.burakov@intel.com
> > Cc: dev@dpdk.org
> > Date: 11/06/2017 09:55 PM
> > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling
> >
> > 31/10/2017 16:59, Jonas Pfefferle:
> > > Check and report errors on open/read in noiommu check.
> > >
> > > Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> >
> > I cannot decide to apply this patch as it does not explain what
> > it is fixing, and as it is not reviewed.
> >
>
> This patch adds error handling and logging to the noiommu check.
> Also, on older kernels when the noiommu_enable file does not exist it
> assumes noiommu is not enabled instead of returning -1.
> Note that in rte_pci_get_iommu_class (drivers/bus/pci/linux/pci.c)
> is the only usage of the function and it assumes return == 1:
> noiommu is enabled any other return value noiommu disabled, i.e.
> my code change does not change the behavior of this function.
> We might want to check for errors in rte_pci_get_iommu_class
> as well since assuming it is not enabled when we cannot open
> and read it might lead to iova == VA being used even if noiommu is
> enabled.
>
> All this comes back to what I proposed before: instead of
> the noiommu and PPC64 check we should decide which iova mode
> to use depending on the iommu types available.
> The type should be already available at the point where we
> decide on the iova type.
> (iommu types supported is checked by vfio_get_container_fd)
Is there something urgent for 17.11?
Or can it be refined in 18.02?
Anatoly, any thought?
next prev parent reply other threads:[~2017-11-07 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:59 Jonas Pfefferle
2017-11-06 20:25 ` Thomas Monjalon
2017-11-07 9:05 ` Jonas Pfefferle1
2017-11-07 9:40 ` Thomas Monjalon [this message]
2017-11-07 9:50 ` Jonas Pfefferle1
2018-01-11 23:45 ` Thomas Monjalon
2018-01-13 12:15 ` Burakov, Anatoly
2018-01-13 22:49 ` Thomas Monjalon
2018-01-15 12:22 ` Jonas Pfefferle
2018-01-15 16:11 ` Thomas Monjalon
2018-01-16 16:08 ` Jonas Pfefferle
2018-01-16 17:01 ` Maxime Coquelin
2018-01-17 8:48 ` Jonas Pfefferle
2018-01-17 8:55 ` Maxime Coquelin
2018-01-17 10:34 ` Jonas Pfefferle
2018-01-16 10:07 ` Burakov, Anatoly
2018-01-16 16:09 ` Jonas Pfefferle
2018-01-13 12:05 ` Burakov, Anatoly
2018-01-19 17:37 ` Maxime Coquelin
2018-01-20 14:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3858523.3OloCCdIaW@xps \
--to=thomas@monjalon.net \
--cc=JPF@zurich.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).