From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E842A00BE; Tue, 7 Jul 2020 13:06:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F7681DCFB; Tue, 7 Jul 2020 13:06:53 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 974F61D633 for ; Tue, 7 Jul 2020 13:06:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 0BA9D5802AA; Tue, 7 Jul 2020 07:06:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 07 Jul 2020 07:06:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= lO722Gj8gGLdAIdpmJzmRP1JxnlelFDZHLCIVDhjYwU=; b=I61SNDW1BabKv6nP 5V544MuB+YKyEwmhZWGYYWYaOapOXi6mRkYXfrcKyuydXoVY3JhLnFsC6OBRlT3t iM0tx8mnY9Z31dRJBKwB5qbm5mmT1BNRNLuwvVCy9EjQ/xdbiAunEydeH91DOqQG TZLFtDB8ysiZJvz6QxCW3HZUwgIU9RjDvGEEy0ArdRMMnBd/6//ISVJOL9DWPBtO 6xVYDXmaHd8qZvHC+FW1Z++mO59oYPNpOY12FqWYbm+qzi+pc+0apkKgPr+k9AhM nTgX++lqyVnXXlQwblQ4AFboV2Zv65f4dAW0w3e1MQ5yZq0RQdN86EwWuMmvCUF8 RL5CCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=lO722Gj8gGLdAIdpmJzmRP1JxnlelFDZHLCIVDhjY wU=; b=W5YMQSFLBMUsa/yKS/K1A1MSST4wgW7Pw+JVEHqPqrq8b+p8FhAGD3YFQ ZBH37xxs+EoFZBDisO3GUx7Boq9RVUkwfE/9+I9DbH3/sTvjBNpKrfwcfZ34x+/5 Hhhr+eAQACVW7wDHfX4Eyx/ccc7xNaU5Lu618yxn0kG9VWPW+j84HKDJIIYBK0oH bfLngcpZPIQrsP7VJLtJMJqlhLLB7uXqNuJ4ChWUtx8DpHLw270Ulwg2VoWdfrK1 SL7h77xhVxzjlVyYrKO4mq/pLPlgAra/8zFt+kHRlKw1JvQ9c/0isE9VUSGZoqkX pAMQ9Jj7bNMg/rlJ/G0WZMY+/P9vw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2346A30600A9; Tue, 7 Jul 2020 07:06:50 -0400 (EDT) From: Thomas Monjalon To: qi.z.zhang@intel.com, xiaolong.ye@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, jia.guo@intel.com, junfeng.guo@intel.com, simei.su@intel.com, Junfeng Guo , ferruh.yigit@intel.com, arybchenko@solarflare.com, viacheslavo@mellanox.com, jerinj@marvell.com, ajit.khaparde@broadcom.com Date: Tue, 07 Jul 2020 13:06:49 +0200 Message-ID: <3862163.zQz20bWevW@thomas> In-Reply-To: <20200616081644.23887-2-junfeng.guo@intel.com> References: <20200612080711.39774-1-junfeng.guo@intel.com> <20200616081644.23887-1-junfeng.guo@intel.com> <20200616081644.23887-2-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add new RSS types for IPv6 prefix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2020 10:16, Junfeng Guo: > This patch defines new RSS offload types for IPv6 prefix with 32, 48, > 64 bits of both SRC and DST IPv6 address. > > Signed-off-by: Junfeng Guo > --- > lib/librte_ethdev/rte_ethdev.h | 51 ++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 631b146bd..5a7ba36d8 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -538,6 +538,9 @@ struct rte_eth_rss_conf { > #define ETH_RSS_L4_DST_ONLY (1ULL << 60) > #define ETH_RSS_L2_SRC_ONLY (1ULL << 59) > #define ETH_RSS_L2_DST_ONLY (1ULL << 58) > +#define ETH_RSS_L3_PRE32 (1ULL << 57) > +#define ETH_RSS_L3_PRE48 (1ULL << 56) > +#define ETH_RSS_L3_PRE64 (1ULL << 55) PRE32, 48 and 64 are not obvious. Why is it needed? At least, please add comments for the values of this API. Do we want to continue with the RTE_ prefix missing? Can't we add the prefix for the new values? Note: ethdev maintainers were not Cc'ed. This reason is enough to nack the patch.