From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Wiles, Keith" <keith.wiles@intel.com>,
"Power, Ciara" <ciara.power@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status
Date: Mon, 18 Jan 2021 15:02:49 +0100 [thread overview]
Message-ID: <38646937.bSsQRFMa1O@thomas> (raw)
In-Reply-To: <MN2PR11MB382147086D8A149185F6EF27E6A80@MN2PR11MB3821.namprd11.prod.outlook.com>
> >When querying the link status via telemetry interface, we don't want the
> >client to have to wait for multiple seconds for a reply. Therefore use
> >"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry
> >callback.
> >
> >Cc: stable@dpdk.org
> >Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks")
> >
> >Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >---
> >--- a/lib/librte_ethdev/rte_ethdev.c
> >+++ b/lib/librte_ethdev/rte_ethdev.c
> >@@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd
> >- ret = rte_eth_link_get(port_id, &link);
> >+ ret = rte_eth_link_get_nowait(port_id, &link);
>
> This change looks good to me.
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2021-01-18 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 12:17 Bruce Richardson
2021-01-14 15:06 ` Power, Ciara
2021-01-18 14:02 ` Thomas Monjalon [this message]
2021-01-18 14:48 ` Ferruh Yigit
2021-01-19 1:06 ` Min Hu (Connor)
2021-01-19 2:26 ` Stephen Hemminger
2021-01-19 2:58 ` Min Hu (Connor)
2021-01-19 10:06 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38646937.bSsQRFMa1O@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).