From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Tal Shnaiderman <talshn@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] questions about Windows basic memory management patch
Date: Mon, 06 Apr 2020 15:24:26 +0200 [thread overview]
Message-ID: <38689326.XIDecUUvMD@xps> (raw)
In-Reply-To: <20200406153734.40cb5c5a@Sovereign>
06/04/2020 14:37, Dmitry Kozlyuk:
> > Lastly, in the patch you implemented functions that were common for Linux and FreeBSD and in order to use them in Windows (e.g. eal_file_truncate that replaced ftruncate) and you got a duplicate code for Linux and FreeBSD, how can we solve this duplication ?
>
> In v2 I'm going to create lib/librte_eal/posix subdirectory and move such
> code there. I expect more code to end up there eventually, for example,
> dynamic library loading. This possibility was among motivations for EAL
> directory split.
Indeed it was the motivation.
I think /unix/ is a better directory name than /posix/
Maybe I'm wrong but I had the feeling some interfaces are common
between Linux and FreeBSD while not part of POSIX standard.
Comments are welcome to help taking the right decision.
> There're another duplication that worries me: copy & paste from Linux EAL in
> eal_malloc.c and eal_memory.c initialization. However, it this can't be
> helped, I'd rather leave it be for now and reconsider it when implementing
> advanced memory management.
There are a lot of copy/paste in EAL which can be refactored.
Any help here is welcome.
prev parent reply other threads:[~2020-04-06 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 11:44 Fady Bader
2020-04-06 12:37 ` Dmitry Kozlyuk
2020-04-06 13:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38689326.XIDecUUvMD@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).