From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0E96A330D for <dev@dpdk.org>; Fri, 4 Aug 2017 16:28:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3BC8C20D41; Fri, 4 Aug 2017 10:28:48 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 04 Aug 2017 10:28:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=d2PnlPAX0zSf9nQ 21vkQ7+1Qj4eWFyUfgr5+STwpRzg=; b=K06OcKkMI3+ZM8ehHdTNSz7s5JjOb1T /jcVt34KavQJW270qANUm2k8W2UI2L4sz5hlo0PBj/2HXX8Qqull3hDSM5LOQ2Vr TAQ/C46cSkUIUjCu99+0ok0Jojosm9pUiZ97i4fjWPIKokEKyp8KfrTsUkwfYHZF i3Z8tkz5/YPM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=d2PnlPAX0zSf9nQ21vkQ7+1Qj4eWFyUfgr5+STwpRzg=; b=jj5TDr+2 RVp5lWOwTj964Ag6NA3j3RViaRVs5RBoSucB8QtNl4UFqiqZ/+2RoEMGekpfnxnQ gLAPtgauUI1FnYKksWKwk8LlKiw9V6B2XQoqLiDH7INGV190iDrK8FVFLeweMcXA l7cqryB19Xrpurx71PTN+h2A6po4WcgXl2dH+13z/DoE7743P0RP3Mi5Bn1NzEdg 1Wf5WAtSjEqMWRJZuz2S8nG7hzPVkBDkQ6Jp0H0tW5r1OnQ7MoWCAXiVguqZxiu1 a3ukPVwGi/DN6UJ1PdvC9KXLiwB2lZaXCJFGpBkq012G+kbnKZEeBSsvsUGJVFFM pD/8KX5xsSYeBw== X-ME-Sender: <xms:oISEWa4c-Q1QLcOI9VrQthvhSIqN4preEtmFk4aKkCB79lLTynaxTA> X-Sasl-enc: dxuNRdapwAPZtMMJUUev0o4hoZWyqOBzQBWI6rdH6UVb 1501856927 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD3DC7FA68; Fri, 4 Aug 2017 10:28:47 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, remy.horton@intel.com Cc: dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com, radu.nicolau@intel.com, david.hunt@intel.com Date: Fri, 04 Aug 2017 16:28:46 +0200 Message-ID: <3871111.0JZd9azV8i@xps> In-Reply-To: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com> References: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: API change notice for librte_meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 04 Aug 2017 14:28:49 -0000 04/08/2017 15:19, Cristian Dumitrescu: > +* librte_meter: The API will change to accommodate configuration profiles. > + Most of the API functions will have an additional opaque parameter. Why? Why opaque parameter? If you want to use it with a configuration file, you just have to implement a configuration file in your application. Moreover, I already explained my fear of adding this library in DPDK which is really an application-level statistics lib. Without more explanations, my vote is a nack. However I remember there was a promise to merge every metrics libs in one.