From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 0FE377ECF
 for <dev@dpdk.org>; Thu,  9 Oct 2014 20:13:30 +0200 (CEST)
Received: by mail-wg0-f48.google.com with SMTP id k14so1989034wgh.19
 for <dev@dpdk.org>; Thu, 09 Oct 2014 11:20:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=HtNuWJ+YMbG07l5M5JKOPf90BsVtIYTcVEINpslRPP8=;
 b=anztym0/NTaX7r2CWH/YwOEnu+NqDJe8pugjb6uEHJNsOD7KSQ23/fhDo+Q1nJS7ZZ
 bnQwwbzTyaXmtf4uil2j4cWMCuXboYKj0VZRw98bEwXJ3yafL2MWNMtLBZ8qy10JW9P7
 qomQ4v/R6dD3vqDzyaumdHj/JaJqMX8Cuzx9THURfQwjrGUH4fK+OCo+TauMFPcrppL5
 +0CuhECMXBMzKEDE3DGQm7j73P9m+e6+GFYK3R8YCBa1v7t7G1ZqkH0FV1XaW31xj2he
 wlIoReKILnRMwnYbHF8qzvr+4Ik+4orOIhB+bkXIU7GaJygl0JTAz0ziSuLJVnQIxUQ8
 gqfw==
X-Gm-Message-State: ALoCoQkYZocP/rIAUGOiKtfvUZanMhu9Hbl51sqfGm1SwvJhZ0O/sTX3mPDDTZVM/RUqdTKdL8Aj
X-Received: by 10.180.73.210 with SMTP id n18mr35759164wiv.79.1412878851609;
 Thu, 09 Oct 2014 11:20:51 -0700 (PDT)
Received: from xps13.localnet (1.17.90.92.rev.sfr.net. [92.90.17.1])
 by mx.google.com with ESMTPSA id d6sm33800wiz.0.2014.10.09.11.20.49
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Oct 2014 11:20:50 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Roger Keith" <keith.wiles@windriver.com>
Date: Thu, 09 Oct 2014 18:46:24 +0200
Message-ID: <3871468.xmvE5bJmrt@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <1EEE2DAF-2F00-4B95-A1ED-262FA9E00077@windriver.com>
References: <1EEE2DAF-2F00-4B95-A1ED-262FA9E00077@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Remove n_orig from __mempool_get_bulk()
	routine, cleanup  comment.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2014 18:13:30 -0000

Hi Keith,

2014-10-03 21:27, Wiles, Roger Keith:
> Cleanup the code some to remove n_orig variable that was not required.                                                              
> Update the comments to __mempool_get_bulk to state the correct return value.                                                       
> 
> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>                                                                              
[...]
>   * @return
> - *   - >=0: Success; number of objects supplied.
> + *   - 0: Success; number of objects requested.
>   *   - <0: Error; code of ring dequeue function.
>   */
>  static inline int __attribute__((always_inline))
> @@ -945,9 +945,6 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
>                    unsigned n, int is_mc)

Please, could you check ret? I think it can be >0.

Formatting comment: title should be
	mempool: remove useless variable
Prefer short title, especially when behavior is not changed.

Thanks
-- 
Thomas