From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 6954A5323 for ; Wed, 5 Aug 2015 15:36:21 +0200 (CEST) Received: by wibhh20 with SMTP id hh20so24675424wib.0 for ; Wed, 05 Aug 2015 06:36:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PVnNeBq7jPVIP49vG9LC0AxP/rulg6UK+l/rUgVvDH4=; b=mG84NYTNLgop+ixUSqcXqSYtCcYMj2RUfsHENOuV94+G+qEPy60uHNrFPKbkFTx1J3 c3pnJwUutjcVIY2LqAJejkI3ta1Svnd4j4WnYRk82XGuoqXyLHEI8oD1fxo9/qLSRNBB SJjrzbgN6afPzwhB8x6H9ZTm768FSlap/QPK/R6rlSpXQBlzPlH8ez9CrCY9dyRHzdBK ligFVtI4Mu35SCXyi296QazQdqMgFHy522ppVD4VUk5tcqRnwn3d2NW7ZpLgclp766o+ St5sBJsqyTiQNBYg6VBvGVaG8Pk7mQZz2dT1ehMtFq2jguMUDg0HdG04zAcs1c7C4wAd Xf/A== X-Gm-Message-State: ALoCoQkRVKyHjIcSSkXw9kJ+rTghoBOBdiZCkgFNEZF18aQfAWKCn3AQ7mr4tlNAfITaXJ4s8gvP X-Received: by 10.194.205.170 with SMTP id lh10mr21297026wjc.1.1438781780270; Wed, 05 Aug 2015 06:36:20 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id z9sm7690993wiv.9.2015.08.05.06.36.18 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Aug 2015 06:36:19 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Date: Wed, 05 Aug 2015 15:35:04 +0200 Message-ID: <3872346.WHI1RvlFCy@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com> References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> <1514392.p4W8R5bZo1@xps13> <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2015 13:36:21 -0000 2015-08-05 13:19, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-08-05 13:36, Bernard Iremonger: > > > if the name parameter to rte_eth_bond_create() was NULL, there was a > > > segmentation fault because eth_dev was also NULL. > > > > You also add error handling of mac_addrs alloc and release_port(). > > It deserves to be said in this commit message. > > Will I send a v3 patch ? My comment was mostly to show which kind of information may be useful. Sometimes I write it myself. You are welcome to write it in order I add it or you can send a v3. Other note: the function names are avoided in commit titles as they are redundant with the title prefix and not so easy to read. The title could be bonding: fix crash on initialization error or, to include other fixes, bonding: fix device initialization error handling Thanks