From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9B86D1B1A4 for ; Fri, 6 Oct 2017 19:08:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E3C6420C6D; Fri, 6 Oct 2017 13:08:23 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 06 Oct 2017 13:08:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ZrESH5fJPuAIA0Q RzVeZwwetfI4773LSZWNbjuOsEw4=; b=snq5rm5dbe+3/ZVR2bKg9IlAUNgrQb0 KLG8hvwx8PEH7Y8GbZehLK2oV9vq3uXHZrAzZgCKC8P043s9e+ehre+ytzagSX8X f3uoUrZLcr5AsWhSXyOh1jtdpa5SGg5PEildMQJ0z0P7MiehmJq+YHST4nrrZ0Oi ovWPCLLgrpFY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ZrESH5fJPuAIA0QRzVeZwwetfI4773LSZWNbjuOsEw4=; b=NZlmPWAA 0nr4udBGtWXWRCy6Y+9zWnQtgHwO/ruxq8mcRWq9SeSIy2p+srpCEomBLa7rwFjL XB6i2NVf/c+ST+mMiub+zwkK3XJ/mUI+tu99nG7212vLdi23Inl4e1NkHmZX626B Od9IuzmFyWvCATAtEknzZjAxR0LD8PLS9XfigsoTSd9kHi6iVDU1R1y+YeAPVpdo m7BtLLp5otJMHafPPUbe7tCfTTJSRzkjBk4/uvHsOhlSVoO7N4/nkshfpQkKfG9g 9HEh02Y4/B+NkwtGA9G8XKO0rWoOxAY0Zb/t0iD5hkxy+kl7zQZGyv1Zsr06dgzO Qb4NJYZLUCdoow== X-ME-Sender: X-Sasl-enc: 55N/kz48naRvZDBO28FkO5OyFmHpHnC4wsNhndgMfuqO 1507309703 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 988FD7F92C; Fri, 6 Oct 2017 13:08:23 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal Cc: anatoly.burakov@intel.com, dev@dpdk.org Date: Fri, 06 Oct 2017 19:08:22 +0200 Message-ID: <3872801.Digd9JTyXe@xps> In-Reply-To: <1afffe26-d574-0c6d-6101-836aaca1a37b@nxp.com> References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> <2584395.73f1Oakct5@xps> <1afffe26-d574-0c6d-6101-836aaca1a37b@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 17:08:24 -0000 06/10/2017 18:22, Hemant Agrawal: > On 10/6/2017 5:11 AM, Thomas Monjalon wrote: > > 13/07/2017 13:48, Hemant Agrawal: > >> In case no_pci is configured, fslmc bus will still need the > >> the vfio to be enabled. > >> > >> Signed-off-by: Hemant Agrawal > >> --- > >> --- a/lib/librte_eal/linuxapp/eal/eal.c > >> +++ b/lib/librte_eal/linuxapp/eal/eal.c > >> +#ifdef RTE_LIBRTE_FSLMC_BUS > >> + if (!vfio_enabled) { > >> + if (!vfio_enable("vfio_fsl_mc")) > >> + vfio_enabled = 1; > >> + } > >> +#endif > > > > It seems to be a hack. > > VFIO is not only PCI. > > Why --no-pci is impacting VFIO? > > > > Anatoly? > > > > At present there are only 2 users of VFIO. PCI and fsl-mc bus. > > > One options is that we always enable vfio irrespective of --no-pci flag. > My believe is that vfio-pci will be present in most system supporting > any other flavor of vfio (platform, fsl-mc etc). > > The other option is what I proposed. i.e. if vfio is not already enabled > the platform is FSLMC bus, enable it. Why not always enable it?