From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 551221B4D3 for <dev@dpdk.org>; Wed, 3 Apr 2019 19:23:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 03E53214E7; Wed, 3 Apr 2019 13:23:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Apr 2019 13:23:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NEL+OwVr2YgG2J/M0+PfO9U0J2Kj06VGsxuX7gK3oYs=; b=Gi8BjxWF7Iu7 FEOgIHqwjX7NdI8kwa0mB97FCKTv0VSkEuK7qg+Fu5NJsJ97b9vDB+klFWcUskuc csDaVvRJS/CUDKR8wFMQLb5Xo6PENBcPDKB6kYmqzjwi6MTN02X64GvjvlR8rhGd DXsFl1HZAhtJhGpJbbFuskop5NycRqI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NEL+OwVr2YgG2J/M0+PfO9U0J2Kj06VGsxuX7gK3o Ys=; b=Es6YYls61rZx6ToHLTxf5mKSzGqe0O2gR3xxi3Unv7pWbopV5ruGg/ciD S/Y05pPa/8Q+KqRqMIOK289Md/hFKNMU3zj417uefxcC1MV/Jg2HHEb3/yOTLxDR iNc6+FSt0nS3lSwOiMBKG611v/6kRv8B3+9wiQTqvH00cZw8WsSbPM1lYdNByouH 5D77fhdzNOnlRAI5OGT+4Dl0RuWdIn6UvtsVwNAf6OCQxKCQSDSsTYJucsABzQqT o+E7dlEIQ+V24OrXzs9As/mlQZQlpIL7A336aPTnBTWUgS0Ru3qz9R9uKPebxpGX ORCucDpT43F6+omwM+GhxyQWtY/YA== X-ME-Sender: <xms:F-ykXIMRwxVE9eiAdSPbigZedMZw4L-L-bcGNdjLDI0pW-ON4AJMKg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdekieculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: <xmx:F-ykXKjNnwrfcGcYjBWPnDCCRpk5B1F52K6oy4Xmk17Yv7JNwU8Epg> <xmx:F-ykXPQcqi0U0EyiFay-9R-x6uRGdj046OgTMP0byZKyriiI7U_iFA> <xmx:F-ykXFp_spLjxgcMN1MR1rKbZr3g_Jur6yux07k8-8iS24qETfrgHw> <xmx:GOykXENiod67ug0AOzQ_xEzXdkLAlolBmzHCBy446O8FFvnXzovZqg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E724E49E4; Wed, 3 Apr 2019 13:23:34 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Eads, Gage" <gage.eads@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com> Date: Wed, 03 Apr 2019 19:23:33 +0200 Message-ID: <3878276.WNQnuX6GrZ@xps> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> References: <20190401001238.17625-1-gage.eads@intel.com> <5912114.tna7mvfDTn@xps> <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Apr 2019 17:23:37 -0000 03/04/2019 19:13, Eads, Gage: > > 02/04/2019 13:14, Honnappa Nagarahalli: > > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > > > The rte_stack library provides an API for configuration and use of a > > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > > allowing concurrent access, and the interface supports pushing and > > > > popping multiple pointers at a time. > > > > > > > > The library's interface is modeled after another DPDK data > > > > structure, rte_ring, and its lock-based implementation is derived > > > > from the stack mempool handler. An upcoming commit will migrate the > > > > stack mempool handler to rte_stack. > > > > > > > > Signed-off-by: Gage Eads <gage.eads@intel.com> > > > > Reviewed-by: Olivier Matz <olivier.matz@6wind.com> > > > > --- > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > > > It does not compile for Arm: > > > > lib/librte_stack/rte_stack_std.h: > > In function '__rte_stack_std_pop': > > lib/librte_stack/rte_stack_std.h:68:6: error: > > implicit declaration of function 'unlikely' > > Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks for checking the non-x86 builds. > > I can hold off resubmission until the 128-bit CAS patch is merged, so this series is properly tested in the automated build + test pipeline, if you'd prefer. Yes, would be the best. But we need to merge everything tomorrow at last. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 697ADA0679 for <public@inbox.dpdk.org>; Wed, 3 Apr 2019 19:23:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C1651B508; Wed, 3 Apr 2019 19:23:38 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 551221B4D3 for <dev@dpdk.org>; Wed, 3 Apr 2019 19:23:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 03E53214E7; Wed, 3 Apr 2019 13:23:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Apr 2019 13:23:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NEL+OwVr2YgG2J/M0+PfO9U0J2Kj06VGsxuX7gK3oYs=; b=Gi8BjxWF7Iu7 FEOgIHqwjX7NdI8kwa0mB97FCKTv0VSkEuK7qg+Fu5NJsJ97b9vDB+klFWcUskuc csDaVvRJS/CUDKR8wFMQLb5Xo6PENBcPDKB6kYmqzjwi6MTN02X64GvjvlR8rhGd DXsFl1HZAhtJhGpJbbFuskop5NycRqI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NEL+OwVr2YgG2J/M0+PfO9U0J2Kj06VGsxuX7gK3o Ys=; b=Es6YYls61rZx6ToHLTxf5mKSzGqe0O2gR3xxi3Unv7pWbopV5ruGg/ciD S/Y05pPa/8Q+KqRqMIOK289Md/hFKNMU3zj417uefxcC1MV/Jg2HHEb3/yOTLxDR iNc6+FSt0nS3lSwOiMBKG611v/6kRv8B3+9wiQTqvH00cZw8WsSbPM1lYdNByouH 5D77fhdzNOnlRAI5OGT+4Dl0RuWdIn6UvtsVwNAf6OCQxKCQSDSsTYJucsABzQqT o+E7dlEIQ+V24OrXzs9As/mlQZQlpIL7A336aPTnBTWUgS0Ru3qz9R9uKPebxpGX ORCucDpT43F6+omwM+GhxyQWtY/YA== X-ME-Sender: <xms:F-ykXIMRwxVE9eiAdSPbigZedMZw4L-L-bcGNdjLDI0pW-ON4AJMKg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdekieculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: <xmx:F-ykXKjNnwrfcGcYjBWPnDCCRpk5B1F52K6oy4Xmk17Yv7JNwU8Epg> <xmx:F-ykXPQcqi0U0EyiFay-9R-x6uRGdj046OgTMP0byZKyriiI7U_iFA> <xmx:F-ykXFp_spLjxgcMN1MR1rKbZr3g_Jur6yux07k8-8iS24qETfrgHw> <xmx:GOykXENiod67ug0AOzQ_xEzXdkLAlolBmzHCBy446O8FFvnXzovZqg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E724E49E4; Wed, 3 Apr 2019 13:23:34 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Eads, Gage" <gage.eads@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com> Date: Wed, 03 Apr 2019 19:23:33 +0200 Message-ID: <3878276.WNQnuX6GrZ@xps> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> References: <20190401001238.17625-1-gage.eads@intel.com> <5912114.tna7mvfDTn@xps> <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190403172333.QQ2x11mXPMDF7ySPxJlWK_7l6CQNfotMXO0xFO1qztg@z> 03/04/2019 19:13, Eads, Gage: > > 02/04/2019 13:14, Honnappa Nagarahalli: > > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > > > The rte_stack library provides an API for configuration and use of a > > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > > allowing concurrent access, and the interface supports pushing and > > > > popping multiple pointers at a time. > > > > > > > > The library's interface is modeled after another DPDK data > > > > structure, rte_ring, and its lock-based implementation is derived > > > > from the stack mempool handler. An upcoming commit will migrate the > > > > stack mempool handler to rte_stack. > > > > > > > > Signed-off-by: Gage Eads <gage.eads@intel.com> > > > > Reviewed-by: Olivier Matz <olivier.matz@6wind.com> > > > > --- > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > > > It does not compile for Arm: > > > > lib/librte_stack/rte_stack_std.h: > > In function '__rte_stack_std_pop': > > lib/librte_stack/rte_stack_std.h:68:6: error: > > implicit declaration of function 'unlikely' > > Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks for checking the non-x86 builds. > > I can hold off resubmission until the 128-bit CAS patch is merged, so this series is properly tested in the automated build + test pipeline, if you'd prefer. Yes, would be the best. But we need to merge everything tomorrow at last.