From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 2A1465A9E for ; Mon, 30 Mar 2015 22:31:04 +0200 (CEST) Received: by wgbdm7 with SMTP id dm7so81792587wgb.1 for ; Mon, 30 Mar 2015 13:31:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=n39XnjEwgIeTGKtJJgmgs7ha2A8M8l/7ayge/A/PlM4=; b=hzKkQsirpDqdMAFyI/AUuj+4MNiqYJ12gcZH9Pi9wvk2IYNxMH6UTDaBMOTMHYm+kK D0eGroqDnVY6WJZAfaDYhSZqEE6T4kUQ5mq9TDhesOaU829qP+hYDp7oyEHEdy99vHmW X1m7mJphWIF587AeDjTjRz/G8gYHVNQHNP3/XHn041kB+9o/KjrJqX7xEqG56BVTHcMQ qQ2vlQa6hOBn021S6+sGS0zzYZh1xwQbOPgXlbAlVKunHh3H+7BiIMVRDW4QgbZnjse5 oJ2HMqEvaOnZxLsFqx2lf1Zz3zDATA1CsG/mR9xAj87PTVpaHm3YO3fehuFq0p+VkGIY VVWQ== X-Gm-Message-State: ALoCoQngswqKeqkdaBVUrl69/L+y2P/NUjG200vsgs0S0FiLQ4Ip8Yq5m/D37mpdohZaZSEQG0xA X-Received: by 10.180.102.165 with SMTP id fp5mr6241556wib.80.1427747464042; Mon, 30 Mar 2015 13:31:04 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ev7sm17236461wjb.47.2015.03.30.13.31.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 13:31:03 -0700 (PDT) From: Thomas Monjalon To: Shelton Chia Date: Mon, 30 Mar 2015 22:30:22 +0200 Message-ID: <3880400.EaJEZrUXi7@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com> References: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_pmd_e1000: power down the serdes link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 20:31:04 -0000 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev) > } > > /* Power down the phy. Needed to make the link go Down */ > - e1000_power_down_phy(hw); > + if (hw->phy.media_type == e1000_media_type_copper) > + e1000_power_down_phy(hw); > + else > + e1000_shutdown_fiber_serdes_link(hw); > > igb_dev_clear_queues(dev); Acked-by: Thomas Monjalon Applied, thanks