From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 21ACF4C91 for ; Mon, 10 Sep 2018 17:08:24 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE0ED4072C10; Mon, 10 Sep 2018 15:08:23 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 673E92166BA3; Mon, 10 Sep 2018 15:08:22 +0000 (UTC) To: Nikolay Nikolaev , tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org References: <153202755842.21481.1772155561595981441.stgit@T460> <153202761415.21481.4698894052167645234.stgit@T460> From: Maxime Coquelin Message-ID: <388d5624-15e3-13f1-2fae-153a9581b407@redhat.com> Date: Mon, 10 Sep 2018 17:08:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <153202761415.21481.4698894052167645234.stgit@T460> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 10 Sep 2018 15:08:23 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 10 Sep 2018 15:08:23 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 2/5] vhost: make message handling functions prepare the reply X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 15:08:24 -0000 On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > As VhostUserMsg structure is resued to generate the reply, move the s/resued/reused/ > relevant fields update into the respective message handling functions. > > Signed-off-by: Nikolay Nikolaev > --- > lib/librte_vhost/vhost_user.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > Agree this is cleaner: Reviewed-by: Maxime Coquelin For the typo, don't resend the series just for this if this is the only thing to fix. I suspect a rebase may be required anyway as it may conflict with a patch from Ilya. Thanks, Maxime