From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F870A0548; Fri, 9 Jul 2021 14:49:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD66E4014D; Fri, 9 Jul 2021 14:49:55 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id C35CD40143 for ; Fri, 9 Jul 2021 14:49:53 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 409463200902; Fri, 9 Jul 2021 08:49:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 09 Jul 2021 08:49:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RpI7fLqT1u4jAmTYR6NRTC0lK323mGT6pzN40S7SLvU=; b=ofV9bApBv/tdjSLw cSeUcI1YStgoehmg7THaJHB3FIIs6QfFqJF1GsOCWOCRmDLvWP2boWzA2LSQUriD rvvTBkrEZDjXxphjvfHvL40HHc0oO0ykfHJ5e5b6YiDxqE7US+xwZ0XD7tXo2PWz tftSHk5/Jo5EOUAh67afcTmHrXK3UX78ev6SsmQt8QWrrzv7T5JzupL6peNEErXB c8j7b3nOjlMUmKOhvIRcW7o3GY4KjVWVijNEYfU2Uk1HNN/TbS57wB6jc3tKCEQR assNcmRVoypGI+mziPaKT/y42BANj4lYmZcY18l+8+/USEiqSxkSLd4P2gMijeWQ Zqy1Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=RpI7fLqT1u4jAmTYR6NRTC0lK323mGT6pzN40S7SL vU=; b=U7yxFQkHRTtREMkKonxi4Ybw6MFnYEmmdEMaTwI4r8Q0riKab3g1i2c8O 32xvobvFSAD4l3HQkJeweFNcKVPv/payNnJ7muH1nokktcqvgs2RvYTT5uW9QmKl PfvJ//nv4iMpvIaXNTZTZBp/1sk+fLwjOZfK257DpOjusw8hLyQQNJR4UMYZ757w B+DQQ0s2pNJ8bpvcGhmFLiyuTMKBZwuoFfW1fa/EROS5NyEG+xtFmTrmaSFjMXCk nBtRUbTshF/FNwrnMz3SmOxNfDEVFyMmWp9SWQuUDEWziwWaLg8HJCwhm2zGGWBj 6Dza3EGuR08iMiQuvnEcHzQ7gTUpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrtdeigdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jul 2021 08:49:49 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , Bruce Richardson Cc: Luca Boccassi , dev@dpdk.org, dev@dpdk.org, Rob Scheepens Date: Fri, 09 Jul 2021 14:49:47 +0200 Message-ID: <3891552.MyNZZatdtY@thomas> In-Reply-To: References: <20210630162235.267285-1-dmitry.kozliuk@gmail.com> <57d6b6a0808b899e6b23cd204a1018d519326fd0.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/07/2021 11:57, Bruce Richardson: > On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote: > > On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > > > The `doc` target used `echo` as its command. > > > On Windows, `echo` is always a shell built-in, there is no binary. > > > Starting from meson 0.58, `run_target()` always searches for command > > > executable and no longer accepts `echo` as such on Windows. > > > Replace plain `echo` with a Python one-liner. > > > > > > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson") > > > Cc: Bruce Richardson > > > Cc: Luca Boccassi > > > Cc: stable@dpdk.org > > > > > > Reported-by: Rob Scheepens > > > Signed-off-by: Dmitry Kozlyuk > > > --- > > > > Acked-by: Luca Boccassi > > One small suggestion might be to move the "echo" command definition to > buildtools folder in case it's wanted for use anywhere in the build at some > point in the future. However, this patch is fine without that change too. I did the move in buildtools/meson.build: echo = py3 + ['-c', 'import sys; print(*sys.argv[1:])'] > Acked-by: Bruce Richardson Acked-by: Thomas Monjalon Applied, thanks