From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f181.google.com (mail-wj0-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id A65595587 for ; Wed, 30 Nov 2016 16:09:49 +0100 (CET) Received: by mail-wj0-f181.google.com with SMTP id xy5so176532219wjc.0 for ; Wed, 30 Nov 2016 07:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=odMK5QFotPEtH7EjmKz0yOQkzQfT97n/RiJauyNrjYg=; b=KMVg+ZztGDBI29KPYa47B0epUNbnZtjIOJfk7toAOQt7eJFaq7KKYqs0TQTvJJNIvd B8hkBslXdKIipxqgeV5jLl3jva2CNBCoEpq3cxSY4XCdX1qs4wOa0hRudUqcM6t7vEw7 B4ctNKZOHxTgdPP9s7CKQUw1dDf9UDTR7ajoOjJE9TzpdQhVdn4bGPPPqMVukSZZYx45 ilxhbtTKKvx3pEfgS9XLTrdhuTOYMxKkVwOFyw6GIP/buIgNj44ZNbjEgjXPkqEHQRPH /6+xOzgX3MQ2fW5s0EUWpfk6hsMxJHn7bvz/gLTUv07hy0Ya4Bhmpa/XcQxu1ghtTMXk 8gqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=odMK5QFotPEtH7EjmKz0yOQkzQfT97n/RiJauyNrjYg=; b=IZmz+WtgJk2YP/OaGryUaYBlvt0VGuF4oYFIZCVgUlh6CJjXkkSsicnEtzvCjsjGHN BPYjiVBhfKw9CBGUQ4QQo7cd/qeGIwGwiQ60i1NzY6PVVnmML3zDPzgBz+FPlb/IVPev Yd18TyCZxFSGT+TxASHeRWjTipIeAEvLDfP/4IecP41E8eDPnhlb/NF8G1+IHb/F/KM1 eQ0iGYtKLs7vPvdRsOw6SY5jV2RD/SoUXeiZIN87N/E3sEtXmBgcfX66ZNdJaWML6q1H ETWBkON0jy1UQ66wIiWRTy4ZtCgdF459BGcuV0bbvT9AmCOoB8/rqmh8v1Gnrws9q7BX Begw== X-Gm-Message-State: AKaTC00fayxp421EBIflqYMLUpCOfVKcfVGXkUBreT7uAsSQ3X57xxMa9P/SqcBYQQQZw0z4 X-Received: by 10.194.191.201 with SMTP id ha9mr28536607wjc.205.1480518589151; Wed, 30 Nov 2016 07:09:49 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id yj10sm73568097wjb.3.2016.11.30.07.09.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 07:09:48 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Wed, 30 Nov 2016 16:09:47 +0100 Message-ID: <3896815.T41b2RsLT8@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> References: <1479768194-6255-1-git-send-email-thomas.monjalon@6wind.com> <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 15:09:49 -0000 2016-11-30 14:54, Ferruh Yigit: > On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > > +stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut -d' ' -f2) > > This breaks the "check-git-log.sh -N" usage, since "-N" is not a valid > range for git-log-fixes.sh. > Generates warning: > .../scripts/git-log-fixes.sh: illegal option -- 6 > usage: git-log-fixes.sh [-h] Yes, good catch. I'm trying to fix it by converting -N to HEAD~N.. if printf -- $range | grep -q '^-[0-9]\+' ; then range="HEAD$(printf -- $range | sed 's,^-,~,').." fi > > +# check CC:stable for fixes > > +bad=$(for fix in $stablefixes ; do > > + git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' || > > + git log --format='\t%s' -1 $fix > > +done) > > +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" > > This is good for developer, but since "CC: xx" tags removed when patch > applied, this will generate warnings when run against existing history. I do not think it is a problem. Who runs this tool against existing history? > I don't know what can be done for this. > > Or should we keep CC: tags in commit log perhaps? I do not see the value of keeping the CC: in the git history.