From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 012D0A0C4C; Tue, 21 Sep 2021 11:28:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D8474003E; Tue, 21 Sep 2021 11:28:34 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id EA47A4003C; Tue, 21 Sep 2021 11:28:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="245732298" X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="245732298" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 02:28:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,310,1624345200"; d="scan'208";a="652873308" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 21 Sep 2021 02:28:31 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 21 Sep 2021 02:28:31 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 21 Sep 2021 02:28:31 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 21 Sep 2021 02:28:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4aZZmq8+CXWZtIhUyNzrRt9DzTQW7ZqMmXGhdnP7qIbVRZD1e7eNthCSnZVl+PeqhWQYavu6PSYNr2iZ7vftsPj1Qopd8SZxwu89oVRurWfJ+mTB5A+N3Nzs44XivFcpEF4ldesHc/NXu3PR17SrBi1dxMpuqEaI9lChvJgJ8R8kVLsRL4pwuUY56jHKE+Bxx4UUAQDB5MnnF0RAnnNZ7mA8AQ//69WhHSbo7XpnEkpCIFVCLedOYHkd0NMwAmoOWUVd28bVSWPqSCdb+tMd+jW/baCrDcwisIW3NKu5BS5FaLX7Da1Az7hWRYMJHM4ZEifVDN1c/uvWB2aOmQsTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ng+b2fmqahb6KNUvudK5eyEQzHRpgMaJWaHBkuQj1UM=; b=WrZfKQ84OMx8sWEZyiMtp3IGICxNEKsAbDmOnAD9SBv5vBjfLIZVvhfxaLsR3SdAJUMXxnLpHM2yeghFjcrZ+ofrkRcAFiSc0c1hzbC9d8xF8tbZyfu7Fbb+neJaPuoNW5QW55PIjsWQtFbATL4d86XKP0Mdsc7O6xq1BygVSmJxGWNWv7JCtDzoKWqA0snWTcMjJ7l4xp/N5eV2mlCw93X1z7KQZjKfXNpHAZnya5/lQ7E3woEtM/qfZjpwWWzwPoqp+zGbekv2MzqKxleyo7jQR0BttxuKz/xMvcvis/oqq6hrVblIgimPMt+1WOc2PAmf5U6YxxsL/Axyl6htPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ng+b2fmqahb6KNUvudK5eyEQzHRpgMaJWaHBkuQj1UM=; b=b6hEj+IgyEimNwqi3g3PE7dYbtm+/vwklMPnJou4vTd2zHzLLkZ/ybDX4kQnxvUAT6zMFu+s/LUbfKNis/LZoqfDczDbRFC8fCsHQUl2eBQqMK9vS0lI31R8htO2OfmljoAxIuU4S6GUvl9Us16jnNXt3yjrxnUwQ0zpXMPGO8c= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5208.namprd11.prod.outlook.com (2603:10b6:510:3b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Tue, 21 Sep 2021 09:28:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 09:28:30 +0000 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Lance Richardson" CC: , , Olivier Matz , Konstantin Ananyev , Andrew Rybchenko References: <20210916161040.346703-1-lance.richardson@broadcom.com> <98CBD80474FA8B44BF855DF32C47DC35C61A92@smartserver.smartshare.dk> From: Ferruh Yigit X-User: ferruhy Message-ID: <38a087e1-67dc-f313-6dd6-4ce63a51be50@intel.com> Date: Tue, 21 Sep 2021 10:28:23 +0100 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C61A92@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Tue, 21 Sep 2021 09:28:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d5a03f3-fc98-44a2-992b-08d97ce22c69 X-MS-TrafficTypeDiagnostic: PH0PR11MB5208: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wcm+EGdh1WA8gdnRq3j+3y7AuI1z6K8kEKwy0KA5g50VJH8puITnXlkttqSi3vFYtiZv/nWmz4eTUbzrJsbcf0AODhFkRnA7iMiTyZbX3CMU6C558+MQ97wniTTK7hgdBHcv6H+AXTa+cWxNu9jpfi/9OeAKx4WQqN7rTo2HdzVMwPRXu6Y65fjAwaFUsKIld1mOVJJO4h/f9n3K9HuFti0ctNeRTZDzngTx4zBffnr3n1ifYiHD64bLEUArxWilKD8z/BVa+kilCoa6NHPLkGGmDUNLxeKdRfxlYu24wveEF+ceXP2nfN/FGbVCGiv5F7rFtvNVYXMgpZNR1CpkCDepAV0KWRz8JtQlsTjgQrIwnMeiOfk8IMGXAbmE38p0M1IapbPEF4WO71oMUftrMAZBjddPYdwJ4CEd6h9VOSqXu7/hsd1HyVc1URbDAvm82Q/XhcKx90211wdNS70IehlpiyOvqVR0B8kg64A/+2T9hMBiBQaghQb5l4bQZ5FfbdL/CtXKoTR3++WfMamfkYeTkRwrLtswj7BG7NXPYECoAAxWeeTV4tWKzPzFEpG0MLChU402T+DF6uXvroFhWlfQX/cyfRWPeTZ51f1ATMHq+C2zTxe4is2w6zjMVPjicggrbWj0wlQEqzN3YWTkg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(5660300002)(36756003)(8936002)(8676002)(110136005)(38100700002)(16576012)(4326008)(2616005)(508600001)(66476007)(66946007)(6486002)(53546011)(66556008)(66574015)(86362001)(186003)(31686004)(26005)(956004)(31696002)(316002)(44832011)(6666004)(54906003)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eSt1QW1rYXNQTjBoNHhIZjNlVGtkUWdmbTAzWjFWRnBlbW5EaUxOY0gwbEZo?= =?utf-8?B?dTZnRFp6NHNJSmJJNjFubWtEd0Z4cXptN0lBMndiQ1ZkWC9QWWZ6cUFFWjZK?= =?utf-8?B?UmZyVUdQU3ZBQjBpRkFKNEZlMWtDWkhoMStyNldSL2tqVjdheTlLMGo1TXEr?= =?utf-8?B?R3AvWThXSlRLZVNwRDdNK0VsbHNUM3dTbXVKU0FZY0FEbloyTjAwWTJjS0Rs?= =?utf-8?B?OStsWTlTMG5DQUgybUF0QlNpNGJ4Rnhsckx6aFlZNVh2dUdiRUQ0VFdQVllj?= =?utf-8?B?MXUwUUduYTZDTHFHenBHWlpFTnl5Rm10Y0NCeDJRS2ZqWXF1SkxTK01OY1hJ?= =?utf-8?B?VDMxelFJWS9KbUladHZQUXJPWDBwMkhMTTVYSDZBRGFueEw2QXA5cE9YM3NM?= =?utf-8?B?Vi9RQWw2SzVvdTFUQXpXVXpHb1Q4eG0wN3o0S1haWDFwUmVjYkNGYkFJcUZC?= =?utf-8?B?em81UzBKMVVkbnVEL0xiTE43Si9CQ25iOWdRVUxrdDNyMHpPbUtkY3NHdS9S?= =?utf-8?B?NXc4VE1BaGlDN3IyU2RONEF0K21kV1dCSHIvamEvRi9MN2pNQlFnQUg3VHhO?= =?utf-8?B?bmNTRmlOcitNRkpIMEpyNGZaTVhTNm9YQ1N5c3hLRlpJbXh5b1FGYyt4UVJx?= =?utf-8?B?YlkwbERwL0pESVltNW5TTitZN1loMzJxYjI3RUlMN0wyem13a1dRQXZKY0gw?= =?utf-8?B?TU94ckM2N0RqVFlRazJEVC94ZFplWWhrS1JFMkQyOFkyVE5PRlZoaGt1VFpv?= =?utf-8?B?MEVRdkJ2dVdkTnRSTDJXVDFxSWh0T2Q3a2R3OUprNVlPMUpvczFDMVhVcldL?= =?utf-8?B?MHJLMW1Dam0zNHhxNFoxZG9ZOU41bWYxWnBOWTA5akQzVGV0RWxIU2lONUp5?= =?utf-8?B?QXdiZWptUlJ1ZE5pZGpmTkdOUG5IS0VKZWVaQzFKQUt5UXNFR3lNd3BzbjVI?= =?utf-8?B?Z1RScjZhdDUwNFNPdnFPcFFoYlhLK1FrRlBBSURQdXZFeVFpYjgrK2pka1Ri?= =?utf-8?B?emJqYkg3OEFub2Exc1MxUHgrWThDaExtRGd6UGxvNXRDWS9rdXlGeVp3WDFM?= =?utf-8?B?VStqOGNBRy91NXlsRXc4OTNZLzY0dDdXOHJCU0N6YmdiMnljb3RaNGdieHdh?= =?utf-8?B?SlBuNDJYN25EU3JxdjB5OVBaM1hCV2x3WS9nT0hESGd6TTdqSEdERmhYNGFT?= =?utf-8?B?SHFSbWVQZW1BL3lWcmVQWWpMa1JCYytvRTRiZG1ETFJieTlxV3VNZmJBMnF6?= =?utf-8?B?KzR1bFB0UEo5QWxUMmYvdlpHazBieGRXQ1JmYUZoMWFtL2Z1dGlibXVNOWdh?= =?utf-8?B?MUVjRE9OeHJudVBBazQ4UWxmQXdRaGg0c0NuQU9Nc05FY05mSmlhZnIvVWRU?= =?utf-8?B?M0tpd1IyMVN4V2REVVVEV3NoWE5aNFQzdktNZjFiaE9qYm44a1Q3c1Q5OGp0?= =?utf-8?B?WGh3WUxnMm9GYkY0WVR1czZQY2d0bzIrSUNWZnlOOUJLZnZJN3ZWc0VHcW1w?= =?utf-8?B?cXhZV3B6TlB1cG9ZbU9FZGtKMkpvOXk3SlQzcXJ4Z1BCQ3AvYXRoNyszNkdt?= =?utf-8?B?NFhadUd6WDRZeVNlUCtsTFpvU3Nnalg2NWpWQzNLaUFsZW1zRFdUNmZlL1RF?= =?utf-8?B?OXJndXIrYVdzelpFSVZWak8ybkdJY0x3eGZ0Qzc2SVp1bFZvNjVrL3E5SVk4?= =?utf-8?B?alVzeFR4eGNxMmJQbmpYMG40bUxGdVBxL0hrdGlGRG1sbHoyajFKd1VYUVM0?= =?utf-8?Q?j+xvv2i0zs/DGG8QoHOrbiqCcQzn1at+grLBIo7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5a03f3-fc98-44a2-992b-08d97ce22c69 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2021 09:28:30.1705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hTETbljJT1BadCJVholV0gdBkQsLt1zW3MpFWt8X0bdbqKnr26jgZB/QkoW69gTNYnCm2U1L+zw1RcJcMGpL+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5208 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix checksum API documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2021 11:57 AM, Morten Brørup wrote: >> From: Lance Richardson [mailto:lance.richardson@broadcom.com] >> Sent: Thursday, 16 September 2021 18.11 >> >> Minor corrections and improvements to documentation >> for checksum APIs. >> >> Fixes: 6006818cfb26 ("net: new checksum functions") >> Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums") >> Cc: stable@dpdk.org >> Signed-off-by: Lance Richardson >> --- >> lib/net/rte_ip.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h >> index 05948b69b7..fd08ea31b2 100644 >> --- a/lib/net/rte_ip.h >> +++ b/lib/net/rte_ip.h >> @@ -488,7 +488,7 @@ rte_ipv6_phdr_cksum(const struct rte_ipv6_hdr >> *ipv6_hdr, uint64_t ol_flags) >> } >> >> /** >> - * @internal Calculate the non-complemented IPv4 L4 checksum >> + * @internal Calculate the non-complemented IPv6 L4 checksum >> */ >> static inline uint16_t >> __rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const >> void *l4_hdr) >> @@ -509,15 +509,15 @@ __rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr >> *ipv6_hdr, const void *l4_hdr) >> /** >> * Process the IPv6 UDP or TCP checksum. >> * >> - * The IPv4 header should not contains options. The layer 4 checksum >> - * must be set to 0 in the packet by the caller. >> + * The IPv6 header must not be followed by extension headers. The >> layer 4 >> + * checksum must be set to 0 in the L4 header by the caller. >> * >> * @param ipv6_hdr >> * The pointer to the contiguous IPv6 header. >> * @param l4_hdr >> * The pointer to the beginning of the L4 header. >> * @return >> - * The complemented checksum to set in the IP packet. >> + * The complemented checksum to set in the L4 header. Isn't this wrong for 'rte_ipv4_udptcp_cksum()' too? Since you are touching this, can you fix that one too? >> */ >> static inline uint16_t >> rte_ipv6_udptcp_cksum(const struct rte_ipv6_hdr *ipv6_hdr, const void >> *l4_hdr) >> -- >> 2.25.1 > > Reviewed-by: Morten Brørup >