From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: jspewock@iol.unh.edu, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, wathsala.vithanage@arm.com,
probb@iol.unh.edu, yoan.picchi@foss.arm.com,
Luca.Vizzarro@arm.com, thomas@monjalon.net, alex.chapman@arm.com,
npratte@iol.unh.edu
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/1] dts: add methods for modifying MTU to testpmd shell
Date: Fri, 6 Sep 2024 15:58:28 +0200 [thread overview]
Message-ID: <38a2490c-19d7-4ebb-90ad-36da0933c883@pantheon.tech> (raw)
In-Reply-To: <20240905142123.31342-2-jspewock@iol.unh.edu>
> diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
> index ca24b28070..c1462ba2d3 100644
> --- a/dts/framework/remote_session/testpmd_shell.py
> +++ b/dts/framework/remote_session/testpmd_shell.py
> @@ -888,6 +888,51 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats:
> + def set_port_mtu_all(self, mtu: int, verify: bool = True) -> None:
> + """Change the MTU of all ports using testpmd.
> +
> + Runs :meth:`set_port_mtu` for every port that testpmd is aware of.
> +
> + Args:
> + mtu: Desired value for the MTU to be set to.
> + verify: Whether to verify that setting the MTU on each port was successful or not.
> + Defaults to :data:`True`.
> +
> + Raises:
> + InteractiveCommandExecutionError: If `verify` is :data:`True` and the MTU was not
> + properly updated on at least one port.
> + """
> + if self._app_params.ports is not None:
We should utilize the port info caching patch here:
https://patches.dpdk.org/project/dpdk/patch/20240823074137.13989-1-juraj.linkes@pantheon.tech/
Other than that, the patch looks good.
> + for port_id in range(len(self._app_params.ports)):
> + self.set_port_mtu(port_id, mtu, verify)
> +
> def _close(self) -> None:
> """Overrides :meth:`~.interactive_shell.close`."""
> self.stop()
next prev parent reply other threads:[~2024-09-06 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:02 [PATCH v1 0/1] dts: allow for updating MTU with testpmd jspewock
2024-08-26 20:02 ` [PATCH v1 1/1] dts: add methods for modifying MTU to testpmd shell jspewock
2024-08-26 21:13 ` [PATCH v2 0/1] dts: allow for updating MTU with testpmd jspewock
2024-08-26 21:13 ` [PATCH v2 1/1] dts: add methods for modifying MTU to testpmd shell jspewock
2024-09-05 14:21 ` [PATCH v3 0/1] dts: allow for updating MTU with testpmd jspewock
2024-09-05 14:21 ` [PATCH v3 1/1] dts: add methods for modifying MTU to testpmd shell jspewock
2024-09-06 13:58 ` Juraj Linkeš [this message]
2024-09-06 14:28 ` Jeremy Spewock
2024-09-06 18:00 ` [PATCH v4 0/1] dts: allow for updating MTU with testpmd jspewock
2024-09-06 18:00 ` [PATCH v4 1/1] dts: add methods for modifying MTU to testpmd shell jspewock
2024-09-09 12:32 ` Luca Vizzarro
2024-09-09 12:33 ` Luca Vizzarro
2024-09-09 15:52 ` [PATCH v4 0/1] dts: allow for updating MTU with testpmd Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a2490c-19d7-4ebb-90ad-36da0933c883@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=alex.chapman@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).