From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CB144591E; Fri, 6 Sep 2024 15:58:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A5CA42EE8; Fri, 6 Sep 2024 15:58:31 +0200 (CEST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id 896554025D for ; Fri, 6 Sep 2024 15:58:30 +0200 (CEST) Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2f66423686bso18677581fa.3 for ; Fri, 06 Sep 2024 06:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725631110; x=1726235910; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rVcce0gAeNdMf+/xmczi3D8BwwHzJX9lCcKoNSqZswA=; b=nfDvAS4yjsG1N35b1Rszk6JkZlszDcKMvtx5mK8U2VTEtUJTwVJ72UMY5zL+IgTD+W eX9f0wz/RDOyRGxhzL27iEug+t75FUt5EOCp93OX6AR+MVYg3CN4Z22uPFJpG4I+X55B pfmEnp3vayA/tg15IJMew4aOA5ZBSdqRP3btisJc6UWXewpkpuKtudjZp8Mhy7vYDGMp fD/6bdYJ3N7fH97qFx8Ic2uFFxjQl59FRADVM8K+ABlPDv6lre4h1/QNDXRtGBbEQFCG lknKL88/WtymIJudITr0azAfdhgQjgpcrBmXXehoWfqZ0c9N5Fub2ifsdAh03a1tOD2N 8C3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725631110; x=1726235910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rVcce0gAeNdMf+/xmczi3D8BwwHzJX9lCcKoNSqZswA=; b=soV2CVrPbBYwCfTemln/TsJI50bA8cAu8vjut1NPmVDQspBOB+2OfLtoWv35GSyc4E IEuQG4zpEXBKVccC/RNqe2i4QYBfwcidsHMAu7W34vDA/FVy2oebPyRv3IHmfcR5oJzb 6a2aQmyifCXMKlbkiGNh/KaB3VnUpi5vOmcC3X6HFOyVtvBlgXl8iA/LQJYCrdNemKCC XTL+2+wGAX1BwN/3Ppuzo047gmPXGqbexWdM27jtC5dQUHDYGg2Rij8kACRzOcZdbOxL 0HHJ5S2lnWalJsN6jnbJyrfgLLSwz6cQtpOwKsKwFSHRfTHBoT0HhnQMeTFvF8edy1dm 2FxQ== X-Gm-Message-State: AOJu0YwD7l3n+sgNbjBOqZWzB/4uj5jkCXBZy6AYXBUnRazskr/MemKo FfPukeR/CGgey8Y68KGqczZ8C2JTjvPKfMkUes38Pn9T3OXw+8II+wrONLokDiE= X-Google-Smtp-Source: AGHT+IGO0CH9uLsOVwIrdVTQYLk3SqnjuvzY9nywiizsbkDA9tQgj4qGRd/820kcYecINYyTOdsOtw== X-Received: by 2002:a05:6512:280d:b0:536:14a1:d645 with SMTP id 2adb3069b0e04-536587f5cd5mr2109298e87.44.1725631109647; Fri, 06 Sep 2024 06:58:29 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623c335bsm281244366b.179.2024.09.06.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 06:58:29 -0700 (PDT) Message-ID: <38a2490c-19d7-4ebb-90ad-36da0933c883@pantheon.tech> Date: Fri, 6 Sep 2024 15:58:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] dts: add methods for modifying MTU to testpmd shell To: jspewock@iol.unh.edu, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, Luca.Vizzarro@arm.com, thomas@monjalon.net, alex.chapman@arm.com, npratte@iol.unh.edu Cc: dev@dpdk.org References: <20240826200203.13560-1-jspewock@iol.unh.edu> <20240905142123.31342-1-jspewock@iol.unh.edu> <20240905142123.31342-2-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240905142123.31342-2-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py > index ca24b28070..c1462ba2d3 100644 > --- a/dts/framework/remote_session/testpmd_shell.py > +++ b/dts/framework/remote_session/testpmd_shell.py > @@ -888,6 +888,51 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats: > + def set_port_mtu_all(self, mtu: int, verify: bool = True) -> None: > + """Change the MTU of all ports using testpmd. > + > + Runs :meth:`set_port_mtu` for every port that testpmd is aware of. > + > + Args: > + mtu: Desired value for the MTU to be set to. > + verify: Whether to verify that setting the MTU on each port was successful or not. > + Defaults to :data:`True`. > + > + Raises: > + InteractiveCommandExecutionError: If `verify` is :data:`True` and the MTU was not > + properly updated on at least one port. > + """ > + if self._app_params.ports is not None: We should utilize the port info caching patch here: https://patches.dpdk.org/project/dpdk/patch/20240823074137.13989-1-juraj.linkes@pantheon.tech/ Other than that, the patch looks good. > + for port_id in range(len(self._app_params.ports)): > + self.set_port_mtu(port_id, mtu, verify) > + > def _close(self) -> None: > """Overrides :meth:`~.interactive_shell.close`.""" > self.stop()