DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>, <arybchenko@solarflare.com>
Cc: <dev@dpdk.org>, Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [PATCH 3/3] net/enic: support max descriptors allowed by adapter
Date: Wed, 26 Jan 2022 14:01:53 +0000	[thread overview]
Message-ID: <38aec558-8449-f0b2-2ab2-e52a6ad6ce15@intel.com> (raw)
In-Reply-To: <20220114031036.19052-4-johndale@cisco.com>

On 1/14/2022 3:10 AM, John Daley wrote:
> Newer VIC adapters have the max number of supported RX and TX
> descriptors in their configuration. Use these values as the
> maximums.
> 
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>

<...>

> diff --git a/drivers/net/enic/enic_res.h b/drivers/net/enic/enic_res.h
> index 34f15d5a42..ae979d52be 100644
> --- a/drivers/net/enic/enic_res.h
> +++ b/drivers/net/enic/enic_res.h
> @@ -12,9 +12,11 @@
>   #include "vnic_rq.h"
>   
>   #define ENIC_MIN_WQ_DESCS		64
> -#define ENIC_MAX_WQ_DESCS		4096

There are still 'ENIC_MAX_WQ_DESCS' usage remaining in the code, causing build
error, can you please fix.


../drivers/net/enic/enic_rxtx.c: In function ‘enic_free_wq_bufs’:
../drivers/net/enic/enic_rxtx.c:397:46: error: ‘ENIC_MAX_WQ_DESCS’ undeclared (first use in this function); did you mean ‘ENIC_MIN_WQ_DESCS’?
   397 |                         RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS);
       |                                              ^~~~~~~~~~~~~~~~~
../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’
    38 | #define unlikely(x)     __builtin_expect(!!(x), 0)
       |                                             ^
../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’
    47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp)
       |                         ^~~~~~~~~~
../drivers/net/enic/enic_rxtx.c:397:25: note: in expansion of macro ‘RTE_ASSERT’
   397 |                         RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS);
       |                         ^~~~~~~~~~
../drivers/net/enic/enic_rxtx.c:397:46: note: each undeclared identifier is reported only once for each function it appears in
   397 |                         RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS);
       |                                              ^~~~~~~~~~~~~~~~~
../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’
    38 | #define unlikely(x)     __builtin_expect(!!(x), 0)
       |                                             ^
../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’
    47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp)
       |                         ^~~~~~~~~~
../drivers/net/enic/enic_rxtx.c:397:25: note: in expansion of macro ‘RTE_ASSERT’
   397 |                         RTE_ASSERT(nb_free < ENIC_MAX_WQ_DESCS);
       |                         ^~~~~~~~~~

  reply	other threads:[~2022-01-26 14:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  3:10 [PATCH 0/3] enic PMD patches John Daley
2022-01-14  3:10 ` [PATCH 1/3] net/enic: add support for eCPRI matching John Daley
2022-01-26 14:00   ` Ferruh Yigit
2022-01-26 14:01     ` Ferruh Yigit
2022-01-27  8:07       ` Thomas Monjalon
2022-01-26 21:48   ` [PATCH v2] " John Daley
2022-01-27 12:15     ` Ferruh Yigit
2022-01-27 18:55     ` [PATCH v3] " John Daley
2022-01-14  3:10 ` [PATCH 2/3] net/enic: update VIC firmware API John Daley
2022-01-14  3:10 ` [PATCH 3/3] net/enic: support max descriptors allowed by adapter John Daley
2022-01-26 14:01   ` Ferruh Yigit [this message]
2022-01-26 21:55   ` [PATCH v2] " John Daley
2022-01-27 19:10   ` [PATCH v3] " John Daley
2022-01-28 12:58     ` Ferruh Yigit
2022-01-28 17:58     ` [PATCH v4 1/3] net/enic: add support for eCPRI matching John Daley
2022-01-28 17:58       ` [PATCH v4 2/3] net/enic: update VIC firmware API John Daley
2022-01-28 17:58       ` [PATCH v4 3/3] net/enic: support max descriptors allowed by adapter John Daley
2022-01-31 11:46       ` [PATCH v4 1/3] net/enic: add support for eCPRI matching Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38aec558-8449-f0b2-2ab2-e52a6ad6ce15@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=hyonkim@cisco.com \
    --cc=johndale@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).