From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0068.outbound.protection.outlook.com [104.47.36.68]) by dpdk.org (Postfix) with ESMTP id 256EE377C for ; Mon, 5 Dec 2016 15:00:31 +0100 (CET) Received: from DM5PR03CA0014.namprd03.prod.outlook.com (10.175.104.24) by BY2PR0301MB0741.namprd03.prod.outlook.com (10.160.63.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.13; Mon, 5 Dec 2016 14:00:29 +0000 Received: from BY2FFO11FD003.protection.gbl (2a01:111:f400:7c0c::191) by DM5PR03CA0014.outlook.office365.com (2603:10b6:3:118::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9 via Frontend Transport; Mon, 5 Dec 2016 14:00:28 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=fail action=none header.from=nxp.com;caviumnetworks.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD003.mail.protection.outlook.com (10.1.14.125) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.734.4 via Frontend Transport; Mon, 5 Dec 2016 14:00:27 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:1114; Count:13 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id uB5E0NJB005985; Mon, 5 Dec 2016 07:00:24 -0700 To: Jerin Jacob References: <1479628850-27202-1-git-send-email-jerin.jacob@caviumnetworks.com> <1480798539-13360-1-git-send-email-jerin.jacob@caviumnetworks.com> <1480798539-13360-3-git-send-email-jerin.jacob@caviumnetworks.com> <20161205102404.GA29487@localhost.localdomain> CC: , , , From: Shreyansh Jain Message-ID: <38b932b8-fe75-289f-b2a0-5dd0fbec60ba@nxp.com> Date: Mon, 5 Dec 2016 19:33:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161205102404.GA29487@localhost.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131254200279767558; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(336004)(339900001)(199003)(377454003)(24454002)(189002)(626004)(39400400001)(104016004)(86362001)(39410400001)(39380400001)(229853002)(230700001)(31696002)(38730400001)(54356999)(76176999)(189998001)(50986999)(36756003)(105606002)(68736007)(65956001)(81156014)(31686004)(47776003)(65806001)(81166006)(8676002)(7846002)(8936002)(356003)(33646002)(93886004)(305945005)(106466001)(6666003)(2950100002)(6916009)(65826007)(110136003)(15395725005)(4001350100001)(97736004)(23746002)(92566002)(2906002)(64126003)(77096006)(39450400002)(5660300001)(50466002)(4326007)(85426001)(39860400001)(39850400001)(83506001)(39840400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB0741; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD003; 1:ji9RGZyylir8BCbFKTzd1BxyBDdynfg36z6xYpkY3gj2x8IQxk4/TG52PtjgskAXAyGAfQgkCkJa9X8W2N25ehfjflT0oaEmr2yGEwGemmO1btibp1stuYL/mfitBBjP8hJMRtLteNBtHJ98rokhbLYa8Nu62Yvi1VW4Y57lxcYdyHifYS5SZjnISKE0wQn4lq8Wm7rH2KbYfUzNlWavWEThA9G35IvKDOP5QYnUHjz6SakgU01Lyzk39ritjyztKSGljjos6apjbCtZGaANUz1Q1Hv8Eh2JPlSy4yeKvb/nB7tNwivV/ARPMPC9XUihwITR6kCEYI0kFwRuh5RVHQV8oGNqGhxRhbusqDaCtC4s0k69/4cnJWPjZmwqhc83qTOa21024uYQVvrmfNa5PSq2qxe9Cr3tfGnFvf5pidUw6nSgv1ydp0bTlb+T7qBOFcOacRvM4+M/oENi8O9WUvwaWnJJak3OfHMYbgY/vaODWdrRa0YBDBVp5AJ7vDrY9pK8Onf1Dsjs6RFgusT/XaQeaj5Ax7G0qJ0V0qmw853P3A2c420GWl1WJlCUCmE+lO/aI0ZA0CKxdgsNxQbiIqTTytL7U+NRNZUy/nLogjpZh4mzh5houBfAnoTrLF9MSDEe1hur4aYk6nJvCgf10Q== X-MS-Office365-Filtering-Correlation-Id: 72a094eb-b1b0-4dc7-0ef6-08d41d171158 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 3:Ygz27189X/hvEo5af5s2K79IRc77LmDs8YtZUJyw7nKjp+YtOBY10J21oKbwhfjwq6zVUr9q7O7J0wASGepykf/MOafzEcoo1Nt6hIu3hSTpZVzNQ8xMdIOgTzQ2IjBex4hohTvZF8HB3fDSZuClqEt2R3NP/jP4/6fB2ulmmEVl0lU/NRtVQXllpO3AgmUeZvQjG2G0kgdiZ3YJWsdB1ofgOKOBDfguYC7IiKz6YXU8Yt3vQ9a4taI5B5FFSwYdNxyczzgibVfrIgvya/RTaz0FYTm0cdAcmwKJ1tS5ixCvrT4StbrUxB95dTquVWemU11q1Hx9l2gVuaEkbRfioRKjFQp28w/zn7nIS4VTXojyozrAOx6uqxN904VsDyk5 X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 25:sUp8QJ/dvxJAC2mKse5hukNPlnHqp3dPf6RJ1u7vf4BCpj5MAwkuE+15pk3YmuZ2Tk8aIZ1y7CR3NoQCfOUhbcaQEgVliyyo0n+VhUYE+wwfHbtz615x7MHbK0eVlSXbPXvhUIJui+bU0oPe9sIaPcR+P7Di9gtxJjLH4dVkCFSsfyfOWn0WSTLVHi53e731LFCUPhGkYPHGA9XTopRlktMgUtQ9CIIEdX95YdvJbEjuVT0Q68Kv020iPcbATyv0N3VlD2LztvmhLXgEH7HP3vdqb0LHEgDJuE9RG7fN2DAmGkxk5ziyqDXkP/+ilOGOLy3F8Lc73eUpTLGKZAyFEuPGEAELdEo8Ufc5VlxzwjhpuEA1fwUfaK0gpGC/fYnu9ZQLTo2reCEMbb6zmhNEI0jEC15nzmq2KsAv/D8bjUHswnIoTr0FpFGn5ZQvadVhEzJYtFKtQYH3voTcIA0uyhbM1SqMr6+HmG1HgH0uaHvE0BLbiK+oWl17qi/r8lzv+DTZ/AgNOFSLR0BdbAJyZ86rIbyGsYtx0OrNy21YE5rU/Kxw2B7/naldWQ9VZu8ThQT842JGOfrHFZP29bG7JGqpg5Daq+ym5AW8NQ8OhHtVSmN6AIh2bdmNnpYRocJ3OzGGQoGmAHHzCEVRh2UKkDAlfkcbuSIxw1yT8k5SMXArrrN0cJW9PiXHNl9oyNe2BYBSe4Q4huU1MxsKB6gXQ6K2meChEDE148h22lcIzT92UMOPfylMLQkaEHcwnfk1aOS9gKra97vrtyXpBx+9mieFAxvXRJhH7v4IpfbMD4Mqob2l0F2OfMXjltT2KGxZfMiNaBYP5I7P4PiWBs84jA== X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 31:6GZsN2mzt93k20ZDCoBca0j+xKpUVmKWnxLWR0XTUfN0ytRJ2uVgCbOUH/9FPGh+B6ow8vg6AGOT1b6nAk2Px3MTLyOgchfO9ynb5s43cmHKi3EzDetXHGxo1eilfH1I5YIOvNdB2Kvqq4B8D2V3Qs+JCJc1QKQ8QFUxnXlAjCG3rKWlsWQpq+vgI3HEb4TJYe6+XrLfjXYxvI/RiBzPi97hiCYICd7xohfWrwKlNhkgEO9Hdolj0IK5TGuqUH8cMyx6WC2HIBvuHHXNmOz0lw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13015025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:BY2PR0301MB0741; BCL:0; PCL:0; RULEID:(400006); SRVR:BY2PR0301MB0741; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 4:jUPUUFJaPxpxErGEkNKJMDSMmFmTMWTCWY30buudahCP+9eS0pfrA+/adRUWJlfXX/pSCC52aRMTHKbSTI+YL6zXq7t3uLww3YgwPj7NVExQST4bm0JYmJATHukujlwKY9yRfiXk6kU6alJBDRkwfXAPggK5M0UpI7aaQLTCjLvMWTjHAwFZzRxrRocvQGHyetKoWGRczrXPJ+ayf3llwNnFbc+NrzUmm5+XA0xWylkJpPSkv2Nt/fEQORNB9kYbo8GrUJMD1oP9GZ4GdWJ7PibdpS3M3HqotMXvMTrLyCIBBiKTIdy/Lg1BAqv32YJ7jr0X35BZWuweJxDY+z6tUjwXMHwryp7qhLtisfWzk1ucwqBlnVA4woaCnuERfi3uvH/WYlK3zqgz5VG2YRjSwiqGbLv90ikbim6vn5x9fs3ddrUFVY/aFWGVuiuVbzFuO2eskhLm9r/coMZLFq6j4tWM0xIGiLc0azr93q11oDwG86h+Ya6bWprHpRwVFproXtTVqK1eYmLwMwECFBO3kuhx72fEjzedtsS5LntoO+TQAC5GP5D/rqWFZcMGoEp6rfGYs6YIgHh71QotRhEz9NUr1r87BAnlROVkqSIb2L4xpIRd6LQVrzgp6E8QSgkzC64rLfNKiwaG3n8VHe0lWWAv49hN9K1iFR6JFGsX5ZUia7UTy5tUP58WEyRy9eDYEk0MO8Pt3WQXfPAN5d4kFutwhSG0muItlA+chvPFawDm3nd1r9uXiXcF+en3uf8E X-Forefront-PRVS: 0147E151B5 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0301MB0741; 23:B6dYRCCutk4CzShGdjz3ElpkoG4yki3zGNY?= =?Windows-1252?Q?WYVCOFQa0yGLqyKqYXKiCxXwJbhwpO4+FlcmOwIqy1E+qfgShtNBhM7W?= =?Windows-1252?Q?1De7bryINkxReII57Z4I1uliRRwCseI8dsps+rNDSkcIFrdhlP7nFnLK?= =?Windows-1252?Q?AAFq1QWwotT+vIknAfFXiompf5oyVIW+Wj2KOw40KkuACqEgZ/m4M7+M?= =?Windows-1252?Q?64Gjqvo3oF6pr8PS3O5srn6Vv2OQK+IcXHGzpGfZaUqG3x6r7dOv3Tis?= =?Windows-1252?Q?REFgm/LMFKx1NIrP5kwNv606f0Ji5ReWFNCFcqTluM7p7U99JkSBOgCc?= =?Windows-1252?Q?fCHt6xjyl6ubUX/5xNaNhL2eC6FY070c4Yi7nHtWICL/A6idjWFkVlwF?= =?Windows-1252?Q?FjE4RZbJ9J0bSQbXR9f6pRDyaBZAuOtmg5YjebNNL83JSWs3Pzw03iOA?= =?Windows-1252?Q?6Jhf865jw+NS2mDj+FXtloirfIJSiXtZY8z+ezHIv8XYwh38Bk1DaoV7?= =?Windows-1252?Q?s8EMtgSHmftIgMpQAIi+aNJmDqCPfmavcE/E4VoXpZh4iVqwA61f3aW0?= =?Windows-1252?Q?N6yUB5OHAr6C6owepLat67J7k6ai6szNEaKvhWDWNBQ1oTzNzst5M+mC?= =?Windows-1252?Q?SMHY06f7cxZXXhxFHYng4EWGDFtDiIIEg54KUuWTM9z/nYFUAdqhe3QE?= =?Windows-1252?Q?y68FzT+45h6oHAhXxk6iZ22JpbDONPtCdn5bOhidfdY85HFWQ/gJX4eB?= =?Windows-1252?Q?saMHiMYOXNJFjxKmrmZkj2cMkIynl+3S0FJHUK0xfG02b+pZlqNneYP5?= =?Windows-1252?Q?/+CEpeTk42qucdExCLvqkLehtNNHRc9rsPI4NwvtyHG8eLXgkxwXj+Jk?= =?Windows-1252?Q?4q1RIsSuzXEnEZc1cWbxfwPgMRw+GWlqun0jPOtQNN8bSCGQknHVvmLz?= =?Windows-1252?Q?agr1c2mGg2515mjSegsUjbftANEUu1AfPvMljhOBR4Miuv4PmrloFq0L?= =?Windows-1252?Q?PQscSXwozZFX5buXE8OmHPNm86WsYLxlDsCuJMNEJ5yo4T23272OfVkR?= =?Windows-1252?Q?ehYPaXwNJdlYrW74mkDwvxLfaFyS1LUzOFHzURICgs/2HqCpEcjGqHiW?= =?Windows-1252?Q?kVguqFXvzmQ+Mi/BHwmyhLC3y23ahAWpUg4cptYtMrZ7m327WNWtcsKE?= =?Windows-1252?Q?JRCeE96HcUq0D89v0sRgw7D5U8f0IRix0x0at9ehwpxmKrAx+KxRdNiT?= =?Windows-1252?Q?M/hnsYSFSoFt6cRrUL/J85gmHmTVcI5iINElZrzdbxPWGdS2vMwUuJ7L?= =?Windows-1252?Q?s99Ap1LcpQ+B/Hut3XC5F8WohahR8Lfdqo6PQAWfrlBK6ZU8UqOvQUGG?= =?Windows-1252?Q?PPALqOwr/qIZIPRZZsnuvrl/Px/HN94p9PX877oo6a1qmSQcAN7vR/+1?= =?Windows-1252?Q?hhqW/YbNOEgSEHgkfKhJS6qmq6kFp09p9j8Z3Y/CzkOkaye3ZHxpiYXN?= =?Windows-1252?Q?RO+a4utFcxiR/8qZyBT4W74j/GSy3zaZyEm85MyJiVI+j2c/Z/vlUe9V?= =?Windows-1252?Q?lI2tmE3gZwJ/f+wsTg1TSlPFrt46dtj5fQA/F0Ke9k8/ZdUjI+fsTtoc?= =?Windows-1252?Q?WhUt+V3gA/woQQwWvqaA+9cDUqmpTR1cd5lCb7vimwszb?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 6:VyU4TE5pD7bguMXG401RAX6daS4vEESYxm0IJKStbPI5Ir6gVo5i0FdAORsRMvTgbIGoICA9rvlx+hDKjP2/Guh7TnPwhrbGXPFfY8YhsPEkecWjGZmpG5I0OrKlCf2SY33cUWdgaxDY9HJcABSrXabbOwGJoDlpH9Pv7JbYrSeAjZ0WPI39OjRFNs0LzcQzAfa2bILfSfrCaF+Hn2DzL3c5C9a4W58EXDS+AXKKcoKorYmAKSvIvEynmftKO/Rg2IjVd68VRCMmqXbJ72lCzMiWq8CQXrGdSnSI+spfWYZLOlqk+Cm5B2FJ0C/H4StSWpG5M8nV5JY8WYffR0Fb9xx3UAfKOO5i5U8fKwvX1DagdUPpPoqDsRgKzYdP1ftkW0CNbBQjwg7tgT62JoiAceH8VDO/iSsf06K8lXIk68TGQVB52i2NYtIloClFEXlS; 5:9YHNe9cgxx1VAbRrMUKDoaUsfZ8miyt/FZ84NBNHf6w1oQB85NB4hB7hpgOdKZZzDPJ4OktoOWjoHv4sf67/DE7gMbmZd1ghqd28e9G+CMY6LTJo+PA/Jm2YQCVUBt9V60Sf1BWBZi7uLUSPNEfxdV2J2qez+CR1d0Fo4Xw6bswwgpIUCNVsTxJfYUMo/3Sl; 24:bO++ezjwRSJf4qpYjHzdAW7DtDbmjaddVVS6AAdl2A5W3Gr7jB+BLmjPmQmY+OsKu4Qre8nkki6/0a9o1peV3WxfXKAv5tnnpgY5PwxAQg8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB0741; 7:2yVnDARmcxwCY2votS5prAIt8NAZslaEWbmE/jO0Uh5OyOY+C1jeLldkf48FD1uYLKgCseznBIPYeNC0MgXeu1/AsehejDnjIU51qRU9mA0gtLJhlj4Qeb0XB4VW+AjglUOYCCcay3HQzrmLkkMSJ3zHa1/ErWLUr438zU98ly23ioF26A54oBAA+6yct8L6YLmcDtclUyVo5SD/Y7RBaXYA1fR2vaGKRAmZac0Q/4GdCBzd2C3wgxUH3Ztxm4HwXG8M8aVJ8rjjei5M5OT7nLDqxA3SNRL7j6DVh+WNYVgyVK6St7/mZ4cPZ9eGvgbnc2Y+BgXkxPaiSGCW78Pfi8oz8XQk1hUB1s/InXHj3lt1YtszPBAASNIrU7OBDnUz+fpiWIiNdrw2h1LKOBFSV6CKC7cVJOdslyX4r6lNmQKbMnYHi6htBpCh4368SuEWJHNl3KnvruJE13YdAiC7fQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2016 14:00:27.6179 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0741 Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: rename dev init API for consistency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 14:00:31 -0000 On Monday 05 December 2016 03:54 PM, Jerin Jacob wrote: > On Mon, Dec 05, 2016 at 03:42:18PM +0530, Shreyansh Jain wrote: >> Hello Jerin, > > Hello Shreyansh, > >> >> On Sunday 04 December 2016 02:25 AM, Jerin Jacob wrote: >>> rte_eal_dev_init() is a misleading name. >>> It actually performs the driver->probe for vdev, >>> which is parallel to rte_eal_pci_probe. >>> >>> Changed to rte_eal_vdev_probe for consistency and >>> moved the vdev specific probe to eal_common_vdev.c >>> >>> Suggested-by: Shreyansh Jain >>> Signed-off-by: Jerin Jacob >>> --- >>> +int >>> +rte_eal_vdev_probe(void) >>> +{ >>> + struct rte_devargs *devargs; >>> + >>> + /* >>> + * Note that the dev_driver_list is populated here >>> + * from calls made to rte_eal_driver_register from constructor functions >>> + * embedded into PMD modules via the RTE_PMD_REGISTER_VDEV macro >>> + */ >>> + >>> + /* call the init function for each virtual device */ >>> + TAILQ_FOREACH(devargs, &devargs_list, next) { >>> + >>> + if (devargs->type != RTE_DEVTYPE_VIRTUAL) >>> + continue; >>> + >>> + if (rte_eal_vdev_init(devargs->virt.drv_name, >> >> The situation now is: >> rte_eal_init=>rte_eal_vdev_probe()=>rte_eal_vdev_init()=> driver->probe() >> >> Even though I had suggested this, my intention was to completely do away >> with rte_*_[v]dev_init as it is misleading. >> >> rte_eal_init=>rte_eal_vdev_probe=>driver->probe() > > IMO, We don't need to remove rte_eal_vdev_init() as it is an > application API that uses to create vdev driver instance.Moreover, > change and removing that name will result in ABI breakage. > > grep -ri "rte_eal_vdev_init" app/ > app/test/test_cryptodev.c: ret = rte_eal_vdev_init( > app/test/test_cryptodev.c: TEST_ASSERT_SUCCESS(rte_eal_vdev_init( > app/test/test_cryptodev.c: TEST_ASSERT_SUCCESS(rte_eal_vdev_init( > app/test/test_cryptodev.c: TEST_ASSERT_SUCCESS(rte_eal_vdev_init( > app/test/test_cryptodev.c: TEST_ASSERT_SUCCESS(rte_eal_vdev_init( > app/test/test_cryptodev.c: int dev_id = rte_eal_vdev_init( > app/test/test_cryptodev.c: ret = rte_eal_vdev_init( > app/test/test_cryptodev_perf.c: ret = rte_eal_vdev_init( > app/test/test_cryptodev_perf.c: ret = rte_eal_vdev_init( > app/test/test_cryptodev_perf.c: ret = rte_eal_vdev_init( > app/test/test_cryptodev_perf.c: ret = rte_eal_vdev_init( > Got it. Have you noticed patches from Ben which actually merges init and probe all together? [1]. It is for PCI right now (and that too would break ABIs, I am assuming). [1] http://dpdk.org/dev/patchwork/patch/17206/ > >> >> should be the ideal order, IMO. >> Apologies, I was not completely clear then. >> >>> + devargs->args)) { >>> + RTE_LOG(ERR, EAL, "failed to initialize %s device\n", >>> + devargs->virt.drv_name); >>> + return -1; >>> + } >>> + } >>> + >>> + return 0; >>> +} >>> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h >>> index 8840380..146f505 100644 >>> --- a/lib/librte_eal/common/include/rte_dev.h >>> +++ b/lib/librte_eal/common/include/rte_dev.h >>> @@ -171,9 +171,9 @@ void rte_eal_driver_register(struct rte_driver *driver); >>> void rte_eal_driver_unregister(struct rte_driver *driver); >>> >>> /** >>> - * Initalize all the registered drivers in this process >>> + * Probe all the registered vdev drivers in this process >>> */ >>> -int rte_eal_dev_init(void); >>> +int rte_eal_vdev_probe(void); >>> >>> /** >>> * Initialize a driver specified by name. >>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >>> index 16dd5b9..faf75cf 100644 >>> --- a/lib/librte_eal/linuxapp/eal/eal.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal.c >>> @@ -884,8 +884,8 @@ rte_eal_init(int argc, char **argv) >>> if (rte_eal_pci_probe()) >>> rte_panic("Cannot probe PCI\n"); >>> >>> - if (rte_eal_dev_init() < 0) >>> - rte_panic("Cannot init pmd devices\n"); >>> + if (rte_eal_vdev_probe() < 0) >>> + rte_panic("Cannot probe vdev drivers\n"); >>> >>> rte_eal_mcfg_complete(); >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >>> index 83721ba..67fc95b 100644 >>> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map >>> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >>> @@ -22,7 +22,7 @@ DPDK_2.0 { >>> rte_dump_tailq; >>> rte_eal_alarm_cancel; >>> rte_eal_alarm_set; >>> - rte_eal_dev_init; >>> + rte_eal_vdev_probe; >>> rte_eal_devargs_add; >>> rte_eal_devargs_dump; >>> rte_eal_devargs_type_count; >>> >> >