From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20056.outbound.protection.outlook.com [40.107.2.56]) by dpdk.org (Postfix) with ESMTP id 03EE11BE93; Fri, 6 Jul 2018 07:01:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xPSsPsbQQtKQXuwTe41TAUm3MkAYkFk0RouCp+X5M6c=; b=VYwYEzN2JN0ak0E2MGL4AW5yf2IALl1aOrpNGQ2qp9UVUQT6K5FAnmUyvDWs6CHhXV1sG8JoSxi0+UsPoqA+fOU3Q1jUnUFNaqg8wUfWkA0TvDH2Xn9y5tzXwi16RMfVtok8K3idMu/Lw1LGtIXDjvRcGx2Sw9bQVsdhJSkDBDE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by VI1PR04MB4687.eurprd04.prod.outlook.com (2603:10a6:803:71::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.18; Fri, 6 Jul 2018 05:01:31 +0000 To: Hemant Agrawal , dev@dpdk.org Cc: stable@dpdk.org References: <1529574244-18997-1-git-send-email-hemant.agrawal@nxp.com> <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530697431-1244-5-git-send-email-hemant.agrawal@nxp.com> From: Shreyansh Jain Message-ID: <38dc46f1-436f-f482-0456-b4b56d1da4f6@nxp.com> Date: Fri, 6 Jul 2018 10:31:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530697431-1244-5-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR0101CA0005.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::15) To VI1PR04MB4687.eurprd04.prod.outlook.com (2603:10a6:803:71::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d557d1bc-4c72-4c6c-e52b-08d5e2fd8a53 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB4687; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4687; 3:jDusnSz8bSaU+kfoOyqPCZTdNA5ptgFIcUHUp7Jwv3kXFjJz1xiw08KdnBtpJPhV1ac32OWakeo9Lyh9B5kQFtqOX65nTPnVBD/PMSVPe/VaKNXRI8QJ8Kca8Q1SBETvIUIKvLsAyXG+UtUvbtsedzQCVw8yRoUAe3CiX4xA8m2a1g5Sp7x4tBPr7cmo9bELiYUrxexUEVH5jg6n7l1rTCcdGkE9euOonHLvvcfNpC82xVxzqV2xu4FDHgatwIgI; 25:mtBi9Vt0y2571qrEkqKdRvIGxPhFFEbK5HqOtYdKAKzYWLyuZQ6H4RB31gVrBCuA8knBPt9s/SqIf8KijkGVQL8G743rU3txXNVSjhrGsy2rjLUjb4QWDPChQQankjdKrh6nCK1MnukRkL0qK9YCPW31JAeO/0SF8ZQvgnvejPOUR//I5WP1gf5j2Korc7VWKGt+TjQiiXmcXbrGx7rQtRGahHl+vY4kIKrtu/2cD+JAJUHqKb4thcINgXVaapH68ZUo+n32CI5W8YIUlmH2iGzxjyBzOj0BEo3b6ZgT1tQYs/wEyyH24KmvV7Vfh4z04oEpkkYnsvNwMz6LEYo/Lg==; 31:T7b9ycRkbrnwsapgn35cUfiSmzx+UYcyziqMKFIoG0oem21Q0qhmPwiZUJ0xAX6dwdOx4yj0cG0nVkrux8m0WdFUlDf41u+NintQkCa4BUxQsDTFl0IRKMbCAhCJHqRwMnXIWMoNt8V+8ARBXKZVlFPl+CU8w0cZTmFetnr/uwpILQVnw3CloGXcgCCtmgvx4d+ezt6xE/eRx5Ay8AI1Sx+bN01NZGGUovTDuS10cBU= X-MS-TrafficTypeDiagnostic: VI1PR04MB4687: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4687; 20:lfg8Zm8bszME2ut4LPN9sKNrpW2R4QGpbpGwbgKFsrxrYs8xZnGewTGkmKm2jsWECt8FJkRisfyIZHptj8N+Pi9CYXoMHuJAS0FBnD3Qg40ognenzXUoi0kIsq1zyOCEmgN4R/if5jEML9+g/AiL4wSfXgDhopp75EzD8X9oGPGD9CmMz3j+BalQZLoSUO8/KFY7jFLcja+DudQTC/pvskd543crcF+PCFFWICf7c/chzK5J/UdUgo6R1RRe/409j8F4RCdedkYcI9Yw/R8XExkTIuUuuu9TUw9N+IX0yDTrSByr/VnM5bw9hukpRMLyq+4J8PcdNQi3jyeXVQOrzCsHeYYDibfHAXWn7wqHWizPkrJ3hSW6k7vRCysPWSf8ttMtkMe4ZR+0HRLsKxWrXArngvg3NpcrC5qapy92Sjf/eyyUJTLfY/8mPBtjIE5fWBSEkr8rGai8COq1k1rmRk4ZeUfG+ySx7NLgtNrkbH24LKaYDrVH1poThNYEobQe; 4:jurNdFDhJAqomyZJZjA3NLnLoGbGUiY+fppe3Yf9DznWS3Pv7u/RDyCDOYHM/A9tpnzDLzsUNhDPNtU6K/RE6ChHWNmkCyYFkcbFoRKuaUYzvdu/h5jE0L1UsPR60dH84/fi8i1KwRVnDcs6/oU4yEeZqB8cQhc2Nf6cFNBQ+5HFRaVEOpJQ3dpQpaGLh0/N4URxxp0XzyKHN8PkcyHIF6xbBaP+Y5dP/xRmh/lA9dU/HxMd4mU4xawZg6jxsOqY1UhNLcFpE1+u6Eu45NJ3PPfzzHiMstnjTHQUNVs2w45/uasX5CvoQfAFUEOLgPEy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR04MB4687; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4687; X-Forefront-PRVS: 0725D9E8D0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(366004)(136003)(396003)(346002)(376002)(199004)(189003)(476003)(486006)(97736004)(11346002)(44832011)(2616005)(446003)(956004)(86362001)(64126003)(25786009)(68736007)(6486002)(36756003)(5660300001)(53936002)(14444005)(47776003)(50466002)(16526019)(26005)(77096007)(31696002)(65956001)(65806001)(66066001)(186003)(67846002)(386003)(6246003)(478600001)(58126008)(7736002)(52146003)(55236004)(23676004)(76176011)(2486003)(305945005)(52116002)(106356001)(2906002)(5009440100003)(450100002)(316002)(16576012)(105586002)(4326008)(31686004)(6666003)(229853002)(81166006)(8676002)(81156014)(8936002)(65826007)(230700001)(6116002)(3846002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4687; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0Njg3OzIzOlpHNlhuWEc1aFZFa0s0T1ZMVmQzVGpxZGtM?= =?utf-8?B?emlFaEsyd1pMdndUbDFXRUZ2RFRDanYxSHBlWUVOOC9RNmJrTDJyVGpFa1RQ?= =?utf-8?B?UE85emlpWFdmWW1tTWxJK0xzUWc2RzZOeWpZOHUrN05rNXVMVFFYUFZSRzBB?= =?utf-8?B?RjlkcDRJcVBhWDdob2JHNkdObjFYbkhVMk9POWErb25FQ3VRblRKVHNWNkQr?= =?utf-8?B?eERaMDAwNndpL01FNkFvSjBHdkpmZGRXQlhWWTh4bXpPWXV6UHg1MktQMldw?= =?utf-8?B?NmtxT25OT3hNQXZVSWZsL0w0MVBLRTR4ZTVJMFg1azNueWhkR3BxdjJqbXlU?= =?utf-8?B?ZVo4aEZ4S0JPNU5rQkQ0VFJNcCt1SkFScndGQjQxRDdvWTdCdnowMXBrUDJI?= =?utf-8?B?SjRqS0FHL1E5ZEFRWjJvRjVMakNldkhXMEZXajAyQ2U2bHdKTE53V0h6U3ow?= =?utf-8?B?ZE5oR2E1MVJzRVhuNXFaSi9EdzlDTURWRVZZd0JiZElXTGFFRzgrcm9sY0JK?= =?utf-8?B?aWVlVkxNbm9Jd0p2MmZQaTkzRW9mdXJHK3ptVHFvaTZLSWlvS3VCVjZWOFNM?= =?utf-8?B?RHpNNmVBSzlEdE4ycVJqcnJMVUE3cVl4dExtUFV0QjAzbnZRUjFDUWVGQS9P?= =?utf-8?B?c0pLay9VWTNyNGJ2R2lXL1JrSjc1THFnRDB3NGtWSTh2MHRIMzliSWQwS1Uz?= =?utf-8?B?dUJpRlFhUmR4MWFNVHU1MmdaREFPcHVmczVqekdWODlrdXFLaVhIOFpwa3hW?= =?utf-8?B?QzZnNDdyZHlTQVFpVEFTN2tiOExPMzJqNjY4SjB2SStDaGpTeFgxaytzRjdQ?= =?utf-8?B?WUVDdmlrQVpjczNSUVFyWTFOYnIrQkliODJxYnViOVlkejUvQW5rNEkzNGlN?= =?utf-8?B?NWtITlpBZzVWcUVYVWl5Q0V2bHZYT3p6RUFzdGNERXFrUkN1VFNDNFFvSEpk?= =?utf-8?B?NmhVVUxXbjZ2cmZzVDREcTBsRTZET3F5a1l2WUE2QUZCaHNGMURkci9JZlVh?= =?utf-8?B?bEpFQndlbnR1VjZSaWtjbTJnd2I4aWZUTDBPenY2Sm0wMlBBdnZsK1hqOCtl?= =?utf-8?B?Z0pDNzRubjlPNUNnL093R3NCcVgzMllRM25kQlg4dXdGeVhuZWJnQWZjY1pj?= =?utf-8?B?T2o4VEdhV05HSG81RXB5dlByWnVPZ2lzNXc5MjE3TjVmaGVWR0Rmak1ISE95?= =?utf-8?B?TUZOd3RGTTE4VlV5U1VuQUlxdGFtMko2L3ZDamJXSm1IQmwvUkJuVWdyUVE2?= =?utf-8?B?Smg1eklvK2ZLeWllYmxCbWNSWEw5QzIydm5KczltOHhVZkw0QVhpek5OSldm?= =?utf-8?B?QVk5dzJraFZrZURnNlVCL0x6WkFEdnJhN0QvTndiQkxObjB0OEJPcS94MzJX?= =?utf-8?B?QkRWQWNnUDJ0QzIvZXM5T29odzdzbDBxeTNkRlJPWHBpMDg4MUYyRnFZaExZ?= =?utf-8?B?c1JRaGpOWitaQ1JVZ1Z5bjhPdXpac2VmbmpGVEFwMHp4aDA0VmNrWVMzUEgx?= =?utf-8?B?eWtPV043ZU1kYjhIMWlOSytaRldCU2lWOUI4a1B5T0t2MkxPMERDalF2MGpO?= =?utf-8?B?MGVaekhRNDIzeEovQ0hyeE9oNzMwY0xaYmRzZWZHSktFSHRuU1BHb0VKdk1S?= =?utf-8?B?TXVob3Jid2RkQWNhTlVreDZJOXBlK0VJM3ZEQjlXcHJQMmN1Z01nQ2RtWWg2?= =?utf-8?B?M0VWUWhOZWJWYmN5ZStzT24rZ0RVVnc5b240ZG4vSnY5NUthOE45UGVEV3kr?= =?utf-8?B?SS82YkRSaXhGclZ5eGpDRXNKWHN3ZldURFliS0VKbU5Pam5YSHZXMlBqTFFl?= =?utf-8?B?M0hReW4vR3NCby9jaFFEbEdYd2xtZ004bytuT0tTNDBRWTExdjZJcGZQWE04?= =?utf-8?B?Tzg5L1V2NlVKMVhDQUk2Rkl3QTQ0TG42NTFyNjBVZ3ZHdk9oTXh2MDJvUDdJ?= =?utf-8?B?VTVlclJpUXJ2aHhFYlo0SWpieFZNak9CeFAvdDh6Sk1mQUN6SCtvK1hXdzI3?= =?utf-8?B?N2dQWWdtOVpEOWljeWNxd0Y2NkQyMnk2SExCVTBNYkdVOU1rWTdieFRoZ3B4?= =?utf-8?Q?GtIdojQrLPvI51eyjEPFgNiuG?= X-Microsoft-Antispam-Message-Info: pM4CA34oVSckAodhTWqNTjg5znCdzEZB2neZfxBlNVb/a0eOgYa+Z7/Cn7i/GY/5BXUWdnRtlxkHYZ5XyuSabZUGt7N3BFQw35VTryiXEfWWi7R/udYuipw+nOndmlJLYY6vfGHP9eGJmKnfC/KVQBX6ybQZ7CtJoHoUlQn2qcrZF4ZMw4+6ZPirptzMVArPubAdpvvwnqZUxjNfpfkAHOSDjlKZUvEdNJlbBJ6ZDXvkavfEk/2E8WyBiFSGGCg56D5h0zoLgbSedJxRoe7WHZ2OqaOBeM9PNNIrNOiOvjsf7oQSv5mewJGK1mlF72ymTDASsQR9g8suo29YnHgPSXjWEq1xI7N8BEMRZfQNWQw= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4687; 6:yY/TpvfIy0QE02lcB//wpX35gEYt516hPsHdpy6dP++MDjMff/YiWNDP7cy8kqYTZQnLWfgSIUpDyOvrw+51FJQ4WdOTFJjJq4PwRcOgNFqdpAXwBVQ1ORN14ibU2p6B7kD+nSE5CxlAjiGwlIAnKzbDi57tZxikjAAERSSuge3mrtOMMku9h4lIPKroCcoqTOB3Zc6ZEoFNSu7KH+bDIqYmlcYZ/PqV5/FA8tHZi6CzaNjufXHGNWy39ZzFCISkmlo+ZPhp9Nc8CkwCLQZRN1a+XblEFklpDjoabhbpxCdJaQk6PnkNCIbhyGVo7IHaJNgUXtlofzNXrfKTkJyB/oHNsrJB2UTDipRc97l8qLBgq3LGKxdXJhHLRXjnPMXcsezltwdpCbyYvoMnyxuUjJzvzYhzKzkLwxnYigZiQFkCzlwuDmQ9wlaeOWok25G29P0J87d1HOMtu6zmT+HRKQ==; 5:3o2lCPkcknNzkDTM8X13m+CfkC2iWB+LwMCgnyxvxnbTk16pQj0E7ZrGAR6e/AD4rDb27NI99dqW0tlIrnwG2QAi/1KsdZhL0E8eKQYKAD5C5lSBUNW934gLgsHcxTwaPis5HLNS16vCDTOG8pV3KT+1sdv1UAK/rXAl/HPLogY=; 24:6pDsQdw28N75focB6p18IGdvYmOSZKaZ4lMeMz2zpnQjui+ZMEBMHaSj8yELb1XWgozwaNNt3rfX1I3EOkg3zbbCdYPc1vLxuAu8+KuLEGk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4687; 7:bzE53kSI7pbmHpO9NCOg9s9zw5NTae8XA/tqkJXSmVkICDNVG5hvoR2axfojsVihTAlvvjTvWGiH+2XTTn1KLQooDSRIjYi3U8uBHYc8WXbc8vLH0I8Y0JZOEvehTGzvNAsTLXOigESWr0Jsd5Xrsi5ucAJNWKApcDLURqKe5Em2zi8CI0bRb4dotnkf5ZtnJ8lzBef63bdKWnxX8ogjaSJ0IxSUynYddBN+QnbUMRr6qvMz+jTq1fwvQiUPooBV X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2018 05:01:31.0962 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d557d1bc-4c72-4c6c-e52b-08d5e2fd8a53 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4687 Subject: Re: [dpdk-dev] [PATCH v2 05/16] net/dpaa2: fix the prefetch Rx to honor nb pkts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 05:01:39 -0000 On Wednesday 04 July 2018 03:13 PM, Hemant Agrawal wrote: > This patch fix the prefetch rx routine to ^^^^^ fixes > set the next prefetch request to the size of nb_pkts. > This will assume that next request will ideally will be > of same size. Incorrect wording. Maybe: "It assumes that next request would ideally be of same size" > > Fixes: 4bc5ab88dbd6 ("net/dpaa2: fix Tx only mode") > Cc: stable@dpdk.org > > Signed-off-by: Hemant Agrawal > --- > drivers/net/dpaa2/dpaa2_rxtx.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c > index dac086d..311861c 100644 > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > @@ -447,6 +447,12 @@ eth_copy_mbuf_to_fd(struct rte_mbuf *mbuf, > return 0; > } > > +/* This function assumes that you will be keeping the same value for nb_pkts ^^^^^^^^^^ Ideally commit messages shouldn't have personifications 'you/your' etc But, it is a trivial thing and I leave at your discretion. > + * across calls per queue, if that is not the case, better use non-prefetch > + * version of rx call. > + * It will return the packets as request in the previous call without honoring ^^^^^^^^^ requested [...] Being very trivial comments, if you send the next version, please use: Acked-by: Shreyansh Jain