From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 29543200 for ; Tue, 29 May 2018 12:38:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B76A321BED; Tue, 29 May 2018 06:38:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 29 May 2018 06:38:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=v5jzOB8joDtXS85RReCyQG3WX3 LxYyJDOvDiVQM/A8o=; b=cPwanpOoAYKbX5sAHQzpQrzgeDpUTEmME1amqXE+zv lI7ZRXDh/q6A/aBIgW60rhD1uCFLPOBd5zl70wBNcV9S9I/eznHLYBUVhQ49eyf6 MvpzsVYyF4HD20P9RImiUBZpRpo/gZmr0NZwTU9C5+n8zwSHBIWjp0hli7kYojYQ 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=v5jzOB 8joDtXS85RReCyQG3WX3LxYyJDOvDiVQM/A8o=; b=cQL3Wv47plylca9AYWNZnW PgrbDD/jIzUO/araJ35emiK2udxWuXGmreA0lhwbvBwaZXwfni/PqNG2Cm4beDFC Lru9pS/86+602BCAX7KG+8BPcTdpDbRE0oLkw41TU7A/s+86mOsHnn/PNfNCQWjY 2ZTHLDFo9yIQ7PCLJBV90/M7ClFCPhqTIVv7GwoiaONEh4pmm5wsbge6qxT1Ik2b HWRbhB2Uwf2pg2rPez44b1ruUwe+ZlkDSNxhKCJtMcv/QdurJ8CJg7Uv+aRD/6kP t+KXUbGzJ49Rh9xa4PO/dCO0UsqFPKv9UPvbQRkE2Zwjl3xcB2L2am1A3zBJuVzA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D223E443C; Tue, 29 May 2018 06:38:15 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 29 May 2018 12:38:14 +0200 Message-ID: <3902265.nh2GMnEBpQ@xps> In-Reply-To: <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com> References: <20180424123255.204330-1-bruce.richardson@intel.com> <1832507.I1aXYWBlau@xps> <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 10:38:16 -0000 28/05/2018 15:20, Bruce Richardson: > On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote: > > 28/05/2018 11:33, Bruce Richardson: > > > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote: > > > > 25/05/2018 17:18, Bruce Richardson: > > > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote: > > > > > > +load_config () +{ + reset_env + . $(dirname $(readlink -e > > > > > > $0))/load-devel-config + MESON=${MESON:-meson} +} > > > > > Why does this need to be done each time? > > > > > > > > Because the config could be different for each build (see above). > > > > > > > How would it be different, it's the same command called with the same > > > environment each time? > > > > No, the idea is to adapt the environment to the build target. As an > > example, the dependencies can be different for 32-bit and 64-bit. > > > I would hope that dependency detection should solve that, but since you > already have support for that in existing build script via environment > vars, I have no objection to leveraging that in the meson scripts. Overall, > though, I'd prefer to ensure that the detection works so that everyone only > needs one environment setup in order to get all builds working > simultaneously. The dependency detection cannot work if I have dependencies in uncommon directories. I think it is important to allow testing compilation with dependencies which are available but not installed, by providing paths.