[dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

[dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

[Ferruh Yigit]

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/rel_notes/release_17_11.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 8773b086d..925612eea 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -177,7 +177,10 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_net.so.1
      librte_pdump.so.1
      librte_pipeline.so.3
+     librte_pmd_bnxt.so.1
      librte_pmd_bond.so.1
+     librte_pmd_i40e.so.1
+     librte_pmd_ixgbe.so.1
      librte_pmd_ring.so.2
      librte_port.so.3
      librte_power.so.1
-- 
2.13.5

[dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

[Ferruh Yigit]

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/api/doxy-api-index.md | 1 +
 doc/api/doxy-api.conf     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 19e0d4f3d..1e8068d7c 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -55,6 +55,7 @@ The public API headers are grouped by topics:
   [KNI]                (@ref rte_kni.h),
   [ixgbe]              (@ref rte_pmd_ixgbe.h),
   [i40e]               (@ref rte_pmd_i40e.h),
+  [bnxt]               (@ref rte_pmd_bnxt.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
 - **memory**:
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index 823554f4a..2795b6487 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -34,6 +34,7 @@ INPUT                   = doc/api/doxy-api-index.md \
                           drivers/net/bonding \
                           drivers/net/i40e \
                           drivers/net/ixgbe \
+                          drivers/net/bnxt \
                           lib/librte_eal/common/include \
                           lib/librte_eal/common/include/generic \
                           lib/librte_acl \
-- 
2.13.5

Re: [dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

[Ferruh Yigit]

On 9/11/2017 5:33 PM, Ferruh Yigit wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/api/doxy-api-index.md | 1 +
>  doc/api/doxy-api.conf     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index 19e0d4f3d..1e8068d7c 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -55,6 +55,7 @@ The public API headers are grouped by topics:
>    [KNI]                (@ref rte_kni.h),
>    [ixgbe]              (@ref rte_pmd_ixgbe.h),
>    [i40e]               (@ref rte_pmd_i40e.h),
> +  [bnxt]               (@ref rte_pmd_bnxt.h),

Hi Stephen, Ajit,

Can you please update header file with doxygen comments? Since it is
public header file now, APIs should be documented properly.

Thanks,
ferruh

>    [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)

<...>

Re: [dpdk-dev] [PATCH 2/2] doc: add API documentation for bnxt PMD

[Mcnamara, John]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, September 11, 2017 5:34 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Stephen Hurd
> <stephen.hurd@broadcom.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Subject: [PATCH 2/2] doc: add API documentation for bnxt PMD
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>


Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

[Mcnamara, John]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, September 11, 2017 5:34 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Stephen Hurd
> <stephen.hurd@broadcom.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Subject: [PATCH 1/2] doc: add shared library versions for missing PMDs
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>


Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH 1/2] doc: add shared library versions for missing PMDs

[Ferruh Yigit]

On 9/18/2017 7:22 PM, Mcnamara, John wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Monday, September 11, 2017 5:34 PM
>> To: Mcnamara, John <john.mcnamara@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Stephen Hurd
>> <stephen.hurd@broadcom.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
>> Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
>> <helin.zhang@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Ananyev,
>> Konstantin <konstantin.ananyev@intel.com>
>> Subject: [PATCH 1/2] doc: add shared library versions for missing PMDs
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied to dpdk-next-net/master, thanks.

Also reminder to adding doxygen comments into public header.
Can you make this for this release?

[dpdk-dev] [PATCH v2] doc: add shared library versions for missing PMDs

[Ferruh Yigit]

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
---
 doc/guides/rel_notes/release_17_11.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index bb0ba80c6..de637fb4b 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -198,8 +198,12 @@ The libraries prepended with a plus sign were incremented in this version.
      librte_net.so.1
      librte_pdump.so.1
      librte_pipeline.so.3
+     librte_pmd_bnxt.so.1
      librte_pmd_bond.so.1
+     librte_pmd_i40e.so.1
+     librte_pmd_ixgbe.so.1
      librte_pmd_ring.so.2
+     librte_pmd_vhost.so.1
      librte_port.so.3
      librte_power.so.1
      librte_reorder.so.1
-- 
2.13.5

Re: [dpdk-dev] [PATCH v2] doc: add shared library versions for missing PMDs

[Yang, Zhiyong]

Hi Ferruh,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, September 28, 2017 2:59 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH v2] doc: add shared library versions for missing
> PMDs
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---

Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>

>       librte_pipeline.so.3
> +     librte_pmd_bnxt.so.1
>       librte_pmd_bond.so.1
> +     librte_pmd_i40e.so.1
> +     librte_pmd_ixgbe.so.1
>       librte_pmd_ring.so.2
> +     librte_pmd_vhost.so.1
>       librte_port.so.3
>       librte_power.so.1
>       librte_reorder.so.1
> --
> 2.13.5

Re: [dpdk-dev] [PATCH v2] doc: add shared library versions for missing PMDs

[Thomas Monjalon]

Added comment:
These PMDs must be versioned because they have an API.

> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>

Applied, thanks